[digikam] [Bug 346405] New: Problem importing pick labels

[mau]

https://bugs.kde.org/show_bug.cgi?id=346405

            Bug ID: 346405
           Summary: Problem importing pick labels
           Product: digikam
           Version: 4.4.0
          Platform: Debian stable
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Sidecar Management
          Assignee: [hidden email]
          Reporter: [hidden email]

I use two computers with digikam installed, one of them as my main machine with
all my photos, and a laptop for on the way. Both of them are configured to read
and write metadata only from/to xmp sidecar files.

After editing metadata of photos in one folder on the laptop I copy the sidecar
files into the same folder on my main machine (images are already there),
replacing the sidecar files there. Then I launch digikam and let it Re-Read
metadata from files (or maintenance -> sync metadata...). Until a few weeks or
months ago this worked as expected, but now ratings are imported but pick
labels are not.

Both digikam installations are configured identically and correctly; Gilles
could already confirm the bug.

To test the issue one can also edit the pick label entry in the xmp file with a
text editor and force digikam to re-read metadata, it doesn't work.

Versions:
digikam 4.4.0
libkexiv2: 2.3.2
Exiv2: 0.24
System is Debian Jessie (becoming stable in a few weeks!)

Reproducible: Always

Steps to Reproduce:
1. Edit pick label in xmp sidecar file
2.  Re-Read metadata


Actual Results:  
Modified pick label does not show up correctly in digikam.

Expected Results:  
Modified pick label should show up.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[mau]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #1 from mau <[hidden email]> ---
Created attachment 92132
  --> https://bugs.kde.org/attachment.cgi?id=92132&action=edit
Photo as a test case

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[mau]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #2 from mau <[hidden email]> ---
Created attachment 92133
  --> https://bugs.kde.org/attachment.cgi?id=92133&action=edit
Sidecar file for the test case image

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Created attachment 92148
  --> https://bugs.kde.org/attachment.cgi?id=92148&action=edit
removeImageTags.patch

The problem was that the old tags not removed from the DB. I think the patch is
fine, what do you think Gilles?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=346405

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Maik,

Good question...

In fact we must be sure if it will work in all cases.

Marcel,

The patch is very simple. It's just a missing line in source code here ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #5 from Maik Qualmann <[hidden email]> ---
I've already thought to only remove all kinds of ColorLabel (also incorrect)
and PickLabel tags.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Maybe we need to first see if any ColorLabels and PickLabels are included in
the new set of tags.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[mau]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #7 from mau <[hidden email]> ---
Thanks for looking into this issue so fast!!!

The question is if any kind of conflict management is necessary - I don't think
so because Re-Read metadata from Image means (at least for me) basically
replace old (db) data by the new one.

Example:
Let rating = 1 in db and no pick label and one tag.
Let new xmp contain no rating, pick label = 1 and no tag.
I'd expect to "loose" the rating (so new rating = 0) and the tag.

Other opinions? Is there a difference between "no rating" and "rating = 0"?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #8 from Gilles Caulier <[hidden email]> ---
no rating == rating 0 in DB

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92148|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Created attachment 92166
  --> https://bugs.kde.org/attachment.cgi?id=92166&action=edit
removeImageTags2.patch

The rating of an image is stored in a different area of the DB. Here are the
"special" tags affected such as keywords, color and pick-label.

My solution with this patch::
If a valid color or pick-label present in XMP, must be removed the old tags
from the DB. If no valid color or pick-label available, we leave the old tags
in the DB. The behavior of the keywords is not changed.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Maik,

I'm not sure if this kind of rules must go to ImageScanner class.

Look MetadataHub class. perhaps this code already exist, in another form, and
perhaps it do not work due to an existing bug...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92166|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #11 from Maik Qualmann <[hidden email]> ---
Created attachment 92189
  --> https://bugs.kde.org/attachment.cgi?id=92189&action=edit
removeImageTags3.patch

Optimized patch again, am sure the patch at this place is correct. I have
checked it with an DB editor before and after.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92189|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #12 from Maik Qualmann <[hidden email]> ---
Created attachment 92439
  --> https://bugs.kde.org/attachment.cgi?id=92439&action=edit
removeImageTags4.patch

Only code optimization.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Maik,

As Marcel said in private mail (CC with you), patch is fine to commit.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Problem importing pick      |Problem importing pick
                   |labels                      |labels [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346405

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.10.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/6f48b8643b4263e3a73a2b7
                   |                            |cc97fbaa73d20ca3e

--- Comment #14 from Maik Qualmann <[hidden email]> ---
Git commit 6f48b8643b4263e3a73a2b7cc97fbaa73d20ca3e by Maik Qualmann.
Committed on 06/05/2015 at 16:46.
Pushed by mqualmann into branch 'master'.

apply patch #92439 to remove old pick and color tags from the DB if new tags
added
FIXED-IN: 4.10.0

M  +2    -1    NEWS
M  +26   -1    libs/database/imagescanner.cpp

http://commits.kde.org/digikam/6f48b8643b4263e3a73a2b7cc97fbaa73d20ca3e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=346405

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Git commit 6a7b6cd9f661057903f2b9aaf0fb10d552bf67ab by Gilles Caulier.
Committed on 06/05/2015 at 19:19.
Pushed by cgilles into branch 'frameworks'.

backport commit #6f48b8643b4263e3a73a2b7cc97fbaa73d20ca3e from git/master to
frameworks branch

M  +26   -1    libs/database/item/imagescanner.cpp

http://commits.kde.org/digikam/6a7b6cd9f661057903f2b9aaf0fb10d552bf67ab

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel