[digikam] [Bug 345220] New: Import ACDSee Categories to hierarchical Tags

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92108|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #34 from Maik Qualmann <[hidden email]> ---
Created attachment 92226
  --> https://bugs.kde.org/attachment.cgi?id=92226&action=edit
acdseetags6.patch

This patch is now with write support from digiKam to ACDSee.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #35 from Maik Qualmann <[hidden email]> ---
Created attachment 92227
  --> https://bugs.kde.org/attachment.cgi?id=92227&action=edit
digikam.jpg

Test image with categories for ACDSee created with digiKam.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #36 from Alan Pater <[hidden email]> ---
Cool, looks like everything is working!

I asked to Heikki Rekki to test the image created on digikam, and he reports
success.

On Tue, Apr 28, 2015 at 4:19 AM, Heikki Rekki wrote:
> Wow! Thank You all! You have done fine job!
> The categories of the test image are all fine in my system (Win7 64b,
> ACDSeePro7 64b).

https://mail.kde.org/pipermail/digikam-users/2015-April/020904.html

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #37 from Gilles Caulier <[hidden email]> ---
Maik,

The feedback sound good for this entry, at least ACDSee Interoperability work
fine in both way.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #38 from Maik Qualmann <[hidden email]> ---
I think we need a new version of exiv2 with the patch from Alan out comment 30.
I have a strange problem here. If exiv2 has not seen (open) a image with ACDSee
metadata, no metadata can be written.

digikam(5938)/KEXIV2: Cannot remove Xmp tag using Exiv2   (Error # 35 :  No
namespace info available for XMP prefix `acdsee'

digikam(5938)/KEXIV2: Cannot set Xmp tag string into image using Exiv2   (Error
# 35 :  No namespace info available for XMP prefix `acdsee'

After the first reading of an image with ACDSee metadata, the metadata can also
be written. Reproducible after each start of digiKam. Has exiv2 a temporary
cache for new metadata?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #39 from Alan Pater <[hidden email]> ---
Same goes for the "lr" namespace I believe.  exiv2 does not have a temporary
space, I thought digikam does. Or does digikam pre-register the "lr" namespace?

Otherwise exiv2 0.25 should be out in the wild in 20 days.
    http://dev.exiv2.org/projects/exiv2/roadmap

 But, of course, you can't guarantee that a given user has that version. Can
you prompt the user to upgrade?

      IF exiv2 < 0.25 THEN politely inform the user that this function needs a
newer exiv2 library ..

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #40 from Gilles Caulier <[hidden email]> ---
I think you don't need to have an update of Exiv2. Just declare namespace in
Libkexiv2 instance, as i do with LR xmp namespace here :

https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2/repository/revisions/master/entry/libkexiv2/kexiv2.cpp#L110

Note that namespace need to be unregistered at end of libkexiv2 instance, else
there is a memory leak in Adobe XMP SDK (thanks valgrind)

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #41 from Maik Qualmann <[hidden email]> ---
Created attachment 92344
  --> https://bugs.kde.org/attachment.cgi?id=92344&action=edit
libkexiv2.patch

Thanks Gilles, the namespace of ACDSee was added to libkexiv2.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #42 from Gilles Caulier <[hidden email]> ---
Well, if all patches work together, it's fine to commit.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92226|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #43 from Maik Qualmann <[hidden email]> ---
Created attachment 92345
  --> https://bugs.kde.org/attachment.cgi?id=92345&action=edit
acdseetags7.patch

Small update for the patch. Gilles, if you have no objections, I would the
patch now write into branch master.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #44 from Maik Qualmann <[hidden email]> ---
Git commit 01c9cb4e62efd2211680a87db6e1a422a2b8186b by Maik Qualmann.
Committed on 30/04/2015 at 19:04.
Pushed by mqualmann into branch 'master'.

namespace from ACDSee added

M  +2    -0    libkexiv2/kexiv2.cpp

http://commits.kde.org/libkexiv2/01c9cb4e62efd2211680a87db6e1a422a2b8186b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|HUB : Import ACDSee         |HUB : Import ACDSee
                   |Categories to hierarchical  |Categories to hierarchical
                   |Tags                        |Tags [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/0ffb27e37a2af5eb4065773
                   |                            |0d28e5f891bc42c37
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.10.0

--- Comment #45 from Maik Qualmann <[hidden email]> ---
Git commit 0ffb27e37a2af5eb40657730d28e5f891bc42c37 by Maik Qualmann.
Committed on 30/04/2015 at 19:20.
Pushed by mqualmann into branch 'master'.

apply patch #92345 to import ACDSee hierarchical categories
FIXED-IN: 4.10.0

M  +2    -1    NEWS
M  +177  -5    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/0ffb27e37a2af5eb40657730d28e5f891bc42c37

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #46 from Gilles Caulier <[hidden email]> ---
Git commit bba8e5f2ccaa0047a81c376e0d2efd0f57b3e8de by Gilles Caulier.
Committed on 01/05/2015 at 07:41.
Pushed by cgilles into branch 'frameworks'.

backport commit #01c9cb4e62efd2211680a87db6e1a422a2b8186b from git/master to
frameworks branch

M  +2    -0    src/kexiv2.cpp

http://commits.kde.org/libkexiv2/bba8e5f2ccaa0047a81c376e0d2efd0f57b3e8de

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #47 from Maik Qualmann <[hidden email]> ---
Git commit b472006f71c9774ab5194770dc2a079241e64a19 by Maik Qualmann.
Committed on 01/05/2015 at 09:46.
Pushed by mqualmann into branch 'master'.

correction if special characters in tag names exist

M  +7    -1    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/b472006f71c9774ab5194770dc2a079241e64a19

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #48 from Gilles Caulier <[hidden email]> ---
Git commit 1d4848f72664815f8e39eb19b5bcd1a4b8c6feab by Gilles Caulier.
Committed on 01/05/2015 at 12:09.
Pushed by cgilles into branch 'frameworks'.

backport commit #0ffb27e37a2af5eb40657730d28e5f891bc42c37 from git/master to
frameworks branch

M  +178  -5    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/1d4848f72664815f8e39eb19b5bcd1a4b8c6feab

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #49 from Gilles Caulier <[hidden email]> ---
Git commit ad04aa610c3425c98e59c508cf27d82f5391aca8 by Gilles Caulier.
Committed on 01/05/2015 at 12:12.
Pushed by cgilles into branch 'frameworks'.

backport commit #b472006f71c9774ab5194770dc2a079241e64a19 from git/master to
frameworks branch

M  +7    -1    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/ad04aa610c3425c98e59c508cf27d82f5391aca8

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=345220

--- Comment #50 from Gilles Caulier <[hidden email]> ---
Maik,

At end of commit from comment #45, you have performed these changes :

             return fromIptcOrXmp("Iptc.Application2.Headline",
"Xmp.photoshop.Headline");
         case MetadataInfo::Title:
         {
-            QVariant var = fromXmpLangAlt("Xmp.dc.title");
-
-            if (!var.isNull())
-            {
-                return var;
-            }
-
-            return fromIptcEmulateLangAlt("Iptc.Application2.ObjectName");
+            QString str = getImageTitles()[QString("x-default")].caption;
+
+            if (str.isEmpty())
+            {
+                return QVariant(QVariant::Map);
+            }
+
+            QMap<QString, QVariant> map;
+            map["x-default"] = str;
+            return map;
         }
         case MetadataInfo::DescriptionWriter:
             return fromIptcOrXmp("Iptc.Application2.Writer",
"Xmp.photoshop.CaptionWriter");

You drop fromIptcEmulateLangAlt() call. This is intentional ? New code will
replace it properly ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel