https://bugs.kde.org/show_bug.cgi?id=345187
Bug ID: 345187 Summary: When naming unkown faces digikam only remembers typed characters and not the selected name for the next face Product: digikam Version: 4.8.0 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: Face Management Assignee: [hidden email] Reporter: [hidden email] Digikam allows fast tagging of the same person in unkown faces by remembering the last tagged person. Unfortunatelly this only works when the name is fully typed and not selected from the list (with arrow keys and ENTER, mouse does not work, see also here:https://bugs.kde.org/show_bug.cgi?id=334244) When selecting from the list, digikam only remembers the typed characters and not the full name. Reproducible: Always Steps to Reproduce: 1. goto unknown faces 2. start typing the name of one face (do not write the full name) 3. select the correct name with arrow keys and press ENTER 4. hover with the mouse over the next face Actual Results: You can now see a textbox with the characters typed in 2. Expected Results: The full name as selected should be in the textbox, so that you can immediatelly confirm the name if it is the correct one. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
https://bugs.kde.org/show_bug.cgi?id=345187
Maik Qualmann <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] --- Comment #1 from Maik Qualmann <[hidden email]> --- Created attachment 91688 --> https://bugs.kde.org/attachment.cgi?id=91688&action=edit assignname.patch This patch sets the full name from the list. Maik -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
Maik Qualmann <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When naming unkown faces |When naming unkown faces |digikam only remembers |digikam only remembers |typed characters and not |typed characters and not |the selected name for the |the selected name for the |next face |next face [patch] -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
Maik Qualmann <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version Fixed In| |4.9.0 Latest Commit| |http://commits.kde.org/digi | |kam/e920eea8f2bd123af2a0a2a | |65c59fc60c9f6609d Status|UNCONFIRMED |RESOLVED --- Comment #2 from Maik Qualmann <[hidden email]> --- Git commit e920eea8f2bd123af2a0a2a65c59fc60c9f6609d by Maik Qualmann. Committed on 23/03/2015 at 11:32. Pushed by mqualmann into branch 'master'. Apply patch # 91688 to set the full name in the LineEdit from the completion list. FIXED-IN: 4.9.0 M +3 -2 NEWS M +5 -0 app/tags/addtagslineedit.cpp http://commits.kde.org/digikam/e920eea8f2bd123af2a0a2a65c59fc60c9f6609d -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email], | |veaceslav.munteanu90@gmail. | |com --- Comment #3 from Gilles Caulier <[hidden email]> --- Veaceslav, I take a look to small Maik patch from this file to backport it on addtagslineedit.cpp from frameworks branch. With TagModelCompletion port from KCompletion to QCompleter, i have some questions : - port still incomplete ? I see a lots of code removed. Some signals from AddTagLineEdit are not used anymore (as taggingActionActived() for ex.). - This patch really need to be backported to KF5 ? Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
--- Comment #4 from Veaceslav Munteanu <[hidden email]> --- I will come to look into QCompleter port after this week. Please add a label to all bugs resolved by Maik regarding addtagslineedit so I could track them faster when fixing the new implementation. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |Backport+ -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
--- Comment #5 from Gilles Caulier <[hidden email]> --- Veaceslav, I cannot create keywords in bugzilla (right missing). I turn on "backport" property For the moment, it's the only file to take a look in Frameworks branch about QCompleter. Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
--- Comment #6 from Gilles Caulier <[hidden email]> --- Veaceslav, QCompleter port is not yet complete in frameworks branch. Right ? Also give in mind this entry where patch from Maik still to backport from master with adjustments to be compatible with new implementation. Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
--- Comment #7 from Gilles Caulier <[hidden email]> --- Veaceslav, From your last commit in digiKam frameworks branch, few days ago, to continue QCompleter port, did you take a care about this simple patch to backport and adjust with your new code ? Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
Veaceslav Munteanu <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|http://commits.kde.org/digi |http://commits.kde.org/digi |kam/e920eea8f2bd123af2a0a2a |kam/66ecc35fbf912353d1af9ec |65c59fc60c9f6609d |4077bcb303af22a49 --- Comment #8 from Veaceslav Munteanu <[hidden email]> --- Git commit 66ecc35fbf912353d1af9ec4077bcb303af22a49 by Veaceslav Munteanu. Committed on 11/05/2015 at 22:09. Pushed by munteanu into branch 'frameworks'. Related: bug 920, bug 8, bug 2, bug 123, bug 2, bug 0, bug 2, bug 65, bug 59, bug 60, bug 9, bug 6609 M +4 -1 libs/tags/addtagslineedit.cpp http://commits.kde.org/digikam/66ecc35fbf912353d1af9ec4077bcb303af22a49 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
Veaceslav Munteanu <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED Ever confirmed|0 |1 --- Comment #9 from Veaceslav Munteanu <[hidden email]> --- I just blindly backported the commit, still can't get over that overlay bug in assignment widget in frameworks branch.. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
--- Comment #10 from [hidden email] --- Maik, Any reason to have this report re-opened ? The fix do not work with current implementation ? Gilles -- You are receiving this mail because: You are the assignee for the bug. |
In reply to this post by Stephan Olbrich
https://bugs.kde.org/show_bug.cgi?id=345187
Maik Qualmann <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #11 from Maik Qualmann <[hidden email]> --- Tested with the current version (digiKam-5.4.0), no problem found. I close this bug. Maik -- You are receiving this mail because: You are the assignee for the bug. |
Free forum by Nabble | Edit this page |