https://bugs.kde.org/show_bug.cgi?id=342996
Bug ID: 342996 Summary: Corrections for rename settings in images import [patch] Product: digikam Version: 4.6.0 Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: Import Assignee: [hidden email] Reporter: [hidden email] -Better update the name in the icon view. -This patch should close the bugs 342430 and 314441. -Rename with metadata now work when a UMS-Drive is used. -Conversion in lossless format and change the extension will be considered. Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #1 from Maik Qualmann <[hidden email]> --- Created attachment 90492 --> https://bugs.kde.org/attachment.cgi?id=90492&action=edit importrename.patch -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #2 from Maik Qualmann <[hidden email]> --- I think I will add a wait cursor. The renaming of hundreds of images with metadata can take a moment. Maik -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] --- Comment #3 from Gilles Caulier <[hidden email]> --- yes wait cursor is fine to use here... Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
Teemu Rytilahti <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.kde.org/show_b | |ug.cgi?id=342430 CC| |[hidden email] -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
Teemu Rytilahti <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.kde.org/show_b | |ug.cgi?id=314441 --- Comment #4 from Teemu Rytilahti <[hidden email]> --- Wait cursor when setting the new name to the items, right? Just read the patch but didn't test it, nevertheless it looks good :) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #5 from Maik Qualmann <[hidden email]> --- I think rename with metadata in this patch to remove for digikam 4.7.0. For each change of about 800 images from an SD card, needs the renaming with metadata about 10-15 seconds. It needs optimization. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #6 from Gilles Caulier <[hidden email]> --- The rename operation is not performed through a separated thread with cameracontroller ? What's about to use progressbar for long operation as renaming ? Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #7 from Gilles Caulier <[hidden email]> --- Maik, Did you finalize your patch for 4.7.0 planed this Sunday evening ? Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #8 from Maik Qualmann <[hidden email]> --- Gilles, Yes I create to Sunday a new patch. For the time being without renaming with metadata. My idea is to add a metadata cache for advanced renaming. To reduce file access. Maik -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #9 from Gilles Caulier <[hidden email]> --- Do you want to delay this patch inclusion for 4.8.0 release ? Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
Maik Qualmann <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90492|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #10 from Maik Qualmann <[hidden email]> --- Created attachment 90637 --> https://bugs.kde.org/attachment.cgi?id=90637&action=edit importrename2.patch Better updating the name in icon view, without moving the mouse over the icon view. Converting jpg in a lossless format and renaming the extensions work now. Code for renaming without function has removed. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |4.7.0 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit| |http://commits.kde.org/digi | |kam/7f3459d55dd453f257ece35 | |398175bba22ea4109 --- Comment #11 from Gilles Caulier <[hidden email]> --- Git commit 7f3459d55dd453f257ece35398175bba22ea4109 by Gilles Caulier. Committed on 25/01/2015 at 11:39. Pushed by cgilles into branch 'master'. Apply patch #90637 from Maik Qualmann to fix image renaming settings rules in Import Tool to work properly while downloading. Related: bug 314441, bug 329438, bug 307253, bug 342430 FIXED-IN: 4.7.0 M +3 -1 NEWS M +2 -2 utilities/importui/backend/cameracontroller.cpp M +67 -44 utilities/importui/main/importui.cpp M +1 -0 utilities/importui/main/importui.h M +5 -0 utilities/importui/views/importview.cpp M +1 -0 utilities/importui/views/importview.h http://commits.kde.org/digikam/7f3459d55dd453f257ece35398175bba22ea4109 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #12 from Gilles Caulier <[hidden email]> --- Maik, Patch is apply to git/master now and file closed. There are few others entries where dysfunctions have been detected by end-users about renaming features in Import tool : * bug 314441: closed now with this commit because this entry is supposed to be relevant of it. * bug 329438 : still open. Please review if file still valid. * bug 307253 : still open. Please review if file still valid. * bug 342430 : still open. Please review if file still valid. Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #13 from Gilles Caulier <[hidden email]> --- Git commit 0201e6fc8549ac849029daf36eaeadd6ebb4d4ae by Gilles Caulier. Committed on 25/01/2015 at 13:58. Pushed by cgilles into branch 'frameworks'. Backport commit #7f3459d55dd453f257ece35398175bba22ea4109 from git/master to frameworks branch. Related: bug 314441, bug 329438, bug 307253, bug 342430 M +3 -3 utilities/importui/backend/cameracontroller.cpp M +74 -50 utilities/importui/main/importui.cpp M +1 -0 utilities/importui/main/importui.h M +5 -0 utilities/importui/views/importview.cpp M +1 -0 utilities/importui/views/importview.h http://commits.kde.org/digikam/0201e6fc8549ac849029daf36eaeadd6ebb4d4ae -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=342996
--- Comment #14 from Gilles Caulier <[hidden email]> --- Maik, Just an important notice : In frameworks branch dedicated to port digiKam to KF5, KUrl have been replaced by QUrl. The simple backport as weel of your patch said : [ 63%] Building CXX object core/utilities/importui/CMakeFiles/importui.dir/main/importui.cpp.o /home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp: In member function ‘void Digikam::ImportUI::slotNewSelection(bool)’: /home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp:2301:36: error: no match for ‘operator=’ (operand types are ‘QUrl’ and ‘QString’) parseSettings.fileUrl = info.name; ^ /home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp:2301:36: note: candidates are: In file included from /usr/lib64/qt5/include/QtGui/qevent.h:48:0, from /usr/lib64/qt5/include/QtGui/QKeyEvent:1, from /home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.h:35, from /home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp:28: /usr/lib64/qt5/include/QtCore/qurl.h:168:11: note: QUrl& QUrl::operator=(const QUrl&) QUrl &operator =(const QUrl ©); ^ /usr/lib64/qt5/include/QtCore/qurl.h:168:11: note: no known conversion for argument 1 from ‘QString’ to ‘const QUrl&’ /usr/lib64/qt5/include/QtCore/qurl.h:178:18: note: QUrl& QUrl::operator=(QUrl&&) inline QUrl &operator=(QUrl &&other) ^ /usr/lib64/qt5/include/QtCore/qurl.h:178:18: note: no known conversion for argument 1 from ‘QString’ to ‘QUrl&&’ core/utilities/importui/CMakeFiles/importui.dir/build.make:997: recipe for target 'core/utilities/importui/CMakeFiles/importui.dir/main/importui.cpp.o' failed make[2]: *** [core/utilities/importui/CMakeFiles/importui.dir/main/importui.cpp.o] Error 1 CMakeFiles/Makefile2:2040: recipe for target 'core/utilities/importui/CMakeFiles/importui.dir/all' failed make[1]: *** [core/utilities/importui/CMakeFiles/importui.dir/all] Error 2 Makefile:117: recipe for target 'all' failed make: *** [all] Error 2 ... at this line : foreach(CamItemInfo info, list) { ParseSettings parseSettings; parseSettings.fileUrl = info.name; <<<<<<<<<<<<<<<<<< HERE parseSettings.creationTime = info.ctime; renameFiles.append(parseSettings); } That i converted like this in commit : parseSettings.fileUrl.fileName() = info.name; // TODO : Qt5 port : check if KUrl() == QString() replacement is valid here. I don't check if it work. At least it compile. Gilles -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |