[digikam] [Bug 342687] New: When creating a panorama, the date of the resulting file should be the same than the pictures used

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #18 from [hidden email] ---
Hello, I confirm that after updating Hugin to the latest release, Digikam
panorama plugin does not work anymore. Also, the new Hugin still stamped the
panorama with the date of the panorama creation, not the date at which the
images where taken.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=342687

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|4.11.0                      |5.0.0
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #19 from Gilles Caulier <[hidden email]> ---
To comment #6 :

I found the problem with the date. It's a stupid line hadcoded in source with
assign pano date to target file and later creation date. See my commit :

http://commits.kde.org/kipi-plugins/3438a50e290bd234c0373217f011e1dddd6d344a

.. into panorama/tasks/copyfilestask.cpp

  // Restore usual and common metadata from first shot.

-    KPMetadata metaSrc(urlList->constBegin().key().toLocalFile());
-    KPMetadata metaDst(panoUrl.toLocalFile());
-    metaDst.setIptc(metaSrc.getIptc());
-    metaDst.setXmp(metaSrc.getXmp());
-    metaDst.setXmpTagString("Xmp.tiff.Make",
metaSrc.getExifTagString("Exif.Image.Make"));
-    metaDst.setXmpTagString("Xmp.tiff.Model",
metaSrc.getExifTagString("Exif.Image.Model"));
-    metaDst.setImageDateTime(metaSrc.getImageDateTime(), true);        <<==
Right one
+    if (m_meta)
+    {
+        m_meta->load(urlList->constBegin().key());
+        QByteArray iptc = m_meta->getIptc();
+        QByteArray xmp  = m_meta->getXmp();
+        QString make    =
m_meta->getExifTagString(QLatin1String("Exif.Image.Make"));
+        QString model   =
m_meta->getExifTagString(QLatin1String("Exif.Image.Model"));
+        QDateTime dt    = m_meta->getImageDateTime();        <<== Moved here
!!!!
+
+        m_meta->load(panoUrl);
+        m_meta->setIptc(iptc);
+        m_meta->setXmp(xmp);
+        m_meta->setXmpTagString(QLatin1String("Xmp.tiff.Make"),  make);
+        m_meta->setXmpTagString(QLatin1String("Xmp.tiff.Model"), model);
+        m_meta->setImageDateTime(dt);      <<== and here !!!!
+
+        QString filesList;
...
-    metaDst.setXmpTagString("Xmp.kipi.PanoramaInputFiles", filesList, false);
-    metaDst.setImageDateTime(QDateTime::currentDateTime());  <<== The wrong
one

As 4.x serie is closed now, code is fixed into next 5.0.0 only...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #20 from [hidden email] ---
Great news, Gilles, many thanks !
Eager to discover Digikam 5.0.0.
Best regards.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #21 from Gilles Caulier <[hidden email]> ---
Note : if you recompile kipi-plugins yourself, there is just one line of code
to remove to fix the problem...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #22 from Benjamin Girault <[hidden email]> ---
(In reply to caulier.gilles from comment #19)
> To comment #6 :
>
> I found the problem with the date. It's a stupid line hadcoded in source
> with assign pano date to target file and later creation date. See my commit :
>
> http://commits.kde.org/kipi-plugins/3438a50e290bd234c0373217f011e1dddd6d344a
>
> .. into panorama/tasks/copyfilestask.cpp

This one is on you ;o)

http://commits.kde.org/kipi-plugins/fe279dc1be18b57854fae4476f2a10e7c4cc9c7f

And if your commit message was accurate at the time, maybe expoblending shows
the same issue...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=342687

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|kipiplugins                 |digikam
          Component|Panorama                    |Panorama
            Version|4.6.0                       |unspecified

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel