[digikam] [Bug 342687] New: When creating a panorama, the date of the resulting file should be the same than the pictures used

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

            Bug ID: 342687
           Summary: When creating a panorama, the date of the resulting
                    file should be the same than the pictures used
           Product: digikam
           Version: 4.6.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Metadata
          Assignee: [hidden email]
          Reporter: [hidden email]

When creating a panorama, the date/hour of the resulting image should be the
same than the one of the images used to create the panorama. That was the
behaviour previously. However, in digikam 4.6.0, it seems that the date/hour is
now the date of creation of the panorama.

Reproducible: Always

Steps to Reproduce:
1. Create a panorama
2. Check date/hour
3.

Actual Results:  
The date is the creation of the panorama

Expected Results:  
Date at wich the image has been taken

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=342687

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikam                     |kipiplugins
          Component|Metadata                    |Panorama
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Do you talk about file time stamp or metadata date tags ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #2 from [hidden email] ---
Hello, I do not know exactly what is the difference, but I mean the «date
created» value used in the exif and iptc fields, which is also used by digikam
to sort the image by date in the display. Previously, when we created a
panorama, it was dated and displayed with the original images, and now it is
dated at the creation time, and therefore (if images are sorted by date) is
displayed at the top of the page, and no more with the original images. The
date then needs to be set manually...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=342687

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When creating a panorama,   |Panorama file time-stamps
                   |the date of the resulting   |should be the same than the
                   |file should be the same     |stitched pictures
                   |than the pictures used      |

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Metadata can be enough. We have a method in KPMetadata to set same date
everywhere (Exif, IPTC, and XMP)

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=342687

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Panorama file time-stamps   |Panorama file time-stamps
                   |should be the same than the |should be the same than the
                   |stitched pictures           |stitched pictures [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Created attachment 92728
  --> https://bugs.kde.org/attachment.cgi?id=92728&action=edit
patch to set metadata time-stamp to pano file

Benjamin,

This simple patch set date to metadata of target pano using first image from
sets of stitched photos.

Done against KDE4 code, and can be backported as well to KF5 port

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=342687

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kipi
                   |                            |-plugins/dee9052c91e773b499
                   |                            |2bc691c670d888f8a188f4

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Git commit dee9052c91e773b4992bc691c670d888f8a188f4 by Gilles Caulier.
Committed on 30/05/2015 at 22:01.
Pushed by cgilles into branch 'master'.

apply patch #92728 to set date time-stamp to target file with original first
file of set images used to make pano.
FIXED-IN : 4.11.0

M  +1    -0    panorama/tasks/copyfilestask.cpp

http://commits.kde.org/kipi-plugins/dee9052c91e773b4992bc691c670d888f8a188f4

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=342687

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.11.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |---

--- Comment #6 from [hidden email] ---
Hello, I change the status to «unconfirmed», as in digikam 4.11 under Ubuntu,
it does not work. The panorama now has the tags from the pictures it is made,
which is fine, but the panorama timestamp is still the creation date, and not
the date at which the pictures where taken.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=342687

Alan Pater <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Alan Pater <[hidden email]> ---
Note that there are specific XMP properties for panorama images.

exiv2 0.25 supports these properties: http://www.exiv2.org/tags-xmp-GPano.html

Specification is here: https://developers.google.com/photo-sphere/metadata/

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #8 from [hidden email] ---
Hello Alan, thanks for this informations. It is convenient, as currently
digikam stores some of the panorama information (fov, projection, number of
images, etc...) in the «Description»/«Legend» field, in a text format, which is
not really usable.
However, concerning the date, I see that this xmp properties can store the date
of the first/last image used for the pano, but it does not say what is the date
assigned to the resulting pano. In my sense, the pano must be at the same date
than the images it is made from. It is how it was working previously, and when
sorted by date, the pano and the images where displayed side to side. I think
that «processing» individual images to create a pano is like processing them in
Photoshop. The creation date must be kept, and the modification date is
updated. T

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Benjamin Girault-2]

https://bugs.kde.org/show_bug.cgi?id=342687

Benjamin Girault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Benjamin Girault <[hidden email]> ---
(In reply to Alan Pater from comment #7)
> Note that there are specific XMP properties for panorama images.
>
> exiv2 0.25 supports these properties:
> http://www.exiv2.org/tags-xmp-GPano.html
>
> Specification is here: https://developers.google.com/photo-sphere/metadata/

Google did indeed publish a panorama-oriented XMP namespace. However (and I
stress here the however), this was not meant as a standard. This is merely a
namespace meant to ease the 3D rendering of a panorama by Google's javascript
API, and initially implemented in Android's photo app.

From my point of view, and what I read of your discussion on the Digikam-users
ML, there is a need to be clear on the meaning of all dates in the tags
supported by exiv2 (meaning exif, iptc, and xmp). The extra tags describing the
parameters of a panorama is a far more complex question since there is no
standard. I tried a few month back to fill out the GPano XMP namespace and make
it work this Google API, without success (its still on my todo list though).

On a side note, the plugin panorama is heavily relying on Hugin to do the
computations and process the final image, including filling out the
exif/iptc/xmp tags.

Phillipe:
If you process your panorama solely with Hugin, how does the date show up in
digiKam? is it the one you expected?

(In reply to philippe.quaglia from comment #8)
> [...] currently
> digikam stores some of the panorama information (fov, projection, number of
> images, etc...) in the «Description»/«Legend» field, in a text format, which
> is not really usable.

This is set by Hugin.

> In my sense, the pano must be at the same date than the images it is made from.

There is no such "same date", but rather "one of the date". This was the aim of
the patch from Gilles (pick one date of the original images and copy it to the
stitched image). Did you try stitching a new panorama since the version 4.11.0?
was the date showing up correct?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #10 from [hidden email] ---
Hello Benjamin, thanks for your input.
To answer your questions, i did a test with Digikam 4.12 using 3 pictures,
taken the 02/08/15 19h03. I did the panorama with Digikam, and the assigned
date is the creation date, i.e. 14/08/15 9h24. I did the panorama with Hugin,
and I get the same result. See the screen copy, with original picture with
their date, and the pano, the one in blue created by digikam, the one on left
by Hugin.
I'm sure that previously, Digikam was assigning the date of the source
pictures, i.e. 02/08/15 19h03 in that case. For picture sorting and grouping,
it is really annoying to have different time, the pano is never displayed next
to the original picture, and I need to manually change the date.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #11 from [hidden email] ---
Created attachment 94027
  --> https://bugs.kde.org/attachment.cgi?id=94027&action=edit
Screen copy, original pictures, with date

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #12 from [hidden email] ---
Created attachment 94028
  --> https://bugs.kde.org/attachment.cgi?id=94028&action=edit
Screen copy, panos, the one in blue is digikam (note the legend line) the other
one is hugin. See the attached date.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Benjamin Girault-2]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #13 from Benjamin Girault <[hidden email]> ---
Thanks for the tests. As far as I know, there hasn't been any modification in
the panorama plugin code source dealing with date and time metdata for a while
(except for Gilles' commit). On the other hand, it's possible that Hugin is
handling them differently than before. Which version of Hugin have you
installed?

I'm sure there is a possible fix in the plugin to sort out everything. For now,
I really don't have the time to do it (maybe in late October, or November, but
not sooner). If anyone is interested, anything relevant is in
panorama/tasks/copyfilestask.cpp.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #14 from [hidden email] ---
Hello Benjamin, my version of Hugin is:
Version : 2014.0.0.5da69bc383dd
I just see that version 2015 has been released few days ago. I will try to
update it and redo some tests. I'm sorry I'm of no use for
programming/resolving bugs.
Best regards.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Benjamin Girault-2]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #15 from Benjamin Girault <[hidden email]> ---
Unfortunately Hugin 2015.0 changed a few things and is not compatible with the
panorama plugin at the moment. This is another task on my todo list that will
have to wait...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #16 from Alan Pater <[hidden email]> ---
I've been off line for the last while, but now have some additional comments. I
think the resulting pano image should follow MWG guidelines for the date:

Date/time original: When the image was taken.
Date/time digitized: Same as original for images taken with a digital camera.
Date/time modified: When the the image was modified. This would be the date
that the original images were stitched together.

Is the Date/time original data being erased when creating the pano image?


http://www.metadataworkinggroup.org/pdf/mwg_guidance.pdf#page=37

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Benjamin Girault-2]

https://bugs.kde.org/show_bug.cgi?id=342687

--- Comment #17 from Benjamin Girault <[hidden email]> ---
Thanks for the info Alan.

I think that the KExiv2 API is not complete enough to correctly handle all
those date and time. At the moment there is only those two functions:
 - KExiv2::getImageDateTime
 - KExiv2::setImageDateTime
The first one tries to get a useable date/time entry (I haven't checked the
priority), and the second one writes a provided date/time to original and
modified (and optionally digitized).

Threrefore, KExiv2 does not provide the API to make the proper distinction
between those three classes of date/time. I don't mind doing it, but that will
have to wait (if anyone is interested, go ahead ;o) )

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel