[digikam] [Bug 340030] New: KIPI-plugins can not be deactivated on non-English locales

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=340030

            Bug ID: 340030
           Summary: KIPI-plugins can not be deactivated on non-English
                    locales
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkipi
          Assignee: [hidden email]
          Reporter: [hidden email]

I received the attached patch from Maik Qualmann and submit it to the
bugtracker because I do not have a system at hand to test the patch myself.

Description of the bug: Deactivated plugins are registered to digikamrc under
the translated name, but are searched for under the original name, thus the
deactivation setting is never applied.


Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=340030

--- Comment #1 from Michael G. Hansen <[hidden email]> ---
Created attachment 89165
  --> https://bugs.kde.org/attachment.cgi?id=89165&action=edit
Patch for libkipi from Maik Qualmann

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=340030

--- Comment #2 from Michael G. Hansen <[hidden email]> ---
Gilles,

can you test and apply the patch?

Best,

Michael

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=340030

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|KIPI-plugins can not be     |KIPI-plugins can not be
                   |deactivated on non-English  |deactivated on non-English
                   |locales                     |locales [patch]
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=340030

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=340030

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.5.0
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |ipi/195bc2f26864cb79852a20c
                   |                            |c6d1346ba236cff63

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Git commit 195bc2f26864cb79852a20cc6d1346ba236cff63 by Gilles Caulier.
Committed on 16/10/2014 at 21:27.
Pushed by cgilles into branch 'master'.

Apply patch #89165 to be able to turn on/off plugin from kipi host when
application language is not English
Bump ABI/API id as library fingerprint as changed
FIXED-IN: 4.5.0

M  +14   -14   CMakeLists.txt
M  +2    -2    libkipi/configwidget.cpp
M  +1    -1    libkipi/configwidget.h
M  +1    -1    libkipi/configwidget_p.cpp
M  +6    -1    libkipi/pluginloader.cpp
M  +2    -1    libkipi/pluginloader.h

http://commits.kde.org/libkipi/195bc2f26864cb79852a20cc6d1346ba236cff63

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[km]

https://bugs.kde.org/show_bug.cgi?id=340030

km <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from km <[hidden email]> ---
still doesn't work for me in 4.5.

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=340030

--- Comment #5 from Gilles Caulier <[hidden email]> ---
You need to update libkipi through KDE update, not digiKam

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas Mair]

https://bugs.kde.org/show_bug.cgi?id=340030

Andreas Mair <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Andreas Mair <[hidden email]> ---
(In reply to Gilles Caulier from comment #5)
> You need to update libkipi through KDE update, not digiKam
>
> Gilles Caulier

Hi,

I've updated to KDE 4.14.3 and digikam 4.5 now but it still doesn't work.
Which KDE version do I need?

Best regards,
Andreas

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas Mair]

https://bugs.kde.org/show_bug.cgi?id=340030

--- Comment #7 from Andreas Mair <[hidden email]> ---
OK, I'll answer myself:

I've taken a look at the sources and Gilles' commit didn't make it into KDE
4.14.3. Let's hope it will be in 4.14.4...

Best regards,
Andreas

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas Mair]

https://bugs.kde.org/show_bug.cgi?id=340030

--- Comment #8 from Andreas Mair <[hidden email]> ---
It's me again...

I've now looked into libkipi's GIT sources and the patch isn't included in
KDE/4.14 branch.
I don't know if KDE 4.14.4 is planned at all, but in case it is, I'd suggest
the patch has to be included in the KDE/4.14 branch.

Best regards,
Andreas

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=340030

--- Comment #9 from Gilles Caulier <[hidden email]> ---
As the patch add a new method and break ABI, this cannot be backport as well.

Patch still in git/master.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=340030

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libkipi                     |General
           Assignee|[hidden email]       |[hidden email]
            Product|digikam                     |libkipi
            Version|4.5.0                       |unspecified

--
You are receiving this mail because:
You are the assignee for the bug.