[digikam] [Bug 339524] New: Identity class miss d private container to improve binary compatibility

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

            Bug ID: 339524
           Summary: Identity class miss d private container to improve
                    binary compatibility
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: All
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: libkface
          Assignee: [hidden email]
          Reporter: [hidden email]

In order to preserve binary compatibility, Identity class need new accessor
methods to play with internal members. Currently all members are public. This
need to be changed as other class from libkface.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Created attachment 88899
  --> https://bugs.kde.org/attachment.cgi?id=88899&action=edit
patch for libkface

Path to make internal members private and add new methods to access on private
members.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Identity class miss d       |Identity class miss d
                   |private container to        |private container to
                   |improve binary              |improve binary
                   |compatibility               |compatibility [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Marcel,

There is a current discussion into [hidden email] mailing list to make
libkface more public into kdegraphics component, as libkipi, libkexiv2, and
libkdcraw.

This patch increase BC into Identity class in order to make this library
public.

Can you check my patches please to see if all is fine for you.

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Created attachment 88900
  --> https://bugs.kde.org/attachment.cgi?id=88900&action=edit
patch for digiKam

digiKam patch to use new libkface API

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=339524

--- Comment #4 from Marcel Wiesweg <[hidden email]> ---
Comment on attachment 88899
  --> https://bugs.kde.org/attachment.cgi?id=88899
patch for libkface

If we really believe we need this redirection, then the patch is ok I think

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88899|0                           |1
        is obsolete|                            |

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Created attachment 88902
  --> https://bugs.kde.org/attachment.cgi?id=88902&action=edit
patch for libkface (v2)

Some code polish with map iterator used in Identity attibutes loop

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tobias Leupold]

https://bugs.kde.org/show_bug.cgi?id=339524

--- Comment #6 from Tobias Leupold <[hidden email]> ---
Gilles, With v2 of your patch, KPA does not crash anymore. Everything works as
before (with the patches necessary to respect the new API of course). Thanks
:-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Thanks Tobias,

I propose to wait digiKam 4.4.0 release planed next Sunday evening before to
apply this patch on git/master.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tobias Leupold]

https://bugs.kde.org/show_bug.cgi?id=339524

--- Comment #8 from Tobias Leupold <[hidden email]> ---
I'm fine with that. I'll patch KPA git master as soon as your changes are in
libkface git, and I know which version cmake has to check (at the moment, it's
>=3.3.0). Perhaps you could drop me an email?

Nice to see that libkface is on it's way to be an "independent" library with an
own release :-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339524

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.5.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |face/cc6a4ca7d7b61eeebe8438
                   |                            |bcec2a93659af2a745

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Patches applied to git/master.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel