[digikam] [Bug 339227] New: Tags: Existing (image metadata) tags removed when adding new tags to multiple images.

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

            Bug ID: 339227
           Summary: Tags: Existing (image metadata) tags removed when
                    adding new tags to multiple images.
           Product: digikam
           Version: 4.3.0
          Platform: openSUSE RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]

When adding additional tags to multiple existing images, any tags that already
exist are removed from thos images.

To reproduce:
1. Select existing images which have tags (for example 'A', 'B', and 'C').
2. Add new tags (for example '1' and '2').

Result:
The image (tag) metadata now only has tags 1 and 2. (Previous tags A, B, and C
have been removed).

Expected result:
Image tag metadata correctly shows all tags.


This only affects the actual image metadata, the dk database correctly shows
the tags.
If only one image is updated with additional tags the image tag metadata is
correctly written.

At the moment to ensure all tags are correctly written it is necessary to
explicitly tell digiKam to 'Image, Write Metadata To Image'.

Possible regression, as this seems very similar to
https://bugs.kde.org/show_bug.cgi?id=264745

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339227

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |veaceslav.munteanu90@gmail.
                   |                            |com

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Veaceslav,

As expected, this entry have been created (:=)))...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339227

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Tags: Existing (image       |Existing tags form image
                   |metadata) tags removed when |metadata are removed when
                   |adding new tags to multiple |adding new tags to multiple
                   |images.                     |images

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339227

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Existing tags form image    |Existing tags from image
                   |metadata are removed when   |metadata are removed when
                   |adding new tags to multiple |adding new tags to multiple
                   |images                      |images

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #2 from Veaceslav Munteanu <[hidden email]> ---
So I made a scenario:

1st picture tag "A";
2nd picture tags "A", "B"
3rd picture tag "B"

after adding one tag to all 3 images above, I have all tags correctly written
to metadata.

Gilles, can you reproduce this?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #3 from Paul <[hidden email]> ---
@ Veaceslav

I've just tried your simple scenario, and that indeed worked as expected,
odd...

With a 'real world' case this is the result, shown in the attached
screen-shots.

The image initially had all of the tags shown in the tool-tip apart from
'Pending Print', this tag was added to this (and the other) test images.  All
tags, both existing and newly added are correctly shown by digiKam.

The actual meta-data written to the image is shown in the second screen-shot,
the only tag present is the one just added, all existing tags have been
removed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #4 from Paul <[hidden email]> ---
Created attachment 88846
  --> https://bugs.kde.org/attachment.cgi?id=88846&action=edit
Correct tags in dk database

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #5 from Paul <[hidden email]> ---
Created attachment 88848
  --> https://bugs.kde.org/attachment.cgi?id=88848&action=edit
Missing image meta-data

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #6 from Gilles Caulier <[hidden email]> ---
To respond about comment  #2, yes i work as expected in this case for me.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #7 from Paul <[hidden email]> ---
@ Veaceslav

As an afterthought, this is the meta-data after executing 'Image - Write
Metadata to Image' from within digikam.

If you want the test images I'm using I can put them on dropbox...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #8 from Paul <[hidden email]> ---
Created attachment 88849
  --> https://bugs.kde.org/attachment.cgi?id=88849&action=edit
Image metadata after executing 'Image - Write Metadata to Image'

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jeff Dooley]

https://bugs.kde.org/show_bug.cgi?id=339227

Jeff Dooley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Jeff Dooley <[hidden email]> ---
Test case was performed using Digikam 3.5.0 on Kubuntu 14.04, and Bug was not
reproduced. Correct writing of tags was observed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[meku-2]

https://bugs.kde.org/show_bug.cgi?id=339227

meku <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from meku <[hidden email]> ---
I have found a method to reproduce bug, running on Xubuntu with Digikam 4.3.0

Example setup with 2 files and 3 tags:
Image1, tags "A", "B"
Image2, tags "A", "C"

Select BOTH images in the thumbnail view.
Open the tags tab on the right.
(Optionally enable "Tags already assigned" for clarity)

Tags "A", "B", "C" will display, however only "A" will be ticked.
Now if you make any changes TO THE SELECTED IMAGES and Apply, the database will
be correct but only the COMMON tags will be written to the selected files.

Such that if you add tag "D", the thumbnail view will show
Image1, tags "A", "B", "D"
Image2, tags "A", "C", "D"
But the files metadata will be written as:
Image1, tags "A", "D"
Image2, tags "A", "D"

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #11 from Paul <[hidden email]> ---
This is quite an important issue, as there is potential for the loss of tags if
one assumes that they have been correctly written to the image meta-data...

@ meku
Thanks for confirming this :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #12 from Veaceslav Munteanu <[hidden email]> ---
Ok, now I can reproduce... I used to assign tags from right-click Add Tags and
it worked flawless but if you use left sidebar and apply button, it doesn't
work....

Investigating...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=339227

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/068f5924f08ba45fb9b1c4d
                   |                            |ff907eba186b9ff5f
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #13 from Veaceslav Munteanu <[hidden email]> ---
Git commit 068f5924f08ba45fb9b1c4dff907eba186b9ff5f by Veaceslav Munteanu.
Committed on 04/10/2014 at 21:47.
Pushed by munteanu into branch 'master'.

M  +1    -0    app/fileaction/databaseworkeriface.cpp
M  +1    -3    app/fileaction/fileworkeriface.cpp
M  +36   -0    app/fileaction/metadatahub.cpp
M  +13   -0    app/fileaction/metadatahub.h

http://commits.kde.org/digikam/068f5924f08ba45fb9b1c4dff907eba186b9ff5f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #14 from Veaceslav Munteanu <[hidden email]> ---
Whew... just in time.. one day before 4.4 release ^_^

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Paul]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #15 from Paul <[hidden email]> ---
Thanks! Appreciate the work you guys do. :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339227

--- Comment #16 from Gilles Caulier <[hidden email]> ---
Paul,

If you can test using git/master implementation including last patch from
Veaceslav, it will be fine. It's always good to have different people testing a
solution before a release.

I will test on my computer now.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339227

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel