[digikam] [Bug 339144] New: Crash when externally creating or updating a sidecar file

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=339144

            Bug ID: 339144
           Summary: Crash when externally creating or updating a sidecar
                    file
           Product: digikam
           Version: 4.3.0
          Platform: Gentoo Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

digiKam-4.3.0 crashes when creating or updating a sidecar file.

Reproducible: Always

Steps to Reproduce:
1. Add "pp3" to Configure digiKam > MIME Types > Image/Movie/Audio Files.
Doesn't matter which. Restart if needed.
2. Open some album, /photos/2015
3. From a console, "touch foo.pp3" in that album.
Crash

Same if you edit an existing pp3 and save.



I attached the DrKonqi debug log.

Next I recompiled digiKam with debug flags, did the same except instead of
creating it with "touch" i deleted it with "rm", and here is the gdb stack
backtrace:
http://dpaste.com/30PP371

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=339144

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Crash when externally       |Crash when externally
                   |creating or updating a      |creating, updating or
                   |sidecar file                |deleting a sidecar file
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=339144

--- Comment #1 from DrSlony <[hidden email]> ---
Created attachment 88721
  --> https://bugs.kde.org/attachment.cgi?id=88721&action=edit
DrKonqi report of non-debug type build

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339144

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
It crash in Exiv2 shared lib at preview extraction :

Thread 2 (Thread 0x7f7fc37fe700 (LWP 4029)):
[KCrash Handler]
#5  0x00007f7ffab660a2 in
Exiv2::PreviewManager::getPreviewImage(Exiv2::PreviewProperties const&) const
() from /usr/lib64/libexiv2.so.13
#6  0x00007f8001f7ce12 in KExiv2Iface::KExiv2Previews::data(int) () from
/usr/lib64/libkexiv2.so.11

I remember to have consolidated code in libkexiv2 to not crash with irrelevant
offset in preview container taken from Exiv2.

Did you use libkexiv2 code provided with digiKam tarball, or system based ?
Look details from Help/Component Info dialog. Libkexiv2 version must be 2.3.2.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=339144

--- Comment #3 from DrSlony <[hidden email]> ---
LibExiv2: 0.24
LibKExiv2: 2.3.1

Portage tells me libkexiv2-4.14.0 is installed, whatever that is. I don't know
whether the ebuild used that one, or the one in the tarball, but if 2.3.2 is in
the tarball then I guess it used the system one.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339144

--- Comment #4 from Gilles Caulier <[hidden email]> ---
No. If digikam said that libkexiv2 version 2.3.1, it's not 2.3.2.

When digiKam is configured before compilation, to use libkexiv2 from tarball,
you need to turn on this cmake switch :

https://projects.kde.org/projects/extragear/graphics/digikam/digikam-software-compilation/repository/revisions/master/entry/README#L123

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |crash

--- Comment #5 from Christoph Feck <[hidden email]> ---
Multiple crashes ending here... is this a BIC in libkexiv2 that needs to be
reported to distributions?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Crash when externally       |digiKam crashes in
                   |creating, updating or       |libkexiv2 metadata handling
                   |deleting a sidecar file     |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Christoph Feck <[hidden email]> ---
*** Bug 339150 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Christoph Feck <[hidden email]> ---
*** Bug 339151 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Christoph Feck <[hidden email]> ---
*** Bug 339152 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Christoph Feck <[hidden email]> ---
*** Bug 339158 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

--- Comment #10 from Christoph Feck <[hidden email]> ---
This had already been reported as bug 339088. Given the variety of bug reports,
I doubt that the bug is upstream.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|NOR                         |VHI

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339144

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |CONFIRMED

--- Comment #11 from Christoph Feck <[hidden email]> ---
Backtrace from bug 339152 confirms that libkexiv2 calls
Exiv2::PreviewManager::getPreviewImage() with a null object pointer.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339144

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |libkexiv2

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339144

--- Comment #12 from Gilles Caulier <[hidden email]> ---
This commit must prevent this kind of crash :

https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2/repository/revisions/26d707eb08a88341449c1dff2637bf40551a6a75

But it have been introduced with libkexiv2 2.3.2

Gilles caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=339144

Rex Dieter <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #13 from Rex Dieter <[hidden email]> ---
The commit referenced in comment #12 seems to be only in master/ branch, not
4.14/ .  Would be ideal to backport so it gets included in the next 4.14.2
point release.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=339144

--- Comment #14 from Rex Dieter <[hidden email]> ---
I could help do that, if there are no objections.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339144

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Rex,

You are welcome to backport this commit to 4.14 branch. No problem. patch is
very simple as you can seen.

I just delayed to do it myself to be sure that no side effects have been
introduced by this commit.

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel