[digikam] [Bug 339082] New: Allow a simpler way to place a photo in fullscreen

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

            Bug ID: 339082
           Summary: Allow a simpler way to place a photo in fullscreen
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Preview
          Assignee: [hidden email]
          Reporter: [hidden email]

While working with digikam I noticed a few times people (including me) simply
looking for a quick way to look for a photo (in an album) and then open it in
fullscreen. Then simply moving to the next or the previous when ready. Pretty
simple.

In the current implementation (3.5.0) I see that it is possible to do this by
opening a slideshow from selection (of the target photo), but this won't allow
the user to move to the other photos in the same album.
Or, by opening a slideshow for the entire album, which instead opens the first
photo in the album (not the one I selected). Also it then moves automatically.
I don't think this is the same.
Possible "solution" is to modify the settings to start from the current image
and to make the delay very large. This does what I think is the simplest usage.
But it requires to tweak the settings and a large delay makes the other
slideshows not automatic anymore.

Also, when a photo is opened in preview, double click on it does not go to
fullscreen. It seems to me a little unnatural.

After consulting on IRC, something different came up: without any modification
of the settings, double clicking on a photo in preview mode opens the photo in
fullscreen and simply stays there as long as the user wants. Using the arrows
then the rest of the album can be browsed. The escape button goes back to
preview, and then again to thumbnails.
This kind of behavior does not influence the existing slideshows.

This feels a little more natural to me. Anyone else who agree by any chance?

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

Luca Carlon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow a simpler way to      |Allow a simpler way to
                   |place a photo in fullscreen |place a photo in fullscreen
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #1 from Luca Carlon <[hidden email]> ---
Created attachment 88703
  --> https://bugs.kde.org/attachment.cgi?id=88703&action=edit
Patch that adds a new "fullscreen mode" and binds it the the double click in
the preview.

This patch adds the new "fullscreen mode" and also considers it some kind of
"manual slideshow". On IRC this came up to be inappropriate as not to be
considered an actual slideshow. So that part may be removed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #2 from Luca Carlon <[hidden email]> ---
I have to say the patch does not completely satisfy me but... you guys may help
improving it...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Luca,

With current implementation from git/master, a lots of changes have been done
to SlideShow.

You patch cannot be applied and tested. Can you update it and adapt your code
to new implementation ?

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alexander Fieroch]

https://bugs.kde.org/show_bug.cgi?id=339082

Alexander Fieroch <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Alexander Fieroch <[hidden email]> ---
Luca,

I agree with you. Have a look at

https://bugs.kde.org/show_bug.cgi?id=280133

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

Luca Carlon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88703|0                           |1
        is obsolete|                            |

--- Comment #5 from Luca Carlon <[hidden email]> ---
Created attachment 89690
  --> https://bugs.kde.org/attachment.cgi?id=89690&action=edit
Patch that applies to 81a53fe to implement fullscreen.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #6 from Luca Carlon <[hidden email]> ---
Can someone review this patch before new modifications make it impossible to
apply again?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Please sync the patch with current implementation from git/master.

Branching code to port to KF5 will be done after 4.6.0 release
(https://techbase.kde.org/Projects/Digikam/CodingSprint2014#KDE_Framework_Port)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Luca,

Any change to have this patch updated with last implementation from git/master
?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #9 from Luca Carlon <[hidden email]> ---
A third implementation of the same feature?! Impossible to apply again?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Luca,

I don't understand what you mean exactly (:=))... ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Luca, no response ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #12 from Luca Carlon <[hidden email]> ---
I already wrote this patch two times. Where would you like this applied? git
master?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #13 from Gilles Caulier <[hidden email]> ---
yes git/master...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

Luca Carlon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89690|0                           |1
        is obsolete|                            |

--- Comment #14 from Luca Carlon <[hidden email]> ---
Created attachment 94106
  --> https://bugs.kde.org/attachment.cgi?id=94106&action=edit
Patch that applies to 274d73d.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #15 from Luca Carlon <[hidden email]> ---
Could you please have a look at the new patch? It seems to work as expected for
me.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #16 from Luca Carlon <[hidden email]> ---
Any comment on this patch? Should I change something?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=339082

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #17 from Maik Qualmann <[hidden email]> ---
The idea for a quick full screen mode I like that. Only I would not like to
lose the left mouse button click, to return to the icon view. Instead of double
click, I would for a overlay button in the preview or an additional entry in
the slideshow menu. We'll see what Gilles says.

Improvements to the patch:

- Slideshow->With All Sub-Albums is not working (builder->run() is missing)
- Unused variable delay
- Remove qDebug

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #18 from Gilles Caulier <[hidden email]> ---
The ide

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel