[digikam] [Bug 339082] New: Allow a simpler way to place a photo in fullscreen

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #19 from Gilles Caulier <[hidden email]> ---
The idea to use an overlay is fine for me.

This want mean to support this kind of display mode switch over icon view and
thumbbar ? If yes, i'm agree...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #20 from Luca Carlon <[hidden email]> ---
Mmh... ok, I can probably do that. But... am I the only one who feels more
natural that double click "opens" to fullscreen?
On a desktop computer I typically see that double clicks (or single clicks)
"open" the target, while the escape button or whatever else "close" or "go
back". So from the icon view I click and I "open" the image in the preview,
when I click (or better double click) the preview I "open" the image to
fullscreen... while escape, the button in the toolbar and whatever else "go
back" to preview and again to the icon view.
By having a look around i see iPhoto actually does what you proposed, while
gwenview does more or less what I said.
So, if you confirm you want an overlay button I can try to modify and fix the
patch according to the behaviour you requested.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #21 from Gilles Caulier <[hidden email]> ---
overlay button -> yes, confirmed...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #22 from Gilles Caulier <[hidden email]> ---
Another note : All icon view overlay are optional and can be turned on/of to
Setup/Album View tab from Config dialog.

Your new overlay must be configurable.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #23 from Luca Carlon <[hidden email]> ---
Hello,
sorry, I have a doubt about the decision. Maik said "[...] I would for a
overlay button in the preview [...]" but then Gilles said "All icon view
overlay are optional [...]". So, where is this overlay button supposed to be
placed? In the icon view (which is marked as thumbnails in the toolbar button)
or in the preview view (marked as preview image in the toolbar)?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #24 from Gilles Caulier <[hidden email]> ---
The overlay is over each icon-view item, as for ex the GPS indicator overlay,
which can be enable or disable into Album-view setup page.

This has nothing to see with toolbar.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #25 from Luca Carlon <[hidden email]> ---
Created attachment 94311
  --> https://bugs.kde.org/attachment.cgi?id=94311&action=edit
Result.

Before I go on with the implementation, is this the result you expect? Of
course I need a proper icon, maybe I can use the one used in fullscreen.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #26 from Gilles Caulier <[hidden email]> ---
yes it's the right way...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #27 from Luca Carlon <[hidden email]> ---
What icon should I use for the overlay?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #28 from Gilles Caulier <[hidden email]> ---
The same icon that one used with Slideshow button from main toolbar.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

Luca Carlon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94106|0                           |1
        is obsolete|                            |

--- Comment #29 from Luca Carlon <[hidden email]> ---
Created attachment 94425
  --> https://bugs.kde.org/attachment.cgi?id=94425&action=edit
Patch that applies to 19da552.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Luca Carlon]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #30 from Luca Carlon <[hidden email]> ---
Can someone review this patch? It includes new setup to show/hide the overlay,
the overlay itself in icon view, the new "slide show" mode and a similar button
in preview.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94311|0                           |1
        is obsolete|                            |
  Attachment #94425|0                           |1
        is obsolete|                            |

--- Comment #31 from Gilles Caulier <[hidden email]> ---
Created attachment 94426
  --> https://bugs.kde.org/attachment.cgi?id=94426&action=edit
Full Screen Overlay patch 2

I review patch and fixed some details about overlay icon size which follow
thumbnails size, since we have integrated changes from bug #261568.

Maik, please try this patch. If all is fine for you, let's go to apply it to
git/master

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow a simpler way to      |Allow a simpler way to
                   |place a photo in fullscreen |place a photo in
                   |[patch]                     |full-screen using overlay
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.13.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #32 from Maik Qualmann <[hidden email]> ---
I have made still polishes. I find the full screen icon is not suitable for
round overlay buttons. The corners of the icon are over. Possibly the
"media-playback-start" button?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #33 from Gilles Caulier <[hidden email]> ---
I faced the same problem when i test the patch.

I don't find a right icon (rounded) from Oxygen sets...

And yes, perhaps "media-playback-start" button is fine. As i can see, Gwenview
use it with a similar action from menu.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=339082

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94426|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=339082

--- Comment #34 from Maik Qualmann <[hidden email]> ---
Created attachment 94438
  --> https://bugs.kde.org/attachment.cgi?id=94438&action=edit
Full Screen Overlay patch 3

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=339082

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.14.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/e65663863acf06671adc3e7
                   |                            |19d6f75ce3fbb4fa9

--- Comment #35 from Maik Qualmann <[hidden email]> ---
Git commit e65663863acf06671adc3e719d6f75ce3fbb4fa9 by Maik Qualmann.
Committed on 06/09/2015 at 20:47.
Pushed by mqualmann into branch 'master'.

apply patch #94438 from Luca Carlon to allow a simpler way to place a photo in
full-screen
FIXED-IN: 4.14.0

M  +1    -0    CMakeLists.txt
M  +2    -1    NEWS
M  +17   -0    app/items/digikamimageview.cpp
M  +2    -0    app/items/digikamimageview.h
M  +27   -0    app/items/digikamimageview_p.cpp
M  +3    -0    app/items/digikamimageview_p.h
A  +122  -0    app/items/overlays/imagefsoverlay.cpp     [License: GPL (v2+)]
A  +87   -0    app/items/overlays/imagefsoverlay.h     [License: GPL (v2+)]
M  +2    -0    app/settings/applicationsettings.cpp
M  +3    -0    app/settings/applicationsettings.h
M  +10   -0    app/settings/applicationsettings_iconview.cpp
M  +3    -0    app/settings/applicationsettings_p.cpp
M  +2    -0    app/settings/applicationsettings_p.h
M  +25   -5    app/utils/slideshowbuilder.cpp
M  +12   -0    app/utils/slideshowbuilder.h
M  +33   -2    app/views/digikamview.cpp
M  +2    -0    app/views/digikamview.h
M  +9    -0    app/views/imagepreviewview.cpp
M  +1    -0    app/views/imagepreviewview.h
M  +3    -0    app/views/stackedview.cpp
M  +1    -0    app/views/stackedview.h
M  +10   -1    utilities/setup/setupalbumview.cpp
M  +8    -0    utilities/slideshow/slideshowsettings.h
M  +7    -4    utilities/slideshow/slidetoolbar.cpp

http://commits.kde.org/digikam/e65663863acf06671adc3e719d6f75ce3fbb4fa9

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel