[digikam] [Bug 337878] New: In "Preview Image" the Focus should stay in the middle - showing focus + 2 pictures ahead and past

[Greg4b]

https://bugs.kde.org/show_bug.cgi?id=337878

            Bug ID: 337878
           Summary: In "Preview Image" the Focus should stay in the middle
                    - showing focus + 2 pictures ahead and past
           Product: digikam
           Version: 4.1.0
          Platform: MS Windows
                OS: MS Windows
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Preview
          Assignee: [hidden email]
          Reporter: [hidden email]

Current behavior: the focus is in the right side of the area - thus not showing
the upcoming pictures.

Whishing behavior: focus stays in the middle fixed and at least the next 2 and
the last 2 pictures are shown (or more)

        FOCUS
-2   -1   0   +1   +2

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Greg4b]

https://bugs.kde.org/show_bug.cgi?id=337878

Greg4b <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |om

--- Comment #1 from Greg4b <[hidden email]> ---
Created attachment 88010
  --> https://bugs.kde.org/attachment.cgi?id=88010&action=edit
focus should stay in the middle

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Preview                     |Thumbnails
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|In "Preview Image" the      |Thumbbar item focus must
                   |Focus should stay in the    |stay in the middle
                   |middle - showing focus + 2  |
                   |pictures ahead and past     |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Thumbbar item focus must    |THUMBBAR : item focus must
                   |stay in the middle          |stay in the middle

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #2 from Gilles Caulier <[hidden email]> ---
digiKam 4.7.0 for Windows is available :

http://download.kde.org/stable/digikam/digiKam-installer-4.7.0-1-win32.exe.mirrorlist

Please test and report.

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337878

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Created attachment 91823
  --> https://bugs.kde.org/attachment.cgi?id=91823&action=edit
scrolltocenter.patch

I need a feedback, whether you like this feature. This patch centered the
current image in the preview mode of the import and digikam thumb bar.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337878

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|THUMBBAR : item focus must  |THUMBBAR : item focus must
                   |stay in the middle          |stay in the middle [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Maik,

Your patch touch stackedview from Album GUI and Import tool to control position
of thumbbar items when contents is review in preview mode.

What's about Image editor and showfoto. I can load dir with more than one items
and change item focus with pageup page down while thumbbar is displayed near
canvas. It can make a sense also to have current item loaded in thumbbar
center.

Other case is LightTable where a thumbar is used to view items list on pool. We
can change item to compare on the right side with item on the left side using
keyboard. In this case thumbbar focus must follow item displayed on right
canvas...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Greg4b]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #5 from Greg4b <[hidden email]> ---
(In reply to Maik Qualmann from comment #3)
> Created attachment 91823 [details]
> scrolltocenter.patch
>
> I need a feedback, whether you like this feature. This patch centered the
> current image in the preview mode of the import and digikam thumb bar.
>
> Maik

Hello Maik,

I'm sorry, but I'm not familiar with patches...

I've tried Version 4.7.0 Using KDE Development Platform 4.10.2 and the
situation is unchaned.

I could provide feedback, when Instruction about patching the Version 4.7.0 is
provided.

Thanks,

Gregor

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Greg,

The patch is not intrusive and can be applied to 4.7.0 source code.

This want to have digiKam source code on your computer and to apply patch to
source. Recompilation and re-installation is of course mandatory.

Did you install digiKam through a package or using source code (tarball) ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Greg4b]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #7 from Greg4b <[hidden email]> ---
Hello Gilles,

I've installed the Version 4.7.0 through a package.

I'm afraid, I'm not able to install a development environment, since this is a
company computer.

Thanks,

Gregor

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337878

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91823|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #8 from Maik Qualmann <[hidden email]> ---
Created attachment 91865
  --> https://bugs.kde.org/attachment.cgi?id=91865&action=edit
scrolltocenter2.patch

This patch for testing contains now all thumb bars. It is a time controlled
scroll activation needed to obtain a uniform visual feedback.
For to LightTable I find the centering of the thumbnails more of a hindrance.
ShowFoto has the thumb bar a KineticScroller - was unknown to me, nice. Here
test the interaction. Could the centering of the thumbnails disrupt the
workflow of other users?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #9 from Gilles Caulier <[hidden email]> ---
The patch has some problems with D&D.

From thumb-bars it's possible to operate D&D with other parts of application
(or with extra applications as Dolphin for ex)

Your current patch scroll thumb-bar to the center when D&D start to be
initiate. This is very problematic...

Typically, you must :

1/ detect is D&D is initiate.
2/ scroll selected item to center after that D&D is completed, else GUI
behavior is confuse.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Yes, D&D is broken. I also find that if you use the buttons, the thumbnail
image should not jump, but firmly stand in the middle.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Maik,

Any progress here ?

Did you seen also bug #338918 ? It can depend of this file i think...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #12 from Gilles Caulier <[hidden email]> ---
Maik,

There is another entry in bugzilla which depend of this one more or less :

https://bugs.kde.org/show_bug.cgi?id=344952

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337878

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91865|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=337878

--- Comment #13 from Maik Qualmann <[hidden email]> ---
Created attachment 92743
  --> https://bugs.kde.org/attachment.cgi?id=92743&action=edit
scrolltocenter3.patch

New patch for testing to center the current thumbnail.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel