[digikam] [Bug 336253] New: Create a New tag, Unconfirmed Faces

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #16 from Gilles Caulier <[hidden email]> ---
So, file can be closed as well ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Henrique Santos Fernandes]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #17 from Henrique Santos Fernandes <[hidden email]> ---
This does not work if you manually tag person before.

Or i missed something?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Henrique Santos Fernandes]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #18 from Henrique Santos Fernandes <[hidden email]> ---
And the this only works if you want to confirm a specif person..

If you just want to confirm or not all pictures that are unconfirmed that is
not possible...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Liz]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #19 from Liz <[hidden email]> ---
After trying this out for a while, I agree with the last comment. I have a
large number of people tagged, and having to check them one at a time for new
unconfirmed matches is very tedious. It would be much better if all unconfirmed
faces could be shown in a single list, grouped by person.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[andregronwald78]

https://bugs.kde.org/show_bug.cgi?id=336253

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #20 from [hidden email] ---
Yes, I would appreciate such a feature as well. I knew it from Picasa a long
time ago, that was great...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[greenleaf123]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #21 from [hidden email] ---
Just a note in regard to the workflow of comment 13: For me it (quite
immediately) ended with digikam 3.5 in bug 338176 (see also bug 323888 as you
may have to relearn faces to resolve bug 338176).

I wholeheartedly agree to comment 19.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

Evert Vorster <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #22 from Evert Vorster <[hidden email]> ---
Just using the newest DigiKam 5.0.0 now, and this is still an issue.
I have many faces detected in my thousands of photos.

The method of finding photos without a tag does not work, as the photo gets a
tag when there is another already tagged face in it.

Really, we need a tag called unconfirmed face, and grouped by who the software
thinks it is.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.10.0                      |5.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #23 from [hidden email] ---
I'm willing to work on this issue given minimal direction from core developers.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #24 from Mario Frank <[hidden email]> ---
Created attachment 103438
  --> https://bugs.kde.org/attachment.cgi?id=103438&action=edit
Patch for unconfirmed Person tag

I second the feature request, too.

But I think using filters is not so nice. The user would have to mark the faces
before recognition. And he would have to mark all images he imports.
Meaning: When we have a Unknown tag, why don't we also have an Unconfirmed tag
where all unconfirmed images are shown? The user could see transparently
which faces need to be confirmed and does not need to add markings which he has
to remove at the end again.

I took some time at the weekend to find some way to accomplish that.
In fact it was not even this complex.

I introduced the new special tag Unconfirmed which is automatically created if
not present. In detection phase, faces are marked as unknown as usual.
In recognition phase, the faces are marked with the recognised face tag, as
usual. But additionally, they are connected as autodetected person to the
Unconfirmed tag. In this property, I store the id of the person as which the
face was recognised and also the face region.

With small adoptions in the image lister all recognised faces are now shown
both in the face tag which was recognised (person A) and the Unconfirmed tag
(with the suggested tag being person A).

Confirming the person can now be done in both tags. And the confirmed identity
is set as expected. Confirming the face also removes the face from unconfirmed
tag.
Rejecting the face also removes the face from both the recognised tag and also
from the Unconfirmed tag. Rescanning for faces (detection) also removes the
connection
to the Unconfirmed tag if unconfirmed results should be thrown away.

Can someone revise my patch?

--
You are receiving this mail because:
You are the assignee for the bug.

[Simon Frei]

I don't have time to look at it in the moment, but one question: Would
it also be (easily) possible to show unconfirmed faces of just one
person? Maybe a switch to show unconfirmed only, confirmed only or both
instead of one "container" with all the unconfirmed results.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #25 from Simon <[hidden email]> ---
I don't have time to look at it in the moment, but one question: Would
it also be (easily) possible to show unconfirmed faces of just one
person? Maybe a switch to show unconfirmed only, confirmed only or both
instead of one "container" with all the unconfirmed results.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #26 from Mario Frank <[hidden email]> ---
(In reply to Simon from comment #25)
> I don't have time to look at it in the moment, but one question: Would
> it also be (easily) possible to show unconfirmed faces of just one
> person? Maybe a switch to show unconfirmed only, confirmed only or both
> instead of one "container" with all the unconfirmed results.

I currently see no easy way. The only thing that *could* be quite easy
is grouping by face tag.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #27 from [hidden email] ---
I take a look in patch, and it's sound fine. I don't yet tested it. I will do
it this evening.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #28 from [hidden email] ---
Mario,

The patch work as expected here. perfect.

Wolfgang,

As the workflow have changed for face recognition step, this must be described
in handbook.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/7a7c29c0b8b36bd30a190a
                   |                            |6cb4dc5f43960034a8
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.5.0
             Status|CONFIRMED                   |RESOLVED

--- Comment #29 from Mario Frank <[hidden email]> ---
Git commit 7a7c29c0b8b36bd30a190a6cb4dc5f43960034a8 by Mario Frank.
Committed on 16/01/2017 at 18:24.
Pushed by mfrank into branch 'master'.

I introduced the new special tag Unconfirmed which is automatically created if
not present. In detection phase, faces are marked as unknown as usual.
In recognition phase, the faces are marked with the recognised face tag, as
usual. But additionally, they are connected as autodetected person to the
Unconfirmed tag. In this property, I store the id of the person as which the
face was recognised and also the
face region.

With small adoptions in the image lister all recognised faces are now shown
both in the face tag which was recognised (person A) and the Unconfirmed tag
(with the suggested tag being person A).

Confirming the person can now be done in both tags. And the confirmed identity
is set as expected. Confirming the face also removes the face from unconfirmed
tag.
Rejecting the face also removes the face from both the recognised tag and also
from the Unconfirmed tag. Rescanning for faces (detection) also removes the
connection
to the Unconfirmed tag if unconfirmed results should be thrown away.
FIXED-IN: 5.5.0

M  +3    -1    NEWS
M  +10   -0    libs/database/coredb/coredbconstants.cpp
M  +2    -0    libs/database/coredb/coredbconstants.h
M  +21   -3    libs/database/item/imagelister.cpp
M  +25   -0    libs/database/tags/facetags.cpp
M  +3    -0    libs/database/tags/facetags.h
M  +15   -1    libs/database/tags/facetagseditor.cpp
M  +12   -0    libs/database/tags/facetagsiface.cpp
M  +5    -0    libs/database/tags/facetagsiface.h

https://commits.kde.org/digikam/7a7c29c0b8b36bd30a190a6cb4dc5f43960034a8

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #30 from [hidden email] ---
Mario,

Turn on "Setup/Views/Tree-Views/Show a count of items..." option. Unconfirmed
tag still at zero.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #31 from Mario Frank <[hidden email]> ---
Git commit f11e34f7c376e92d8820c81f743a7fdeaaa380a1 by Mario Frank.
Committed on 16/01/2017 at 20:20.
Pushed by mfrank into branch 'master'.

This patch introduces the functionality to filter tags for assigning.
Only face tags are given if configured so. The setup option is located in misc
setup settings.

Also, the Unconfirmed face tag now shows the count of contained faces.
Related: bug 262168
FIXED-IN: 5.5.0

M  +3    -1    NEWS
M  +10   -0    app/items/overlays/assignnameoverlay.cpp
M  +3    -0    libs/database/dbjobs/dbjob.cpp
M  +2    -0    libs/settings/applicationsettings.cpp
M  +3    -0    libs/settings/applicationsettings.h
M  +10   -0    libs/settings/applicationsettings_miscs.cpp
M  +3    -0    libs/settings/applicationsettings_p.cpp
M  +3    -0    libs/settings/applicationsettings_p.h
M  +11   -0    utilities/facemanagement/assignnamewidget.cpp
M  +8    -2    utilities/setup/setupmisc.cpp

https://commits.kde.org/digikam/f11e34f7c376e92d8820c81f743a7fdeaaa380a1

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #32 from Mario Frank <[hidden email]> ---
(In reply to caulier.gilles from comment #30)
> Mario,
>
> Turn on "Setup/Views/Tree-Views/Show a count of items..." option.
> Unconfirmed tag still at zero.
>
> Gilles

Hey Gilles,
fixed that one, too.

Will see what I can fix in the next days. For today I'm done ... headache.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=336253

--- Comment #33 from Henrique Santos Fernandes <[hidden email]> ---
Thank you guys.

I'vent really used face detection because of this.

Actually i need to update my digikam installation.

--
You are receiving this mail because:
You are the assignee for the bug.