[digikam] [Bug 333387] New: Tags manager: Unavailable actions should be disabled when root item is selected

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=333387

            Bug ID: 333387
           Summary: Tags manager: Unavailable actions should be disabled
                    when root item is selected
    Classification: Unclassified
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]

When the root item is selected in the tags manager, the "-" action and the
"Reset tag icon" actions should IMHO be disabled in the UI. When clicking on
the "-" action, nothing happens, while the "Reset tag icon" action opens an
explaining message box.

Digikam version: git master

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=333387

--- Comment #1 from Michael G. Hansen <[hidden email]> ---
The action "Add to list" should also be disabled when no tag is selected.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=333387

--- Comment #2 from Michael G. Hansen <[hidden email]> ---
When selecting "All tags" in the quick access list, the context menu action
"Delete selected from list" is also still available however does nothing.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=333387

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=333387

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #3 from Veaceslav Munteanu <[hidden email]> ---
Confirmed. Will fix them soon.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=333387

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/611e523a95616f82ec1cd81
                   |                            |8a18afefb4ccce82e

--- Comment #4 from Veaceslav Munteanu <[hidden email]> ---
Git commit 611e523a95616f82ec1cd818a18afefb4ccce82e by Veaceslav Munteanu.
Committed on 01/06/2014 at 20:26.
Pushed by munteanu into branch 'master'.
Related: bug 1

M  +27   -3    digikam/tags/tagsmanager/tagsmanager.cpp
M  +5    -0    digikam/tags/tagsmanager/tagsmanager.h

http://commits.kde.org/digikam/611e523a95616f82ec1cd818a18afefb4ccce82e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=333387

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|http://commits.kde.org/digi |http://commits.kde.org/digi
                   |kam/611e523a95616f82ec1cd81 |kam/dd0a20c8fec10887d0a9ab6
                   |8a18afefb4ccce82e           |634774dfa51c924bb

--- Comment #5 from Veaceslav Munteanu <[hidden email]> ---
Git commit dd0a20c8fec10887d0a9ab6634774dfa51c924bb by Veaceslav Munteanu.
Committed on 01/06/2014 at 21:07.
Pushed by munteanu into branch 'master'.
Related: bug 2

M  +4    -0    digikam/tags/tagsmanager/models/tagmngrlistview.cpp
M  +5    -0    digikam/tags/tagsmanager/taglist.cpp
M  +6    -0    digikam/tags/tagsmanager/taglist.h
M  +5    -3    digikam/tags/tagsmanager/tagsmanager.cpp

http://commits.kde.org/digikam/dd0a20c8fec10887d0a9ab6634774dfa51c924bb

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=333387

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|http://commits.kde.org/digi |http://commits.kde.org/digi
                   |kam/dd0a20c8fec10887d0a9ab6 |kam/879544275294331fe46b5f5
                   |634774dfa51c924bb           |26dce2afeb35cbbd9

--- Comment #6 from Veaceslav Munteanu <[hidden email]> ---
Git commit 879544275294331fe46b5f526dce2afeb35cbbd9 by Veaceslav Munteanu.
Committed on 01/06/2014 at 21:27.
Pushed by munteanu into branch 'master'.

M  +12   -2    digikam/tags/tagsmanager/tagpropwidget.cpp

http://commits.kde.org/digikam/879544275294331fe46b5f526dce2afeb35cbbd9

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=333387

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|http://commits.kde.org/digi |http://commits.kde.org/digi
                   |kam/879544275294331fe46b5f5 |kam/5fc74bb58526b65adc29701
                   |26dce2afeb35cbbd9           |5398e5f1dcc5ebbd5

--- Comment #7 from Veaceslav Munteanu <[hidden email]> ---
Git commit 5fc74bb58526b65adc297015398e5f1dcc5ebbd5 by Veaceslav Munteanu.
Committed on 01/06/2014 at 22:17.
Pushed by munteanu into branch 'master'.

M  +22   -1    digikam/tags/tagsmanager/tagmngrtreeview.cpp

http://commits.kde.org/digikam/5fc74bb58526b65adc297015398e5f1dcc5ebbd5

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=333387

--- Comment #8 from Veaceslav Munteanu <[hidden email]> ---
I'm done with fixing, if you find anything else, please reopen :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=333387

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=333387

--- Comment #9 from Michael G. Hansen <[hidden email]> ---
Hi Veaceslav,

the disabling/enabling seems to work fine. The only one that could still be
disabled is "Expand selected nodes" if the nodes do not have subitems.

Best regards,

Michael

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=333387

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tags                        |Tags-Manager

--
You are receiving this mail because:
You are the assignee for the bug.