[digikam] [Bug 332665] New: Digikam should use Baloo for KDE 4.13

classic Classic list List threaded Threaded
69 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Vishesh Handa
https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #58 from Vishesh Handa <[hidden email]> ---
(In reply to Veaceslav Munteanu from comment #57)
> Gilles,  yes we do not use anything except KFileMetadata.
>
> A clean-up will follow next days...
>
> Indeed BalooTags need to remain, due to digiKam storing tags in hierarchical
> structures, while KFileMetadata is better with simple tags...

I'm not sure I understand. Could you please elaborate on why "BalooTags" needs
to remain.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Veaceslav Munteanu-2
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/c07b1e032e1afb65a5a12c5
                   |                            |e73a5d6d2f7cef716

--- Comment #59 from Veaceslav Munteanu <[hidden email]> ---
Git commit c07b1e032e1afb65a5a12c5e73a5d6d2f7cef716 by Veaceslav Munteanu.
Committed on 15/03/2015 at 12:38.
Pushed by munteanu into branch 'frameworks'.

M  +13   -16   CMakeLists.txt
M  +1    -1    app/CMakeLists.txt
M  +4    -4    app/main/digikamapp.cpp
M  +2    -2    app/utils/componentsinfo.h
M  +1    -1    app/utils/digikam_config.h.cmake.in
M  +3    -3    libs/database/item/imagescanner.cpp
M  +2    -2    libs/fileactionmanager/metadatahub.cpp
M  +6    -6    libs/settings/applicationsettings.cpp
M  +1    -1    utilities/CMakeLists.txt
M  +1    -5    utilities/baloo/CMakeLists.txt
M  +1    -122  utilities/baloo/baloowrap.cpp
M  +0    -18   utilities/baloo/baloowrap.h
M  +4    -4    utilities/setup/setupmetadata.cpp

http://commits.kde.org/digikam/c07b1e032e1afb65a5a12c5e73a5d6d2f7cef716

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Veaceslav Munteanu-2
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #60 from Veaceslav Munteanu <[hidden email]> ---
Vishesh, because we store only "TagName" in baloo and not the full path
"/parent/TagName". If we reread without appending a parent for it, it will
polute root tag.

So we assign a special "BalooTags" and who will need tags from now
KFileMetadata will find them there... Of course I will think about replacing
BalooTags with something else, or maybe to let user choose the prefix through
an option in the menu....

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Marko Käning
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

Marko Käning <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|http://commits.kde.org/digi |http://commits.kde.org/kde-
                   |kam/c07b1e032e1afb65a5a12c5 |build-metadata/08162a7e1a19
                   |e73a5d6d2f7cef716           |bb1e278bc29b8b4e46f8a252392
                   |                            |c
   Version Fixed In|5.0.0                       |c07b1e032e1afb65a5a12c5e73a
                   |                            |5d6d2f7cef716

--- Comment #61 from Marko Käning <[hidden email]> ---
Git commit 08162a7e1a19bb1e278bc29b8b4e46f8a252392c by Marko Käning.
Committed on 15/03/2015 at 13:38.
Pushed by kaning into branch 'master'.

Remove baloo dependency and use only KFileMetadata
FIXED-IN: c07b1e032e1afb65a5a12c5e73a5d6d2f7cef716
CCMAIL: [hidden email]

M  +0    -1    dependency-data-kf5-qt5

http://commits.kde.org/kde-build-metadata/08162a7e1a19bb1e278bc29b8b4e46f8a252392c

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Jeff Dooley
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

Jeff Dooley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #62 from Jeff Dooley <[hidden email]> ---
Sorry, I know this bug is now closed, but from a user perspective, I was hoping
the developers could clarify the interoperability with Dolphin (which is the
tool that I use, presumably with baloo integrated). Below are my assumptions
based on this bugzilla thread; please let me know whether or not I correctly
understood.

Digikam interoperability with Dolphin:
* Tags and ratings that are originally generated using Digikam, assuming the
user uses the option to save metadata stored in file, will now make use of
linux filesystem extended attributes. Consquently, the tags and ratings
originally generated in Digikam will be reflected in Dolphin's information
panel, and detailed view. Right?
* Will tags, ratings, and comments be allowed to be generated or modified from
Dolphin, and then reflected in Digikam?
* Will the list of available tags in Dolphin be synchronized with the list of
tags in Digikam?
* If a tag, rating, or comment is applied to a file using Dolphin, when Digikam
is started/loaded, will it check the file metadata/ extended attributes against
the database and prompt the user to confirm the changes? Corrollary: I can
imagine a use-case, or configuration option, where attributes generated outside
of Digikam are automatically dropped/ ignored by Digikam.

Thank you very much!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Veaceslav Munteanu-2
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #63 from Veaceslav Munteanu <[hidden email]> ---
Here are some answers to your questions, Jeff:
1. digiKam has options in settings menu to enable/disable read/write
2. If you change data from digikam and write is enabled, tags, ratings and
comments are automatically syncronized
3. If you have read enabled, data from baloo is read when any read metadata
operation is triggered
4. There is no way for digiKam to know if data was changed from outside. At
least at this moment.
5. If digikam has a tag structure like, aaa/bb/cc/dd, digikam store tags with
KFileMetadata as "dd" without it's full path. We can store the full path, but
tag itself will be unreadable in Dolphin. Also, because of read after write, we
could end up with a lot of duplicate tags in digiKam tag tree. Thats why we
store them under a special branch, which is now called "BalooTags" so it won't
pollute the whole tag tree.

There is a lot of shortcomings on current implementation, I know, but if
someone can come up with better design, please write your suggestions here :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Vishesh Handa
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #64 from Vishesh Handa <[hidden email]> ---
(In reply to Veaceslav Munteanu from comment #63)
> Here are some answers to your questions, Jeff:
> 1. digiKam has options in settings menu to enable/disable read/write
> 2. If you change data from digikam and write is enabled, tags, ratings and
> comments are automatically syncronized
> 3. If you have read enabled, data from baloo is read when any read metadata
> operation is triggered

"data from xattr is read ..."

> 4. There is no way for digiKam to know if data was changed from outside. At
> least at this moment.

file system monitoring? inotify provides signals on when a file's attributes
have been changed. Or rather do a full scan on startup or when the user
requests it and check the ctime of the files?

> 5. If digikam has a tag structure like, aaa/bb/cc/dd, digikam store tags
> with KFileMetadata as "dd" without it's full path. We can store the full
> path, but tag itself will be unreadable in Dolphin. Also, because of read
> after write, we could end up with a lot of duplicate tags in digiKam tag
> tree. Thats why we store them under a special branch, which is now called
> "BalooTags" so it won't pollute the whole tag tree.
>

I've said this before, I really really disapprove of using the name
"BalooTags". If you must use something, use "Digikam". At least the user will
then know which application these tags come from. Adding the name Baloo gives
them nothing of value and in-fact would confuse them even know since I keep
telling everyone that Baloo no longer handles tags.

Maybe I should just submit a patch.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

Veaceslav Munteanu-2
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #65 from Veaceslav Munteanu <[hidden email]> ---
Yes, you can commit a patch. The prefix is in the baloowrap.cpp. Set it for the
more appropiate value.

Also, when digiKam is running, it might see that through it's file scanner.
Scanner must be extended a little to see that changes. But this is only when
digiKam is running, complete syncronization is not possible without an
additional service.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 332665] digiKam should use Baloo interface

bugzilla_noreply
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=332665

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|c07b1e032e1afb65a5a12c5e73a |4.12.0
                   |5d6d2f7cef716               |

--
You are receiving this mail because:
You are the assignee for the bug.
1234