[digikam] [Bug 332665] New: Digikam should use Baloo for KDE 4.13

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #40 from Veaceslav Munteanu <[hidden email]> ---
@nucleo, I don't really understand how packaging with optional dependencies
work, but baloo support, even if it's only basic, must be good enough for
shipping now. This apply for KDE users.

Non-KDE users won't be happy with Baloo support enabled :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vishesh Handa]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #41 from Vishesh Handa <[hidden email]> ---
(In reply to Veaceslav Munteanu from comment #39)

> @Vishesh, in older Nepomuk Api, I was able to register in ResourceMonitor
> which type of resource I want to monitor.
>
> I used to register: comments, tags, ratings and images.
>
> what I really need from Baloo is signalFileMetadatachanged(Kurl file), so I
> can also trigger it in digiKam.
>
> At least, if filemodifyjob could register a folder path, that would be much
> better.
>
> If it's to expensive to fire a signal when Baloo register a change.... well
> there is nothing more I can do to integrate better with digiKam except basic
> read/write on request.

We do fire a change when the file metadata is modified. There is the
FileMonitor, but I think I understand what you mean - there is no way to
globally watch everything. You could just listen to the dbus code (look at the
implementation of the FileMonitor), but that's hackish. Either way, Baloo in
Qt4 is now frozen, so the API isn't going to change.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Konrad Renner]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #42 from Konrad Renner <[hidden email]> ---
will the kf5 port of digiKam make use of baloo and/or xattr?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #43 from Gilles Caulier <[hidden email]> ---
The code is unchanged in frameworks implementation. It's just ported to compile
under KF5.

Veaceslav, do you have some plan to improve Baloo interface ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vishesh Handa]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #44 from Vishesh Handa <[hidden email]> ---
(In reply to Gilles Caulier from comment #43)
> The code is unchanged in frameworks implementation. It's just ported to
> compile under KF5.
>
> Veaceslav, do you have some plan to improve Baloo interface ?
> Gilles

If he doesn't have plans, then please contact me. I can spend the required 30
minutes to port it.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #45 from Veaceslav Munteanu <[hidden email]> ---
Gilles, what exactly must be done?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #46 from Gilles Caulier <[hidden email]> ---
Veaceslav,

I don't know exactly. Ask to Vishesh (:=)))...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vishesh Handa]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #47 from Vishesh Handa <[hidden email]> ---
You need to get it to compile with the Qt5 version. Have a look at
KFileMetaData UserMetaData. It's a trivial change.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #48 from Veaceslav Munteanu <[hidden email]> ---
Ok, I will look into it.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #49 from Veaceslav Munteanu <[hidden email]> ---
Vishesh, how do I commit changes to file?

I am able to retrieve data with KFileMetadata Usermetadata, but when I set
them, changes are not reflected to files(Dolphin panel do not show anything...)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vishesh Handa]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #50 from Vishesh Handa <[hidden email]> ---
(In reply to Veaceslav Munteanu from comment #49)
> Vishesh, how do I commit changes to file?
>
> I am able to retrieve data with KFileMetadata Usermetadata, but when I set
> them, changes are not reflected to files(Dolphin panel do not show
> anything...)

Check if the xattr have been set via `getfattr -d`.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=332665

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #51 from Veaceslav Munteanu <[hidden email]> ---
Thank you, problem was somewhere else.

Everything is fixed, digiKam successfully ported to baloo.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332665

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332665

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digiKam should use Baloo    |digiKam should use Baloo
                   |for KDE 4.13                |interface

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vishesh Handa]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #52 from Vishesh Handa <[hidden email]> ---
(In reply to Veaceslav Munteanu from comment #51)
> Thank you, problem was somewhere else.
>
> Everything is fixed, digiKam successfully ported to baloo.

Could you possibly not call it the Baloo backend? You're mostly only using
KFileMetaData (a soon to be framework). I'm trying to make Baloo to just be a
file indexer.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vishesh Handa]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #53 from Vishesh Handa <[hidden email]> ---
(In reply to Veaceslav Munteanu from comment #51)
> Thank you, problem was somewhere else.
>
> Everything is fixed, digiKam successfully ported to baloo.

I just had a look at the code, you're appending "BalooTags/" to each tag. Do
you think the user should be aware of Baloo? In Plasma, we have tried our best
to remove technology names from the end user.

line 158: Q_FOREACH -> Maybe converting the list to a set in unnecasary?

The old Baloo code is still in comments. Perhaps we can remove that? It's
always there in git, if we want it.

The Baloo dependency can be dropped.

If you want to get the list of tags, you can use Baloo::TagListJob, however,
please remember that this will NOT give you the list of all tags. Only the tags
from the files that are indexed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #54 from Gilles Caulier <[hidden email]> ---
>The Baloo dependency can be dropped.

I don't understand why exactly ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vishesh Handa]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #55 from Vishesh Handa <[hidden email]> ---
(In reply to Gilles Caulier from comment #54)
> >The Baloo dependency can be dropped.
>
> I don't understand why exactly ?
>

Baloo in KF5 is just a file indexer. It goes through your file and creates an
index optimized for searching. It also indexes tags, ratings and comments.
These tags, ratings and comments are obtained from the extended attributes of
the file via KFileMetaData::UserMetadata. This is a os independent wrapper on
top of xattr.

Digikam is currently only using KFileMetaData. It is not using Baloo.
Therefore, the dependency can be dropped.

You only need to use Baloo is you want to perform some kind of queries on the
index.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #56 from Gilles Caulier <[hidden email]> ---
Veaceslav,

What do you think about to remove Baloo dependency and to let's only
KFileMetadata ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=332665

--- Comment #57 from Veaceslav Munteanu <[hidden email]> ---
Gilles,  yes we do not use anything except KFileMetadata.

A clean-up will follow next days...

Indeed BalooTags need to remain, due to digiKam storing tags in hierarchical
structures, while KFileMetadata is better with simple tags...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel