[digikam] [Bug 332663] New: Wrong location of help translations

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=332663

            Bug ID: 332663
           Summary: Wrong location of help translations
    Classification: Unclassified
           Product: digikam
           Version: 4.0.0-beta4
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

Some of files installed in wrong locations in digikam-4.0.0-beta4:

   /usr/share/doc/HTML/et/et/color-management.docbook
   /usr/share/doc/HTML/et/et/common
   /usr/share/doc/HTML/et/et/credits-annex.docbook
   /usr/share/doc/HTML/et/et/editor-color.docbook
   /usr/share/doc/HTML/et/et/editor-decorate.docbook
   /usr/share/doc/HTML/et/et/editor-enhance.docbook
   /usr/share/doc/HTML/et/et/editor-filters.docbook
   /usr/share/doc/HTML/et/et/editor-transform.docbook
   /usr/share/doc/HTML/et/et/file-formats.docbook
   /usr/share/doc/HTML/et/et/ie-menu.docbook
   /usr/share/doc/HTML/et/et/index.cache.bz2
   /usr/share/doc/HTML/et/et/index.docbook
   /usr/share/doc/HTML/et/et/menu-descriptions.docbook
   /usr/share/doc/HTML/et/et/photo-editing.docbook
   /usr/share/doc/HTML/et/et/sidebar.docbook
   /usr/share/doc/HTML/it/it/color-management.docbook
   /usr/share/doc/HTML/it/it/common
   /usr/share/doc/HTML/it/it/credits-annex.docbook
   /usr/share/doc/HTML/it/it/editor-color.docbook
   /usr/share/doc/HTML/it/it/editor-decorate.docbook
   /usr/share/doc/HTML/it/it/editor-enhance.docbook
   /usr/share/doc/HTML/it/it/editor-filters.docbook
   /usr/share/doc/HTML/it/it/editor-transform.docbook
   /usr/share/doc/HTML/it/it/file-formats.docbook
   /usr/share/doc/HTML/it/it/ie-menu.docbook
   /usr/share/doc/HTML/it/it/index.cache.bz2
   /usr/share/doc/HTML/it/it/index.docbook
   /usr/share/doc/HTML/it/it/menu-descriptions.docbook
   /usr/share/doc/HTML/it/it/photo-editing.docbook
   /usr/share/doc/HTML/it/it/sidebar.docbook
   /usr/share/doc/HTML/nl/nl/color-management.docbook
   /usr/share/doc/HTML/nl/nl/common
   /usr/share/doc/HTML/nl/nl/credits-annex.docbook
   /usr/share/doc/HTML/nl/nl/editor-color.docbook
   /usr/share/doc/HTML/nl/nl/editor-decorate.docbook
   /usr/share/doc/HTML/nl/nl/editor-enhance.docbook
   /usr/share/doc/HTML/nl/nl/editor-filters.docbook
   /usr/share/doc/HTML/nl/nl/editor-transform.docbook
   /usr/share/doc/HTML/nl/nl/file-formats.docbook
   /usr/share/doc/HTML/nl/nl/ie-menu.docbook
   /usr/share/doc/HTML/nl/nl/index.cache.bz2
   /usr/share/doc/HTML/nl/nl/index.docbook
   /usr/share/doc/HTML/nl/nl/menu-descriptions.docbook
   /usr/share/doc/HTML/nl/nl/photo-editing.docbook
   /usr/share/doc/HTML/nl/nl/sidebar.docbook
   /usr/share/doc/HTML/pt/pt/color-management.docbook
   /usr/share/doc/HTML/pt/pt/common
   /usr/share/doc/HTML/pt/pt/credits-annex.docbook
   /usr/share/doc/HTML/pt/pt/editor-color.docbook
   /usr/share/doc/HTML/pt/pt/editor-decorate.docbook
   /usr/share/doc/HTML/pt/pt/editor-enhance.docbook
   /usr/share/doc/HTML/pt/pt/editor-filters.docbook
   /usr/share/doc/HTML/pt/pt/editor-transform.docbook
   /usr/share/doc/HTML/pt/pt/file-formats.docbook
   /usr/share/doc/HTML/pt/pt/ie-menu.docbook
   /usr/share/doc/HTML/pt/pt/index.cache.bz2
   /usr/share/doc/HTML/pt/pt/index.docbook
   /usr/share/doc/HTML/pt/pt/menu-descriptions.docbook
   /usr/share/doc/HTML/pt/pt/photo-editing.docbook
   /usr/share/doc/HTML/pt/pt/sidebar.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/color-management.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/common
   /usr/share/doc/HTML/pt_BR/pt_BR/credits-annex.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-color.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-decorate.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-enhance.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-filters.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/editor-transform.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/file-formats.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/ie-menu.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/index.cache.bz2
   /usr/share/doc/HTML/pt_BR/pt_BR/index.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/menu-descriptions.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/photo-editing.docbook
   /usr/share/doc/HTML/pt_BR/pt_BR/sidebar.docbook
   /usr/share/doc/HTML/sv/sv/color-management.docbook
   /usr/share/doc/HTML/sv/sv/common
   /usr/share/doc/HTML/sv/sv/credits-annex.docbook
   /usr/share/doc/HTML/sv/sv/editor-color.docbook
   /usr/share/doc/HTML/sv/sv/editor-decorate.docbook
   /usr/share/doc/HTML/sv/sv/editor-enhance.docbook
   /usr/share/doc/HTML/sv/sv/editor-filters.docbook
   /usr/share/doc/HTML/sv/sv/editor-transform.docbook
   /usr/share/doc/HTML/sv/sv/file-formats.docbook
   /usr/share/doc/HTML/sv/sv/ie-menu.docbook
   /usr/share/doc/HTML/sv/sv/index.cache.bz2
   /usr/share/doc/HTML/sv/sv/index.docbook
   /usr/share/doc/HTML/sv/sv/menu-descriptions.docbook
   /usr/share/doc/HTML/sv/sv/photo-editing.docbook
   /usr/share/doc/HTML/sv/sv/sidebar.docbook
   /usr/share/doc/HTML/uk/uk/color-management.docbook
   /usr/share/doc/HTML/uk/uk/common
   /usr/share/doc/HTML/uk/uk/credits-annex.docbook
   /usr/share/doc/HTML/uk/uk/editor-color.docbook
   /usr/share/doc/HTML/uk/uk/editor-decorate.docbook
   /usr/share/doc/HTML/uk/uk/editor-enhance.docbook
   /usr/share/doc/HTML/uk/uk/editor-filters.docbook
   /usr/share/doc/HTML/uk/uk/editor-transform.docbook
   /usr/share/doc/HTML/uk/uk/file-formats.docbook
   /usr/share/doc/HTML/uk/uk/ie-menu.docbook
   /usr/share/doc/HTML/uk/uk/index.cache.bz2
   /usr/share/doc/HTML/uk/uk/index.docbook
   /usr/share/doc/HTML/uk/uk/menu-descriptions.docbook
   /usr/share/doc/HTML/uk/uk/photo-editing.docbook
   /usr/share/doc/HTML/uk/uk/sidebar.docbook

Reproducible: Always



Expected Results:  
Right location should be such as
/usr/share/doc/HTML/en/digikam/color-management.docbook

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=332663

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #1 from Kevin Kofler <[hidden email]> ---
doc-translated/*/CMakeLists.txt has:
kde4_create_handbook( index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/et/
)
That should be:
kde4_create_handbook( index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/et/
SUBDIR digikam )
(of course, replace "et" by the respective language.)

(SUBDIR is required whenever the directory name in the tarball does not match
the target directory name, i.e. typically for translated documentation.)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=332663

--- Comment #2 from nucleo <[hidden email]> ---
Created attachment 85779
  --> https://bugs.kde.org/attachment.cgi?id=85779&action=edit
location fix

Patch made from Comment 1.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=332663

--- Comment #3 from nucleo <[hidden email]> ---
doc-translated subdir is new in beta4 tarball, it wasn't in beta3.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332663

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]
            Summary|Wrong location of help      |Wrong location of help
                   |translations                |translations [patch]

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Nicolas,

Do you see this entry ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=332663

Pino Toscano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85779|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=332663

Pino Toscano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Wrong location of help      |Wrong location of
                   |translations [patch]        |documentation translations

--- Comment #5 from Pino Toscano <[hidden email]> ---
(In reply to comment #2)
> Created attachment 85779 [details]
> location fix
>
> Patch made from Comment 1.

While the approach is correct, the patch is wrong since those files are
autogenerated by a script in the digikam-software-compilation repository
(project/release/fetch_l10n.rb).
I am going to fix it properly now.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=332663

Pino Toscano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/scra
                   |                            |tch/mwiesweg/digikam-sc/7b1
                   |                            |5383080188c8ceff1c4af0cbbb2
                   |                            |f046578b73

--- Comment #6 from Pino Toscano <[hidden email]> ---
Git commit 7b15383080188c8ceff1c4af0cbbb2f046578b73 by Pino Toscano.
Committed on 30/03/2014 at 19:31.
Pushed by pino into branch 'master'.

fetch_l10n.rb: fix creation of CMakeLists.txt for doc translations

M  +1    -1    project/release/fetch_l10n.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/7b15383080188c8ceff1c4af0cbbb2f046578b73

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=332663

--- Comment #7 from Kevin Kofler <[hidden email]> ---
Well, nucleo's patch fixed your release tarball. :-) But thanks for the fix to
the script that generates your release files. :-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=332663

Pino Toscano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |---
     Ever confirmed|1                           |0

--- Comment #8 from Pino Toscano <[hidden email]> ---
(In reply to comment #7)
> Well, nucleo's patch fixed your release tarball. :-)

Yes, I know what the patch does.

> But thanks for the fix to the script that generates your release files. :-)

Please drop the "your", since I'm not a digikam developer.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=332663

Pino Toscano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332663

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicolas Lécureuil]

https://bugs.kde.org/show_bug.cgi?id=332663

--- Comment #9 from Nicolas L. <[hidden email]> ---
thanks, we will have this fixed for rc then, or do i need to respin the tarball
? ( like a beta4.1 tarball )

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332663

--- Comment #10 from Gilles Caulier <[hidden email]> ---
@Nivolas,

No need, 4.0.0-RC is planed in 2 weeks.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=332663

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0-beta4                 |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=332663

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Documentation

--
You are receiving this mail because:
You are the assignee for the bug.