[digikam] [Bug 331194] New: Trailing white spaces in camera model name

[Romain Henriet]

https://bugs.kde.org/show_bug.cgi?id=331194

            Bug ID: 331194
           Summary: Trailing white spaces in camera model name
    Classification: Unclassified
           Product: digikam
           Version: 3.5.0
          Platform: openSUSE RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Database
          Assignee: [hidden email]
          Reporter: [hidden email]

I tried to use Focal analysing script and it generated 2 pages for my Pentax
K-x and 2 pages for my Samsung NX1000.
After searching why, I discovered that some photos have camera model "K-x" and
some others have model "K-x   "  (with trailing spaces). The same for "NX1000"
and "NX1000  ".
Maybe Digikam should remove trailing and leading spaces before registering
fields in database.

Reproducible: Always

Steps to Reproduce:
1. Open "advanced search" dialog
2. Reset search options
3. In "Model" field, type "K-x" and press the "Try" button
4. Result contains about 1000 photos
5. Now, type "K-x "   (one trailing space) in "Model" field and press the "Try"
button again
6. Result contains about 150 photos

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331194

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Trailing white spaces in    |SCAN : prevent trailing
                   |camera model name           |white spaces in camera
                   |                            |model/maker names
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331194

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Can you provide a some sample images to test. Please share files through web
service, not KDE bugzilla which is limited about file size attachments.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331194

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Maik,

Here i think patch will be simple to register formatted camera info in
database.

I already do the job for Image Properties and Tooltips view, but it's only to
show info in GUI, not to register data in DB. Look here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/imageproperties/imagepropertiestab.cpp#L835

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Romain Henriet]

https://bugs.kde.org/show_bug.cgi?id=331194

--- Comment #3 from Romain Henriet <[hidden email]> ---
Hello,
here are two photos : http://dl.free.fr/llYqGUTRT
"111215_Chat_1.jpg" is found with "K-x" and "K-x ".
"140907_Fougères_17.jpg" is only found with "K-x".

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=331194

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Maik Qualmann <[hidden email]> ---
Created attachment 92689
  --> https://bugs.kde.org/attachment.cgi?id=92689&action=edit
MakeModelTrimmed.patch

This patch removes spaces at the beginning and end of camera make and model,
when reading the metadata from the image into the database.

Note: A rescan of the metadata with the maintenance tool is obliges to update
the database.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=331194

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|SCAN : prevent trailing     |SCAN : prevent trailing
                   |white spaces in camera      |white spaces in camera
                   |model/maker names           |model/maker names [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331194

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Patch sound fine for me...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=331194

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/af054ea68f3afc3a4f265e7
                   |                            |a825a4885781d563e
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.11.0
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Git commit af054ea68f3afc3a4f265e7a825a4885781d563e by Maik Qualmann.
Committed on 18/05/2015 at 19:18.
Pushed by mqualmann into branch 'master'.

apply patch #92689 to remove trailing white spaces in camera make and model
FIXED-IN: 4.11.0

M  +2    -1    NEWS
M  +8    -2    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/af054ea68f3afc3a4f265e7a825a4885781d563e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331194

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Git commit 0fe7437395ba1b55814c47889c2371b3f49ca88e by Gilles Caulier.
Committed on 18/05/2015 at 20:53.
Pushed by cgilles into branch 'frameworks'.

backport commit #af054ea68f3afc3a4f265e7a825a4885781d563e from git/master to
framework branch

M  +8    -2    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/0fe7437395ba1b55814c47889c2371b3f49ca88e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=331194

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Database                    |Database-Scan

--
You are receiving this mail because:
You are the assignee for the bug.