[digikam] [Bug 330063] New: digikam, when deleting photo no confirmation, icon stays present

[Philippe ROUBACH]

https://bugs.kde.org/show_bug.cgi?id=330063

            Bug ID: 330063
           Summary: digikam, when deleting photo no confirmation, icon
                    stays present
    Classification: Unclassified
           Product: digikam
           Version: 3.5.0
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Import
          Assignee: [hidden email]
          Reporter: [hidden email]

in the import window
i select a photo
then
i choose "delete selection"
then
there is no confirmation dialog and the icon of photo stays displayed

with dolphin i can check that the photo is well deleted
with dolphin when deleting a file there is a confirmation dialog



Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Philippe ROUBACH]

https://bugs.kde.org/show_bug.cgi?id=330063

--- Comment #1 from Philippe ROUBACH <[hidden email]> ---
opensuse 13.1 x86_64 , digikam 3.5

ptp , mtp protocol are used

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Philippe ROUBACH]

https://bugs.kde.org/show_bug.cgi?id=330063

Philippe ROUBACH <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|unspecified                 |openSUSE RPMs

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=330063

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Can you try again using last 4.0.0-beta2 released 2 days ago ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Shourya Singh Gupta]

https://bugs.kde.org/show_bug.cgi?id=330063

--- Comment #3 from Shourya Singh Gupta <[hidden email]> ---
Created attachment 84747
  --> https://bugs.kde.org/attachment.cgi?id=84747&action=edit
Now a KMessageBox pops up to confirm whether a user wants to delete or not

I used KMessageBox .If the User clicks Ok , then only the deletion will take
place else not.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=330063

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Teemu Rytilahti <[hidden email]> ---
Some points:
- The check should be outside CameraController, as that is supposedly running
on a separate thread. And at the moment deleteFile() would be called multiple
times in a row (see deleteItems importui.cpp, which in my opinion would be the
correct place for the check.
- You should use use a method, which makes it possible to tick displaying the
dialog off (see dontAskAgainName in constructors)
- Perhaps warningYesNo instead of question? Someone knows better though.
- i18nify the strings (see
http://techbase.kde.org/Development/Tutorials/Localization/i18n), in my opinion
it should display how many files are to be deleted there, see i18np and with
context, i18ncp.
- When checking for the return value, use the enumerator. This case it'd be
KMessageBox::Yes.
- Check the indendation of the code.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Shourya Singh Gupta]

https://bugs.kde.org/show_bug.cgi?id=330063

--- Comment #5 from Shourya Singh Gupta <[hidden email]> ---
Created attachment 84777
  --> https://bugs.kde.org/attachment.cgi?id=84777&action=edit
Now a KMessageBox::warningYesNo pops up to confirm whether a user wants to
delete or not....donotaskagain also included

I used KMessageBox::warningYesNo .If the User clicks Ok , then only the
deletion will take place else not.If user checks donotaskagain then this dialog
does not appear from the next time.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=330063

--- Comment #6 from Teemu Rytilahti <[hidden email]> ---
I'm not sure if that patch would work, but I took a deeper look into the
relevant code and looks like there's already part of the confirmation box
available with all relevant things. See ImportUI::deleteItems() and scroll down
to see warnMsg variable and corresponding warningContinueCancelList call.

No idea why that is commented out, but that would be a start. Regarding to your
patch, while coding, please note the coding-style of nearby code. That is in
this case spaces after commas in parameter listing.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Shourya Singh Gupta]

https://bugs.kde.org/show_bug.cgi?id=330063

--- Comment #7 from Shourya Singh Gupta <[hidden email]> ---
Created attachment 84784
  --> https://bugs.kde.org/attachment.cgi?id=84784&action=edit
the .cpp file

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Shourya Singh Gupta]

https://bugs.kde.org/show_bug.cgi?id=330063

Shourya Singh Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84747|0                           |1
        is obsolete|                            |
  Attachment #84777|0                           |1
        is obsolete|                            |
  Attachment #84784|0                           |1
        is obsolete|                            |

--- Comment #8 from Shourya Singh Gupta <[hidden email]> ---
Created attachment 84802
  --> https://bugs.kde.org/attachment.cgi?id=84802&action=edit
Changes done in importui.cpp and importui.h so that a dialog appears to confirm
deletion

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=330063

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digikam, when deleting      |digiKam, when deleting
                   |photo no confirmation, icon |photo no confirmation
                   |stays present               |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=330063

--- Comment #9 from Gilles Caulier <[hidden email]> ---
About original problem :

>there is no confirmation dialog and the icon of photo stays displayed

==> "photo stays displayed" is already fixed in 4.0.0

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=330063

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Shourya,

In your patch your reproduce a part of code from CameraMessageBox... Why to
dupplicate it instead to fix existing one ???

The original problem of this dialog, if to handle properly camera item
thumbnails to show in dialog. User want to be sure to delete right items. With
your solution no item thumbs is show in dialog.

Also code duplicated and bloat ImportUi class for nothing... Your patch is
definitively the wrong way...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=330063

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/4639e6f0b04e73a30e1ed59
                   |                            |3e453cb5820604af7

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Git commit 4639e6f0b04e73a30e1ed593e453cb5820604af7 by Gilles Caulier.
Committed on 26/05/2014 at 12:51.
Pushed by cgilles into branch 'master'.

Restore CameraThumbsCtrl class to manage and cache thumbnails from camera
(concept from 2.x serie, dropped with 3.x model view port)
It cache Camera thumb in max size and pass to thumb model pixmap which need to
ne resized. No need to reload thumb from camera if thumb size is changed.
This take a lot of time.
This controler is also used in CameMessageBox to confirm which images to remove
from camera. This message box is also restored (fdropped in same condition with
3.x serie)
Note: This controller have been moved as well to ImportThumnailModel class
which have been a wrong idea. This implementation must be separated and shared
with class tht needs cached thumbnails.
ImportThumnailModel use this controller directly which simplify a lots
implementation.
CCMAIL: [hidden email]
CCMAIL: [hidden email]

M  +1    -0    digikam/views/mapwidgetview.cpp
M  +2    -1    utilities/importui/CMakeLists.txt
M  +4    -0    utilities/importui/items/importdelegate.cpp
M  +37   -33   utilities/importui/main/importui.cpp
M  +5    -2    utilities/importui/main/importui_p.h
M  +2    -2    utilities/importui/models/importfiltermodel.cpp
M  +2    -2    utilities/importui/models/importfiltermodel.h
M  +14   -5    utilities/importui/models/importimagemodel.cpp
M  +2    -2    utilities/importui/models/importimagemodel.h
M  +25   -273  utilities/importui/models/importthumbnailmodel.cpp
M  +5    -31   utilities/importui/models/importthumbnailmodel.h
M  +8    -5    utilities/importui/views/importstackedview.cpp

http://commits.kde.org/digikam/4639e6f0b04e73a30e1ed593e453cb5820604af7

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=330063

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel