[digikam] [Bug 329433] New: Manual adding of faces made easier

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] New: Manual adding of faces made easier

Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

            Bug ID: 329433
           Summary: Manual adding of faces made easier
    Classification: Unclassified
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Face Management
          Assignee: [hidden email]
          Reporter: [hidden email]

Created attachment 84352
  --> https://bugs.kde.org/attachment.cgi?id=84352&action=edit
Patch implementing the feature

I always add Face Tags to my images. It's a great feature.
However great the Face Detection mechanism is, it's not yet perfect, so I need
to do a lot of manual adding of Face Tags. The workflow in Digikam today is a
bit awkward today. I need to click the "Add a Face Tag" button for every Face
Tag I need to add in an image. This is quite unergonomic, and tiresome.

The patch I provided, enables a user to add a Face Tag to an image by just
Ctrl+left clicking on the image where the Face Tag should be. This facilitates
the process of adding many Face Tags.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=329433

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|unspecified                 |4.0.0-beta1
            Summary|Manual adding of faces made |Manual adding of faces made
                   |easier                      |easier [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Marcel Wiesweg
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
Any ideas how to make this feature discoverable?
Otherwise it seems fine for me.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Gilles Caulier-4
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

--- Comment #2 from Gilles Caulier <[hidden email]> ---

Why not to open this shortcut to be customizable in KDE application config
dialog ?

Tips dialog at startup is also a good way to promote this feature.

We have also a text file which group all know keyboard shortcut where we can
register it :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/project/KEYSHORTCUTS

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Kristian Karl
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

--- Comment #3 from Kristian Karl <[hidden email]> ---
I think that a tool tip when hovering over the "Add a Face Tag" button could
also be helpful.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Gilles Caulier-4
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Kristian,

Can you update your patch using current code from git/master (next digiKam
4.3.0)

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Kristian Karl
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

Kristian Karl <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84352|0                           |1
        is obsolete|                            |

--- Comment #5 from Kristian Karl <[hidden email]> ---
Created attachment 88405
  --> https://bugs.kde.org/attachment.cgi?id=88405&action=edit
Update for latest core on master: 42754c4452bda70707d16134e20a277441550ae0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Gilles Caulier-4
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0-beta1                 |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Gilles Caulier-4
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Maik,

This is another candidate patch to include to 4.9.0, i think...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Kristian Karl
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

Kristian Karl <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88405|0                           |1
        is obsolete|                            |

--- Comment #7 from Kristian Karl <[hidden email]> ---
Created attachment 91855
  --> https://bugs.kde.org/attachment.cgi?id=91855&action=edit
Updated patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Maik Qualmann
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/c35027e5069e870888c8193
                   |                            |30b0c55bf42c76c7e
   Version Fixed In|                            |4.9.0
         Resolution|---                         |FIXED

--- Comment #8 from Maik Qualmann <[hidden email]> ---
Git commit c35027e5069e870888c819330b0c55bf42c76c7e by Maik Qualmann.
Committed on 02/04/2015 at 16:38.
Pushed by mqualmann into branch 'master'.

apply patch #91855 from Kristian Karl to manually adding a face with the Ctrl +
left mouse button
FIXED-IN: 4.9.0

M  +2    -1    NEWS
M  +10   -0    app/views/imagepreviewview.cpp
M  +1    -0    app/views/imagepreviewview.h

http://commits.kde.org/digikam/c35027e5069e870888c819330b0c55bf42c76c7e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Gilles Caulier-4
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Git commit 77991dd845f18e7cd157c78afea47e7481533777 by Gilles Caulier.
Committed on 02/04/2015 at 20:51.
Pushed by cgilles into branch 'master'.

libkface is optional. Only compile code relevant of facegroup if dependency is
resolved.

M  +3    -2    app/views/imagepreviewview.cpp

http://commits.kde.org/digikam/77991dd845f18e7cd157c78afea47e7481533777

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 329433] Manual adding of faces made easier [patch]

Gilles Caulier-4
In reply to this post by Kristian Karl
https://bugs.kde.org/show_bug.cgi?id=329433

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Git commit 59a263e2cb247a0c3e0afdfd02ddff26a850760f by Gilles Caulier.
Committed on 27/03/2015 at 13:42.
Pushed by cgilles into branch 'frameworks'.

backport commits #c35027e5069e870888c819330b0c55bf42c76c7e and
#77991dd845f18e7cd157c78afea47e7481533777 from git/master to frameworks branch

M  +11   -0    app/views/imagepreviewview.cpp
M  +1    -0    app/views/imagepreviewview.h

http://commits.kde.org/digikam/59a263e2cb247a0c3e0afdfd02ddff26a850760f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel