[digikam] [Bug 326953] New: Add loadEmbeddedPreview(QByteArray, QBuffer)

https://bugs.kde.org/show_bug.cgi?id=326953

            Bug ID: 326953
           Summary: Add loadEmbeddedPreview(QByteArray, QBuffer)
    Classification: Unclassified
           Product: digikam
           Version: unspecified
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkdcraw
          Assignee: [hidden email]
          Reporter: [hidden email]

During implementation of the RAW preview support in gwenview, a need for
loadEmbeddedPreview able of loading the RAW data from QBuffer (not file) arose.
Temporarily, I've implemented the function within gwenview. For the sake of
better maintainability of the code it would be nice to have this feature
implemented directly in libkdcraw. Proposed patch is attached.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=326953

--- Comment #1 from Martin Kyral <[hidden email]> ---
Created attachment 83251
  --> https://bugs.kde.org/attachment.cgi?id=83251&action=edit
proposed patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326953

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
From your patch you force libkdcraw client application to compile with libraw
througn libkdcraw/kdcraw.h header :

+//LibRaw includes
+
+#include <libraw/libraw.h>

This is weird. client application don't need this dependency.
To fix it, move this method :

 private:
+    // implements loadEmbeddedPreview once the LibRaw buffer is opened
+    static bool loadEmbeddedPreview(QByteArray&, LibRaw&);

... to kdcraw_p.h/.cpp and remove libraw header include from shared libkdcraw
header.

If you update this patch, it will be can included to git/master for next KDE
4.12. Do you have a git developer account ?

Best

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=326953

Martin Kyral <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add                         |Add loadEmbeddedPreview
                   |loadEmbeddedPreview(QByteAr |reading from QBuffer
                   |ray, QBuffer)               |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=326953

Martin Kyral <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83251|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Kyral <[hidden email]> ---
Created attachment 83264
  --> https://bugs.kde.org/attachment.cgi?id=83264&action=edit
patch v2

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=326953

--- Comment #4 from Martin Kyral <[hidden email]> ---
Thanks for the brief reply. I modified the patch according to your comment.

No, I don't have git developer account.

Rgds,
Martin

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326953

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |3.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326953

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |dcraw/84e6c3d3d29d580d9e94d
                   |                            |fb68cbb294d43885381

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Git commit 84e6c3d3d29d580d9e94dfb68cbb294d43885381 by Gilles Caulier.
Committed on 02/11/2013 at 13:33.
Pushed by cgilles into branch 'master'.

Apply patch #83264 from Martin Kyral to load embedded preview from a QBuffer
RAW data container
FIXED-IN: 4.0.0

M  +30   -29   libkdcraw/kdcraw.cpp
M  +6    -0    libkdcraw/kdcraw.h
M  +52   -3    libkdcraw/kdcraw_p.cpp
M  +6    -2    libkdcraw/kdcraw_p.h

http://commits.kde.org/libkdcraw/84e6c3d3d29d580d9e94dfb68cbb294d43885381

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel