[digikam] [Bug 326718] New: Clear text button on file rename does nothing

[rjwgnr27]

https://bugs.kde.org/show_bug.cgi?id=326718

            Bug ID: 326718
           Summary: Clear text button on file rename does nothing
    Classification: Unclassified
           Product: digikam
           Version: 3.5.0
          Platform: Fedora RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Advanced Rename
          Assignee: [hidden email]
          Reporter: [hidden email]

When entering rename pattern in the file rename dialog, pressing the clear text
on the input field does nothing.

Reproducible: Always

Steps to Reproduce:
1. Select an image or images
2. Select "Image -> Rename"
3. Enter text in the "rename pattern" input.
4. Try to clear the text by pressing the small 'x' on right of input field.
Actual Results:  
Nothing happens

Expected Results:  
The input field should be cleared.


Same behavior in the rename file option of the batch manager.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.5.0                       |4.0.0-beta1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.0.0-beta1                 |4.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=326718

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--- Comment #1 from Teemu Rytilahti <[hidden email]> ---
Hello there,

Just took a quick peek at the code.
The widget used is ProxyLineEdit defined in
libs/widgets/common/comboboxutilities.cpp
This widget overrides the input events of KLineEdit for some reason, found just
this comment there:
/**
 * We just re-implement all relevant QWidget event handlers and call
 * the QWidget implementation, not the KLineEdit one.
 */

As one can see from here, the signal is being emited in KLineEdit
implementation, and is not therefore ever emited in this case:
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/klineedit_8cpp_source.html#l01144

Marcel probably has insight why it was done so, added to CC.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Koushik S]

https://bugs.kde.org/show_bug.cgi?id=326718

Koushik S <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Koushik S <[hidden email]> ---
(In reply to Teemu Rytilahti from comment #1)

> Hello there,
>
> Just took a quick peek at the code.
> The widget used is ProxyLineEdit defined in
> libs/widgets/common/comboboxutilities.cpp
> This widget overrides the input events of KLineEdit for some reason, found
> just this comment there:
> /**
>  * We just re-implement all relevant QWidget event handlers and call
>  * the QWidget implementation, not the KLineEdit one.
>  */
>
> As one can see from here, the signal is being emited in KLineEdit
> implementation, and is not therefore ever emited in this case:
> http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/klineedit_8cpp_source.
> html#l01144
>
> Marcel probably has insight why it was done so, added to CC.

Hi,

I just changed the mousePressEvent and mouseReleaseEvent to KLineEdit's
implementation and it seems to work, although I'm not sure why it was avoided
in the first place. So i'll hold onto making the patch until it's confirmed
that there's no problems involved.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

--- Comment #3 from Gilles Caulier <[hidden email]> ---
I don't know exactly why QWidget is used instead KLineEdit to call parent
methods in ProxyLineEdit.

Marcel, any feedback about this topic please...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

--- Comment #4 from Gilles Caulier <[hidden email]> ---

Anyway, look where is used comboboxutilities.h :

- Advanced Searches dialog :
ratingsearchutilities.h
choisesearchutilities.h
searchutilities.h

- Rename tool :
advancedrenameinput.h

- Album combobox selector used in many place in digiKam :
albumselectcombobox.h

So, if you patch comboboxutilities.h about calling KLineEdit instead QWidget,
you need to check if regression are introduced in all ProxyLineEdit children
classes.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Koushik S]

https://bugs.kde.org/show_bug.cgi?id=326718

--- Comment #5 from Koushik S <[hidden email]> ---

> So, if you patch comboboxutilities.h about calling KLineEdit instead
> QWidget, you need to check if regression are introduced in all ProxyLineEdit
> children classes.
>
> Gilles Caulier

I tested it out on a couple of parameters, and I haven't experienced any
problems so far. It seems to work on parameters which are not text entries as
well.

I don't know what the album combobox selector is in the application, sorry. How
can I use it? I checked it out on the rest of the dialogues, and it seems to
work fine.

I think the only anamoly that I found was in the advanced rename input-- when
you clear the text, and enter a new name, the clear button gets disabled. I
don't know if that's the intended behaviour or if it needs to be changed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Look in Maintenance tool, there are combobox to select albums or tags to
process on top of dialog.

It's also available in left sidebar, to Fuzzy Seach view, on the bottom.

Look also Scan for Face dialog, on the bottom.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Koushik S]

https://bugs.kde.org/show_bug.cgi?id=326718

--- Comment #7 from Koushik S <[hidden email]> ---
Got it. I tested it on all the options you've mentioned, and it seems to work
fine. Clearing it sets it to 'Any album' which, I think, is the expected
option.

Should I send in the patch?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Attach the patch this this file.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Koushik S]

https://bugs.kde.org/show_bug.cgi?id=326718

--- Comment #9 from Koushik S <[hidden email]> ---
Created attachment 89366
  --> https://bugs.kde.org/attachment.cgi?id=89366&action=edit
Fix Clear text button working

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Clear text button on file   |Clear text button on file
                   |rename does nothing         |rename does nothing [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=326718

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.5.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/64cdd14274352575e26b47a
                   |                            |5baacb59f4ea105de
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Git commit 64cdd14274352575e26b47a5baacb59f4ea105de by Gilles Caulier.
Committed on 29/10/2014 at 22:14.
Pushed by cgilles into branch 'master'.

Apply patch #89366 to make clear text button usable.
FIXED-IN: 4.5.0

M  +2    -1    NEWS
M  +11   -9    libs/widgets/common/comboboxutilities.cpp

http://commits.kde.org/digikam/64cdd14274352575e26b47a5baacb59f4ea105de

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel