[digikam] [Bug 324323] New: Hang on opening Geolocation pane on photos with XMP GPS tags.

[alexander.s.m]

https://bugs.kde.org/show_bug.cgi?id=324323

            Bug ID: 324323
           Summary: Hang on opening Geolocation pane on photos with XMP
                    GPS tags.
    Classification: Unclassified
           Product: digikam
           Version: 3.3.0
          Platform: Archlinux Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: Geolocation
          Assignee: [hidden email]
          Reporter: [hidden email]

I have noticed, that several photos have XMP GPS tags. When I import this
photos to digiKam album, digiKam stores invalid coordinates in DB

MariaDB [digikam4]> SELECT latitude,latitudeNumber,longitude,longitudeNumber
FROM ImagePositions WHERE latitudeNumber>90;
+------------------+--------------------+-----------+--------------------+
| latitude         | latitudeNumber     | longitude | longitudeNumber    |
+------------------+--------------------+-----------+--------------------+
| NULL             |  817.1666666666666 | NULL      |  885.6166666666667 |
| NULL             |  773.9166666666666 | NULL      |  988.2666666666667 |
| 266,38.00000000N |  266.6333333333333 | NULL      | 1455.2833333333333 |
| 267,16.00000000N | 267.26666666666665 | NULL      | 1459.9333333333334 |
| NULL             |  785.0666666666667 | NULL      |  981.0666666666667 |
+------------------+--------------------+-----------+--------------------+

If  I remove XMP GPS coordinates from these photos (exiv2 -v -M 'del
Xmp.exif.GPSLongitude' -M 'del Xmp.exif.GPSLatitude') digiKam read correct GPS
info from EXIF tags.

Reproducible: Always

Actual Results:  
Photos with XMP GPS tags are not visible in "Map" view and "Map Search"
sidepane. digiKam hangs if I try to open Geolocation sidepane for such picture.

Expected Results:  
1. digiKam should validate coordinates before inserting into DB;
2. digiKam should try to read EXIF GPS coordinates if reading XMP GPS
coordinates failed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[alexander.s.m]

https://bugs.kde.org/show_bug.cgi?id=324323

--- Comment #1 from Alexander Meshcheryakov <[hidden email]> ---
Created attachment 82067
  --> https://bugs.kde.org/attachment.cgi?id=82067&action=edit
Example picture with XMP GPS tags

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[alexander.s.m]

https://bugs.kde.org/show_bug.cgi?id=324323

Alexander Meshcheryakov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Alexander Meshcheryakov <[hidden email]> ---
To prevent accidental hangs of digiKam I've added following trigger to my MySQL
DB

CREATE TRIGGER `ImagePositions_BINS` BEFORE INSERT ON ImagePositions FOR EACH
ROW
-- Edit trigger body code below this line. Do not edit lines above this one
BEGIN
    DECLARE msg varchar(255);
    IF (NEW.latitudeNumber>90 OR NEW.latitudeNumber<-90) THEN
        SET msg = concat('Latitude out of bounds (', cast(NEW.latitudeNumber AS
CHAR), ')');
        SIGNAL sqlstate '45000' SET message_text = msg;
    END IF;
    IF (NEW.longitudeNumber>180 OR NEW.longitudeNumber<-180) THEN
        SET msg = concat('Longitude out of bounds (', cast(NEW.longitudeNumber
AS CHAR), ')');
        SIGNAL sqlstate '45000' SET message_text = msg;
    END IF;
END

And similar trigger for BEFORE UPDATE.

Unfortunately, MariaDB does not support CHECK CONSTRAINT unlike SQLite.

I suppose checks for valid coords should be added to standart DB schema.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=324323

--- Comment #3 from Gilles Caulier <[hidden email]> ---
digiKam 3.5.0 is out.

Can you give a fresh feedback about your report ? Crash still reproducible ?

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[alexander.s.m]

https://bugs.kde.org/show_bug.cgi?id=324323

--- Comment #4 from Alexander Meshcheryakov <[hidden email]> ---
I can still reproduce this bug with digiKam 3.5.0 and sample picture that I
have provided before ("Example picture with XMP GPS tags").

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=324323

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|3.3.0                       |3.5.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=324323

--- Comment #5 from Gilles Caulier <[hidden email]> ---
digiKam 4.0.0 is out :

http://www.digikam.org/node/713

Please check if this entry still valid with this new version.

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=324323

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.3.0

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Following comment #4, i close this file now...
Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel