[digikam] [Bug 323507] New: digitaglinktree - Can't find version 1.8.2 in repo & usage with mysql instead of sqlite

[Harald.Heigl1000+kde]

https://bugs.kde.org/show_bug.cgi?id=323507

            Bug ID: 323507
           Summary: digitaglinktree - Can't find version 1.8.2 in repo &
                    usage with mysql instead of sqlite
    Classification: Unclassified
           Product: digikam
           Version: unspecified
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Export
          Assignee: [hidden email]
          Reporter: [hidden email]

2 questions:
In this bug list I have found 2 bugs/wishes containing versions for
digitaglinktree (1.8.1 and 1.8.2), but I only find a relatively old version in
the git-repo. Is there another official repo for digitaglinktree?
- https://bugs.kde.org/show_bug.cgi?id=293297
- https://bugs.kde.org/show_bug.cgi?id=293832

The second question is more or less a feature request: I'm using mysql for
convencience (accessing from more than one computer), I'd like to run
digitaglinktree on my NAS with mysql-db. Has anyone adapted or thought about
adapting this script to mysql?

Thanks,
Harald

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Harald.Heigl1000+kde]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #1 from [hidden email] ---
Created attachment 82956
  --> https://bugs.kde.org/attachment.cgi?id=82956&action=edit
digitaglinktree for use with sqlite and mysql

Had some time to edit the script ...
The only disadvantage is: it doesn't use the lightweigth sqlite3 anymore, but
the DBI-Perl-System for bot database-types.

It now works with SQLite AND Mysql-Databses (added some options therfore like
type, user and password).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Please, provide a patch against current implementation from git/master instead
a full script file. Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Harald.Heigl1000+kde]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #3 from [hidden email] ---
Thanks for your comment, I just wanted to change the script and not download
the whole git-repository. But for now I did it, the only thing is ...

Here in this bugsystem there seem to be some newer changes (1.8-1.8.2 - also
see the links in my first comment), master only contains a relatively old
version 1.7.0 (from 2008).

Should I patch the 1.7.0 (I could do this, I just changed some lines here and
there ...), or is there another branch with the newer version?

regards,
Harald

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #4 from Gilles Caulier <[hidden email]> ---
I'm not sure if script has not changed since 1.7.0. We are now in 4.0.0 beta
stage...

As i don't manage this script code, i'mnot sure about the story.

You don't need to checkout whole repository to make a patch with current
implementation.
Just use web git interface to take last scrit version :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/show/utilities/scripts/digitaglinktree

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Harald.Heigl1000+kde]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #5 from [hidden email] ---
Created attachment 83165
  --> https://bugs.kde.org/attachment.cgi?id=83165&action=edit
Patch to current digitaglinktree

Sorry, in master is only the 5 year old digitaglinktree, this patch is based on
this 1.7.0 version out of master.

But in this buglog there are also some good changes to this script, so I've
also a patch to the "inofficial" 1.8.2, I'll upload here too.

If there are any problems let me know.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Harald.Heigl1000+kde]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #6 from [hidden email] ---
Created attachment 83166
  --> https://bugs.kde.org/attachment.cgi?id=83166&action=edit
Patch to the inoffical 1.8.2 digitaglinktree

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Why you don't take current implementation of script from git/master and patch
it ?

I cannot accept a patch against a older version as 1.x.

Script have changes since 1.x. Your patch must take a care about and must be
tested with current implementation with database schema...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Your patches are against an older digiKam release based on 1.x version ?

We are currently on digiKam 3.5.0 release and 4.0.0 is on the way...

We cannot accept any patches like this. Please _make_ and _test_ a patch
against 3.5.0 release which is the last stable, to be sure to include all last
database schema changes.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Harald.Heigl1000+kde]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #9 from [hidden email] ---
Sorry I took the file in the link you gave me for the patch:
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/show/utilities/scripts/digitaglinktree

So it is definitely git-master (if the link is correct), I just said the
digtaglinktree-version is at 1.7.0 and 5 years old (it's written in the
digitaglinktree file), never said that digiKam is at version 1.x.

But honestly it's only tested against digiKam 3.1.0 (my current-digikam
version), not against 3.5.0, I don't know database schema changes since then,
perhaps if I find some time ...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #10 from Gilles Caulier <[hidden email]> ---
3.1.0 is safe to test. There is no DB changes since 3.1.0 to 3.5.0.

DB schema is given in a LibreOffice sheet in core/project/documents folder

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #11 from Gilles Caulier <[hidden email]> ---
krienke,

Another entry about digikamlinktree for you...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #12 from [hidden email] ---
@[hidden email]

I tried to merge my 1.8.3 version with your 1.8.3 version into a new attached
1.8.4beta version that incorporates your nice code for MYSQL support.

For me 1.8.4beta seems to work, however I would ask you to check MYSQL support
since I still use sqlite. You are probably using MYSQL and so you should have
better test data than I have.

Thanks
Rainer

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

https://bugs.kde.org/show_bug.cgi?id=323507

--- Comment #13 from [hidden email] ---
Created attachment 83893
  --> https://bugs.kde.org/attachment.cgi?id=83893&action=edit
digitaglinktree 1.8.4beta

digitaglinktree test version 1.8.4beta

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digitaglinktree - Can't     |digitaglinktree : Can't
                   |find version 1.8.2 in repo  |find version 1.8.2 in repo
                   |& usage with mysql instead  |& usage with mysql instead
                   |of sqlite                   |of sqlite

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digitaglinktree : Can't     |digitaglinktree : usage
                   |find version 1.8.2 in repo  |with mysql instead of
                   |& usage with mysql instead  |sqlite [patch]
                   |of sqlite                   |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #14 from Gilles Caulier <[hidden email]> ---
*** Bug 325273 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=323507

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Export                      |Database-Sqlite

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=323507

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Database-Sqlite             |Database

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=323507

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
   Version Fixed In|                            |5.0.0
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #15 from [hidden email] ---
as Databse schema are currently under re-writting for Mysql and fully
uncompatible with patch provided in bug 323507, we must close this report as
invalid

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel