[digikam] [Bug 320772] New: Unclear cvblobs licensing

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=320772

            Bug ID: 320772
           Summary: Unclear cvblobs licensing
    Classification: Unclassified
           Product: digikam
           Version: 3.3.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkface
          Assignee: [hidden email]
          Reporter: [hidden email]

There is no license header in any file in 3rdparty/cvblobs or file where
cvblobs licensing clarified.
Please add cvblobs licensing information.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=320772

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Kevin Kofler <[hidden email]> ---
For what it's worth, I cannot find any licensing information upstream either!
Is this even Free Software to begin with?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320772

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Nucleo,

cvblob is already used in removeredeyes kipi plugin. I see the same problem in
the past and i patched files accordingly.

Look here :

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/show/removeredeyes/libcvblobs

Note : I plan to factorize cvblob from plugins and cvbmlob from libkface, into
libkface and share file through library. But as you can see, not exactly the
same files are used in both place. So i need to check in-deep to see if there
is no side effect to group code at the same place.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=320772

--- Comment #3 from nucleo <[hidden email]> ---
There are some unclear things also in removeredeyes because in license header
copyright by Dave Grossman but is he real author?
And there is broken link http://opencvlibrary.sourceforge.net/cvBlobsLib

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320772

--- Comment #4 from Gilles Caulier <[hidden email]> ---
It's here :

http://opencv.willowgarage.com/wiki/cvBlobsLib

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=320772

--- Comment #5 from Kevin Kofler <[hidden email]> ---
Unfortunately, the license headers you added are not correct, they state a
wrong author! The functions all have comments stating they were written by
another person. The copyright date also looks incorrect. The real copyright
holder(s) need to approve the GPL (or GPL-compatible) licensing, or (failing
that) the offending code needs to be removed/replaced.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320772

--- Comment #6 from Gilles Caulier <[hidden email]> ---
And here is better :

https://code.google.com/p/cvblob/

Sound like new repository...

Look on left side : LGPL

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=320772

--- Comment #7 from Kevin Kofler <[hidden email]> ---
That is a completely different library, with a similar name, for the same
purpose, but completely different code (and thus copyright status). It even
links to "cvBlobs Library (alternative to cvBlob)" on its front page
("alternative" = not the same code).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=320772

--- Comment #8 from Andi Clemens <[hidden email]> ---
As I added the library 4 years ago (or so), it had a file with GPL licensing in
it. But I can not find it anymore in the current repository?
The only thing I see right now is a readme.txt file with a guy named "Ahmet
Onat", maybe he is the original author?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=320772

--- Comment #9 from Kevin Kofler <[hidden email]> ---
According to the wiki, he's only the one who did the GNU/Linux port.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320772

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.1.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |face/8581dd6c685f103a874cd1
                   |                            |fe92747f8da3a0323f

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Git commit 8581dd6c685f103a874cd1fe92747f8da3a0323f by Gilles Caulier.
Committed on 12/06/2014 at 05:57.
Pushed by cgilles into branch 'master'.

Accordingly with Marcel Wiesweg comment #1 from bugs #324566, OpenTLD and
CVBlobs libraries embeded in libkface can be dropped.
This code is not used anymore.
Code polish

M  +2    -6    CMakeLists.txt
D  +0    -2    OpenTLD/CMakeLists.txt
D  +0    -262  OpenTLD/src/3rdparty/cvblobs/BlobContour.cpp
D  +0    -98   OpenTLD/src/3rdparty/cvblobs/BlobContour.h
D  +0    -22   OpenTLD/src/3rdparty/cvblobs/BlobLibraryConfiguration.h
D  +0    -502  OpenTLD/src/3rdparty/cvblobs/BlobOperators.cpp
D  +0    -754  OpenTLD/src/3rdparty/cvblobs/BlobOperators.h
D  +0    -81   OpenTLD/src/3rdparty/cvblobs/BlobProperties.cpp
D  +0    -72   OpenTLD/src/3rdparty/cvblobs/BlobProperties.h
D  +0    -961  OpenTLD/src/3rdparty/cvblobs/BlobResult.cpp
D  +0    -174  OpenTLD/src/3rdparty/cvblobs/BlobResult.h
D  +0    -27   OpenTLD/src/3rdparty/cvblobs/CMakeLists.txt
D  +0    -418  OpenTLD/src/3rdparty/cvblobs/ComponentLabeling.cpp
D  +0    -30   OpenTLD/src/3rdparty/cvblobs/ComponentLabeling.h
D  +0    -708  OpenTLD/src/3rdparty/cvblobs/blob.cpp
D  +0    -174  OpenTLD/src/3rdparty/cvblobs/blob.h
D  +0    -41   OpenTLD/src/libopentld/CMakeLists.txt
D  +0    -275  OpenTLD/src/libopentld/tld/Clustering.cpp
D  +0    -61   OpenTLD/src/libopentld/tld/Clustering.h
D  +0    -99   OpenTLD/src/libopentld/tld/DetectionResult.cpp
D  +0    -60   OpenTLD/src/libopentld/tld/DetectionResult.h
D  +0    -347  OpenTLD/src/libopentld/tld/DetectorCascade.cpp
D  +0    -98   OpenTLD/src/libopentld/tld/DetectorCascade.h
D  +0    -262  OpenTLD/src/libopentld/tld/EnsembleClassifier.cpp
D  +0    -81   OpenTLD/src/libopentld/tld/EnsembleClassifier.h
D  +0    -85   OpenTLD/src/libopentld/tld/ForegroundDetector.cpp
D  +0    -55   OpenTLD/src/libopentld/tld/ForegroundDetector.h
D  +0    -84   OpenTLD/src/libopentld/tld/IntegralImage.h
D  +0    -188  OpenTLD/src/libopentld/tld/NNClassifier.cpp
D  +0    -64   OpenTLD/src/libopentld/tld/NNClassifier.h
D  +0    -43   OpenTLD/src/libopentld/tld/NormalizedPatch.h
D  +0    -481  OpenTLD/src/libopentld/tld/TLD.cpp
D  +0    -78   OpenTLD/src/libopentld/tld/TLD.h
D  +0    -249  OpenTLD/src/libopentld/tld/TLDUtil.cpp
D  +0    -120  OpenTLD/src/libopentld/tld/TLDUtil.h
D  +0    -103  OpenTLD/src/libopentld/tld/VarianceFilter.cpp
D  +0    -60   OpenTLD/src/libopentld/tld/VarianceFilter.h
M  +6    -8    libkface/CMakeLists.txt
M  +119  -80   libkface/alignment-congealing/funnelreal.cpp
M  +8    -9    libkface/alignment-congealing/funnelreal.h
M  +3    -1    libkface/alignment-flandmark/flandmarkaligner.cpp
M  +0    -3    libkface/alignment-flandmark/flandmarkaligner.h
M  +1    -48   libkface/database/trainingdb.cpp
M  +1    -7    libkface/database/trainingdb.h
M  +8    -6    libkface/detection/opencvfacedetector.cpp
M  +2    -2    libkface/detection/opencvfacedetector.h
M  +11   -10   libkface/facedetector.cpp
M  +19   -15   libkface/preprocessing-tantriggs/tantriggspreprocessor.cpp
M  +4    -2    libkface/preprocessing-tantriggs/tantriggspreprocessor.h
D  +0    -225  libkface/recognition-opentld/opentldfacerecognizer.cpp
D  +0    -92   libkface/recognition-opentld/opentldfacerecognizer.h
D  +0    -106  libkface/recognition-opentld/unitfacemodel.cpp
D  +0    -97   libkface/recognition-opentld/unitfacemodel.h
M  +35   -19   libkface/recognitiondatabase.cpp

http://commits.kde.org/libkface/8581dd6c685f103a874cd1fe92747f8da3a0323f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel