[digikam] [Bug 320371] New: Panels not hidden when they should be

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=320371

            Bug ID: 320371
           Summary: Panels not hidden when they should be
    Classification: Unclassified
           Product: digikam
           Version: 3.2.0
          Platform: Gentoo Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Albums GUI
          Assignee: [hidden email]
          Reporter: [hidden email]

Hide toolbars/thumbbar/sidebars does not work correctly.

Reproducible: Always

Steps to Reproduce:
Settings > Configure digikam > Album View > Hide toolbars, Hide thumbbar, Hide
sidebars
Press Ctrl+Shift+f, and things seem to work correctly.
Restart digiKam.
Press Ctrl+Shift+f, now the window border and the bottom bar with the filters
disappears, but the toolbars, thumbbar and sidebars do not.
Settings > Configure digikam, don't change anything, just click OK to close it.
Press Ctrl+Shift+f, now the panels hide correctly.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
When you close digiKam to restart, you still in Full Screen mode ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #2 from DrSlony <[hidden email]> ---
I go back to normal mode before closing.

Now that you asked I tried going to fullscreen mode and hitting Alt+F4 to close
digiKam. When I restart digiKam the menus are hidden and hitting Ctrl+Shift+f
doesn't get them back! Only people who know of the Ctrl+m shortcut will be able
to get them back.

I've recorded a screencast for you. It shows how the panels are not hidden
despite the hide buttons being ticked, then it shows that the panels do hide if
I simply go into Configure digiKam and just press OK, and then it shows that
when I close digiKam while in fullscreen mode (using Alt+F4), the menu bar is
missing after restarting, and I had to use Ctrl+m to get it back.
http://filebin.net/nsiav9f7yo

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #3 from Gilles Caulier <[hidden email]> ---
With 3.2.0 release i factored Fullscreen mode code and rewritten a lots of
stuff...

I'm sure to have tested all these case here, and all are not reproducible...

The question is why ???

main window affected to factored code are :

- AlbumGUI
- ImportUI
- LightTable
- BQM
- ImageEditor

For each window, full screen settings is recorded in digikamrc config file from
your home dir.

Can you reproduce the dysfunction with all windows ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Git commit 439316380574b6dc8b3c3ed37efa1e74656c342f by Gilles Caulier.
Committed on 28/05/2013 at 14:01.
Pushed by cgilles into branch 'master'.

factoring everywhere Genreal config group used to store main windows settings
in RC file
Ensure that full screen settings is loaded at initialization of AlbumGUI.
Related: bug 320016, bug 319876

M  +11   -9    digikam/main/digikamapp.cpp
M  +6    -6    digikam/utils/albumsettings.cpp
M  +1    -1    digikam/utils/albumsettings.h
M  +4    -4    utilities/setup/setupalbumview.cpp

http://commits.kde.org/digikam/439316380574b6dc8b3c3ed37efa1e74656c342f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #5 from DrSlony <[hidden email]> ---
When I enable
Settings > Configure digikam > Light Table > Hide toolbars, Hide sidebars
and restart digiKam, all panels still hide as they should in the Light Table,
so that part works. Seems that just the album view does not.

I found no "Hide toolbars/sidebars" options for ImportUI, BQM or ImageEditor.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Created attachment 80132
  --> https://bugs.kde.org/attachment.cgi?id=80132&action=edit
ImportUI full-screen options

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Created attachment 80133
  --> https://bugs.kde.org/attachment.cgi?id=80133&action=edit
LightTable full-screen options

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Created attachment 80134
  --> https://bugs.kde.org/attachment.cgi?id=80134&action=edit
ImageEditor full-screen options

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Created attachment 80135
  --> https://bugs.kde.org/attachment.cgi?id=80135&action=edit
AlbumUI full-screen options

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Only LightTable as thumbbar settings not present, because this tool will become
unsuitable without it...

BQM do not have settings panel for full screen.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #11 from DrSlony <[hidden email]> ---
Having ticked all those boxes:
AlbumGUI - does not hide what it should
ImportUI - no problem
Light Table - no problem
Image Editor - no problem

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=320371

--- Comment #12 from Gilles Caulier <[hidden email]> ---
yes this i have suspected...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel