[digikam] [Bug 319853] New: Untranslatable strings in timeline tab

[André Marcelo Alvarenga]

https://bugs.kde.org/show_bug.cgi?id=319853

            Bug ID: 319853
           Summary: Untranslatable strings in timeline tab
    Classification: Unclassified
           Product: digikam
           Version: 3.1.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Time Line
          Assignee: [hidden email]
          Reporter: [hidden email]

There are 3 strings untranslatable:

Start:
End:
%1 items

See screenshot.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[André Marcelo Alvarenga]

https://bugs.kde.org/show_bug.cgi?id=319853

--- Comment #1 from André Marcelo Alvarenga <[hidden email]> ---
Created attachment 79890
  --> https://bugs.kde.org/attachment.cgi?id=79890&action=edit
Screenshot

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=319853

Burkhard Lueck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=319853

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
"Start" is the time-line item selected.
"end" is the last time-line item selected
%1 items is the numbers of items from selection.

Do you have tried to use time-line through vertical cursor to make a selection
?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=319853

--- Comment #3 from Burkhard Lueck <[hidden email]> ---
digikam/date/timelinewidget.cpp#328 has:

infoDate = i18nc("Week #weeknumber - month name - year string\nStart:\tEnd: ",
                             "Week #%1 - %2 %3\n%4\t%5",
                             weekNb,
                             d->calendar->monthName(date),
                             d->calendar->formatDate(date, "%Y"),
                             "Start: " + d->calendar->formatDate(date,  
KLocale::Day, KLocale::LongNumber),
                             "End: "   + d->calendar->formatDate(endDate,
KLocale::Day, KLocale::LongNumber));

Missing i18n call for "Start: " and "End: ", so both strings are
untranslatable.
No idea where "0 item"/"%1 items" displyaed in the widget is in the code.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=319853

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Burkhard,

"item(s)" string is implemented in
leftsidebarwidgets.cpp::TimelineSideBarWidget::slotCursorPositionChanged()

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/leftsidebarwidgets.cpp#L699

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=319853

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/f6154395abbf034db033296
                   |                            |ceb480a88131e948d

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Git commit f6154395abbf034db033296ceb480a88131e948d by Gilles Caulier.
Committed on 16/05/2013 at 10:41.
Pushed by cgilles into branch 'master'.

fix missing i18n
constify and polish

M  +41   -41   digikam/date/timelinewidget.cpp
M  +6    -6    digikam/date/timelinewidget.h
M  +56   -55   digikam/views/leftsidebarwidgets.cpp
M  +42   -42   digikam/views/leftsidebarwidgets.h

http://commits.kde.org/digikam/f6154395abbf034db033296ceb480a88131e948d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=319853

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=319853

Burkhard Lueck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #6 from Burkhard Lueck <[hidden email]> ---
digikam/views/leftsidebarwidgets.cpp#699

    if (val >= 2)
        d->cursorCountLabel->setText(i18n("%1 items", QString::number(val)));
    else
        d->cursorCountLabel->setText(i18n("%1 item", QString::number(val)));

It is impossible to translate this properly in languages with different plural
forms than english, see:
http://techbase.kde.org/Development/Tutorials/Localization/i18n#Plurals

Please use i18np() call

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=319853

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Git commit 949ab3b1c472324a1327690ca0cbff8406d7230e by Gilles Caulier.
Committed on 16/05/2013 at 12:44.
Pushed by cgilles into branch 'master'.

use i18np

M  +1    -5    digikam/views/leftsidebarwidgets.cpp

http://commits.kde.org/digikam/949ab3b1c472324a1327690ca0cbff8406d7230e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=319853

Burkhard Lueck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel