[digikam] [Bug 319294] New: Thumbnails disappear when stretching Thumbnail column in Table view

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 319294] New: Thumbnails disappear when stretching Thumbnail column in Table view

nurupobugskde
https://bugs.kde.org/show_bug.cgi?id=319294

            Bug ID: 319294
           Summary: Thumbnails disappear when stretching Thumbnail column
                    in Table view
    Classification: Unclassified
           Product: digikam
           Version: 3.2.0-git
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

When stretching Thumbnail column in Table view with thumbnails set to 256,
thumbnails will disappear and digiKam would complain "digikam(27871)/digikam
(core): ThumbnailLoadThread::load: Thumbnail size  337  is larger than  256 .
Refusing to load.".
It does that when columns width is greater than `ThumbnailSize::Huge` (256).
DigiKam shouldn't use the column's width as an thumbnails' width and pass it to
 `ThumbnailLoadThread::load`, since column's width is irrelevant from
thumbnails' width. User can set arbitrary width of the column and changing
column's width doesn't resize thumbnails.

Reproducible: Always

Steps to Reproduce:
1. Open digiKam with some images shown.
2. Switch to Table view.
3. Increase thumbnails' size to 256 by using the zoom slider.
4. Stretch the Thumbnail column of the Table view.
Actual Results:  
When stretching the Thumbnail column too much (>256px), thumbnails disappear.

Expected Results:  
When stretching the Thumbnail column too much (>256px), thumbnails don't
disappear.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 319294] Thumbnails disappear when stretching Thumbnail column in Table view

nurupobugskde
https://bugs.kde.org/show_bug.cgi?id=319294

--- Comment #1 from nurupo <[hidden email]> ---
Created attachment 79681
  --> https://bugs.kde.org/attachment.cgi?id=79681&action=edit
patch_319294.diff

Since column's width is irrelevant to thumbnail's width, don't use it as size
parameter.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 319294] Thumbnails disappear when stretching Thumbnail column in Table view [patch]

Gilles Caulier-4
In reply to this post by nurupobugskde
https://bugs.kde.org/show_bug.cgi?id=319294

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Thumbnails disappear when   |Thumbnails disappear when
                   |stretching Thumbnail column |stretching Thumbnail column
                   |in Table view               |in Table view [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 319294] Thumbnails disappear when stretching Thumbnail column in Table view [patch]

Michael G. Hansen
In reply to this post by nurupobugskde
https://bugs.kde.org/show_bug.cgi?id=319294

Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/885ccad530ba0ed23421f77
                   |                            |4a06a0f65c6d27fab

--- Comment #2 from Michael G. Hansen <[hidden email]> ---
Git commit 885ccad530ba0ed23421f774a06a0f65c6d27fab by Michael Georg Hansen.
Committed on 04/05/2013 at 13:22.
Pushed by mghansen into branch 'master'.

Fix thumbnails disappearing when columns are too wide.

The idea here is that for landscape images, we adjust the height to
to be as high as the row height as long as the width can stretch enough
because the column is wider than the thumbnail size.
However, digiKam limits the thumbnail size to 256, so we also do that here.

M  +9    -1    digikam/views/tableview_column_thumbnail.cpp

http://commits.kde.org/digikam/885ccad530ba0ed23421f774a06a0f65c6d27fab

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 319294] Thumbnails disappear when stretching Thumbnail column in Table view [patch]

Gilles Caulier-4
In reply to this post by nurupobugskde
https://bugs.kde.org/show_bug.cgi?id=319294

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 319294] Thumbnails disappear when stretching Thumbnail column in Table view [patch]

Gilles Caulier-4
In reply to this post by nurupobugskde
https://bugs.kde.org/show_bug.cgi?id=319294

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.2.0-git                   |3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 319294] Thumbnails disappear when stretching Thumbnail column in Table view [patch]

bugzilla_noreply
In reply to this post by nurupobugskde
https://bugs.kde.org/show_bug.cgi?id=319294

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Thumbnails

--
You are receiving this mail because:
You are the assignee for the bug.