[digikam] [Bug 318726] New: Some BQM tools in a workflow don't restore (all) parameters properly

[Matthias Welwarsky]

https://bugs.kde.org/show_bug.cgi?id=318726

            Bug ID: 318726
           Summary: Some BQM tools in a workflow don't restore (all)
                    parameters properly
    Classification: Unclassified
           Product: digikam
           Version: 3.2.0-git
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Batch Queue Manager
          Assignee: [hidden email]
          Reporter: [hidden email]

- ICC convert does not restore the color profile properly: If you look
carefully, you see that at first the correct profile is restored, but a
split-second later it changes back to the default. Something appears to
overwrite the restored value

- Convert2JPEG does not restore the chroma subsampling setting

Reproducible: Always

Steps to Reproduce:
1. Create a batch queue, one item is enough
2. Load a pre-saved workflow containing the ICC convert and Convert2JPEG tools

Actual Results:  
Not all tool settings are restored as saved in the workflow

Expected Results:  
All tools settings return to their saved values

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
*** Bug 318771 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin]

https://bugs.kde.org/show_bug.cgi?id=318726

Martin <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Martin <[hidden email]> ---
I'm using 3.0.0 within Kubuntu 12.4

I did set up a batch set for changing the size and then do a crop and save
this. Setting it up is working great, running too but when I save it it's
missing to save my sizes. In the queue.xml after saving it looks like this:

    <queue>
        <queuetitle value="Make_4to3_1024_quer"/>
        <queuedesc value=""/>
        <renamingparser value="[file]_##"/>
        <useoriginalalbum value="1"/>
        <workingurl value=""/>
        <conflictrule value="1"/>
        <renamingrule value="1"/>
        <rawloadingrule value="1"/>
        <rawdecodingsettings>
            <autobrightness value="1"/>
            <sixteenbitsimage value="0"/>
            <brightness value="1"/>
            <rawquality value="0"/>
            <inputcolorspace value="0"/>
            <outputcolorspace value="1"/>
            <rgbinterpolate4colors value="0"/>
            <dontstretchpixels value="0"/>
            <unclipcolors value="0"/>
            <whitebalance value="1"/>
            <customwhitebalance value="6500"/>
            <customwhitebalancegreen value="1"/>
            <halfsizecolorimage value="0"/>
            <enableblackpoint value="0"/>
            <blackpoint value="0"/>
            <enablewhitepoint value="0"/>
            <whitepoint value="0"/>
            <noisereductiontype value="0"/>
            <noisereductionthreshold value="0"/>
            <enablecacorrection value="0"/>
            <redchromaticaberrationmultiplier value="0"/>
            <bluechromaticaberrationmultiplier value="0"/>
            <medianfilterpasses value="0"/>
            <inputprofile value=""/>
            <outputprofile value=""/>
            <deadpixelmap value=""/>
            <whitebalanceareax value="0"/>
            <whitebalanceareay value="0"/>
            <whitebalanceareawidth value="0"/>
            <whitebalanceareaheight value="0"/>
            <dcbiterations value="-1"/>
            <dcbenhancefl value="0"/>
            <eecirefine value="0"/>
            <esmedpasses value="0"/>
            <nrchrominancethreshold value="0"/>
            <expocorrection value="0"/>
            <expocorrectionshift value="1"/>
            <expocorrectionhighlight value="0"/>
        </rawdecodingsettings>
        <tool>
            <toolname value="Resize"/>
            <toolgroup value="5"/>
            <index value="0"/>
            <version value="1"/>
            <parameter type="bool" value="true" name="LengthCustom"/>
            <parameter type="bool" value="true" name="LengthPreset"/>
            <parameter type="bool" value="true" name="UseCustom"/>
        </tool>
        <tool>
            <toolname value="Crop"/>
            <toolgroup value="5"/>
            <index value="1"/>
            <version value="1"/>
            <parameter type="bool" value="true" name="heightInput"/>
            <parameter type="bool" value="true" name="widthInput"/>
            <parameter type="bool" value="true" name="xInput"/>
            <parameter type="bool" value="true" name="yInput"/>
        </tool>
    </queue>

for the Rezise tool it should have saved 2250 for length somehwere and for the
crop it should have saved real values for hieght, width, y and y, but it
didn't.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.2.0-git                   |3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #3 from Jan Wolter <[hidden email]> ---
I noticed on my digiKam 4.2 comparable problems regarding the tools curved
adjust, b&w convert, and lens auto-correction. I have the following problems:

CURVES ADJUST:
When I add the curves adjust tool to the Batch Queue and create a curve, it
will not be saved in the queue.xml file, as you can see here (no values for the
different channels are saved):
<tool>
            <toolname value="CurvesAdjust"/>
            <toolgroup value="3"/>
            <index value="0"/>
            <version value="1"/>
            <parameter type="bool" value="true" name="curvesDepth"/>
            <parameter type="int" value="0" name="curvesType"/>
            <parameter type="QPolygon" value="" name="values[AlphaChannel]"/>
            <parameter type="QPolygon" value="" name="values[BlueChannel]"/>
            <parameter type="QPolygon" value="" name="values[GreenChannel]"/>
            <parameter type="QPolygon" value=""
name="values[LuminosityChannel]"/>
            <parameter type="QPolygon" value="" name="values[RedChannel]"/>
        </tool>
The problem becomes visible for the user, when digikam is restarted (and
therefore, the workflows get loaded from the queue.xml file): Open Batch Queue
Manager and reload the workflow that contains the curves adjust tool. Then your
defined curve is lost and the only default curve is shown.


B&W CONVERT:
Here is a similar problem as in the adjust curves tool: the luminosity curve is
not saved in the queue.xml file.


LENS AUTO-CORRECTION:
When the radio button "Use Metadata" is selected, the set of corrections
(chromatic aberration, vignetting, color, distortion, and geometry) that could
be applied to a picture can be selected via radio buttons as well. But
independent of the selected set of corrections, in the queue.xml file they are
all marked as true:
<tool>
            <toolname value="LensAutoFix"/>
            <toolgroup value="4"/>
            <index value="0"/>
            <version value="1"/>
            ......
            <parameter type="bool" value="true" name="filterCCA"/>
            <parameter type="bool" value="true" name="filterCCI"/>
            <parameter type="bool" value="true" name="filterDST"/>
            <parameter type="bool" value="true" name="filterGEO"/>
            <parameter type="bool" value="true" name="filterVIG"/>
            ......
        </tool>
And when I deselect the "Use Metadata" button, the radio buttons to select the
corrections are grayed out. I wonder if this is the correct behaviour. I guess
that the corrections should be selectable by the user independent of using
manual setting or metadata information.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #4 from Jan Wolter <[hidden email]> ---
I tested the remaining BQ-Tools and found the following errors, problems, or
suggestions for improvements:

LOCAL-CONTRAST:
Add local contrast tool to the workflow and assign values to the "Power" and
"Blur" parameters of the four stages. Then save the workflow, close digikam and
restart it afterwards. When you load the saved workflow, all "Power" and "Blur"
parameters are set to 0, unless they are saved in the queue.xml in the correct
way.

UNSHARP-MASK:
Use the unsharp mask tool in a workflow and assign to the "Radius" parameter a
value with a decimal place unequal 0 (e.g. 2,8). Then start processing the
workflow and look up the Xmp.digiKam.ImageHistory tag in the meta data of the
processed image. There you see an entry like this: <param name="radius"
value="2"/>, where decimal position is cropped. Using the unsharp mask tool in
the image editor, this error is only noticeable.

RESIZE:
Add resize tool to workflow, use custom length and choose a length with slider.
Save the workflow, close digikam and restart it. When you reload the workflow,
the slider displays in any case length "10" unless you have chosen another
value before.
Furthermore, the resize tool in BQ is less powerful than the resize tool in the
image editor. In BQ it is not possible to resize images to another aspect ratio
then the actual image's aspect ratio.

I tested Martins Problem from Comment #2 as well and can say that workflows
using the crop and resize tool are saved correctly to the queue.xml

I'm quite sure that the three errors in local contrast, unsharp mask and resize
tool in addition to the errors in the curves adjust, b&w, and lens
auto-correction tools (reported by the comment #3) are the last errors
concerning BQ tools. I tested really a lot, by defining different workflows,
comparing the saved queue.xml as well as the XMP image history in the processed
image. I would be really happy, when the last six problems get fixed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #5 from Jan Wolter <[hidden email]> ---
I tested the Raw Decoding settings in the Batch Queue Manager and found one
error: The information "Correct false colors in highlights" under the white
balance menu is not saved in the queue.xml and therefore this information could
not be reloaded when you restart digikam and load an previously saved workflow.

P.S. I am working on an external script that generates a BQM-workflow from the
XMP history of an manual processed image. So, I tested all tools really
detailed to get the mapping between XMP history and the queue representation in
the queue.xml file.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #6 from Jan Wolter <[hidden email]> ---
I just noticed a further small problem: An image that get processed by a
workflow that use the flip tool does not get an entry in the
Xmp.digiKam.ImageHistory for the flip tool.
I tested this with digiKam 4.4.0. All previously reported problems are also
reproducable on dk 4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[pascalio]

https://bugs.kde.org/show_bug.cgi?id=318726

pascalio <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from pascalio <[hidden email]> ---
OK, I confirm the bug in my batch workflows as well.
However, I guess this is more of gui bug: when I process images with a saved
workflow, the result in the images is as intended, although in the BQM, the gui
said it would do something wrong.
EX:
- saved workflow = ICC converter --> sRGB.icc ...
- re-open BQM or do any of the steps described above
- BQM's gui says : ICC converter --> Apple RGB = wrong
BUT
- launch the workflow anyway --> my images get sRGB.icc as they should.

Does the same with my other tools. So not so problematic, but really confusing.
Hope it'll help !

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[pascalio]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #8 from pascalio <[hidden email]> ---
See also https://bugs.kde.org/show_bug.cgi?id=333929
Or
https://bugs.kde.org/show_bug.cgi?id=337689

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Gilles Caulier <[hidden email]> ---
*** Bug 337689 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Gilles Caulier <[hidden email]> ---
*** Bug 340965 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #11 from Jan Wolter <[hidden email]> ---
Created attachment 89831
  --> https://bugs.kde.org/attachment.cgi?id=89831&action=edit
Solves problem related to Raw Decoding in BQM

Solves the problem that "Correct false colors in hightlights" in Raw Decodings
is not saved (and therefore not loaded) to queue.xml

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #12 from Jan Wolter <[hidden email]> ---
Unfortunately, my patch raises a new Bug, when I process a RAW file in the BMQ
with enabled "Correct false colors in hightlights":

Thread 1 (Thread 0x7fb6e25fb840 (LWP 17927)):
[KCrash Handler]
#6  0x00007fb6dc9888c9 in QRasterWindowSurface::~QRasterWindowSurface
(this=0x4d78210, __in_chrg=<optimized out>) at
painting/qwindowsurface_raster.cpp:117
#7  0x00007fb6dc988949 in QRasterWindowSurface::~QRasterWindowSurface
(this=0x4d78210, __in_chrg=<optimized out>) at
painting/qwindowsurface_raster.cpp:121
#8  0x00007fb6dc9a0c5c in QWidgetBackingStore::~QWidgetBackingStore
(this=0x4d3fcd0, __in_chrg=<optimized out>) at painting/qbackingstore.cpp:909
#9  0x00007fb6dc7d9009 in QWidgetBackingStoreTracker::destroy (this=0x4c70550)
at kernel/qwidget.cpp:225
#10 0x00007fb6dc7d91a9 in QWidgetPrivate::deleteExtra
(this=this@entry=0x2eb2e00) at kernel/qwidget.cpp:1833
#11 0x00007fb6dc7d93bd in QWidgetPrivate::~QWidgetPrivate (this=0x2eb2e00,
__in_chrg=<optimized out>) at kernel/qwidget.cpp:365
#12 0x00007fb6dc7d9649 in QWidgetPrivate::~QWidgetPrivate (this=0x2eb2e00,
__in_chrg=<optimized out>) at kernel/qwidget.cpp:370
#13 0x00007fb6dbdbc735 in cleanup (pointer=<optimized out>) at
../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:62
#14 ~QScopedPointer (this=0x2eb2dc8, __in_chrg=<optimized out>) at
../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:100
#15 QObject::~QObject (this=0x2eb2dc0, __in_chrg=<optimized out>) at
kernel/qobject.cpp:816
#16 0x00007fb6dc7e1dcc in QWidget::~QWidget (this=0x2eb2dc0,
__in_chrg=<optimized out>) at kernel/qwidget.cpp:1554
#17 0x00007fb6e01042d4 in Digikam::JPEGSettings::~JPEGSettings (this=0x2eb2dc0,
__in_chrg=<optimized out>) at
/home/jan/Downloads/digikamGIT/core/libs/dimg/loaders/jpegsettings.cpp:135
#18 0x00007fb6e010430a in Digikam::JPEGSettings::~JPEGSettings (this=0x2eb2dc0,
__in_chrg=<optimized out>) at
/home/jan/Downloads/digikamGIT/core/libs/dimg/loaders/jpegsettings.cpp:138
#19 0x000000000076b77d in Digikam::BatchTool::~BatchTool (this=0x2eb05b0,
__in_chrg=<optimized out>) at
/home/jan/Downloads/digikamGIT/core/utilities/queuemanager/manager/batchtool.cpp:141
#20 0x0000000000799195 in Digikam::Convert2JPEG::~Convert2JPEG (this=0x2eb05b0,
__in_chrg=<optimized out>) at
/home/jan/Downloads/digikamGIT/core/utilities/queuemanager/basetools/convert/convert2jpeg.cpp:56
#21 0x00000000007991c4 in Digikam::Convert2JPEG::~Convert2JPEG (this=0x2eb05b0,
__in_chrg=<optimized out>) at
/home/jan/Downloads/digikamGIT/core/utilities/queuemanager/basetools/convert/convert2jpeg.cpp:58
#22 0x000000000076f80c in Digikam::BatchToolsManager::~BatchToolsManager
(this=0x2eb21b0, __in_chrg=<optimized out>) at
/home/jan/Downloads/digikamGIT/core/utilities/queuemanager/manager/batchtoolsmanager.cpp:169
#23 0x000000000076fb76 in
Digikam::BatchToolsManagerCreator::~BatchToolsManagerCreator (this=0x2eb21b0,
__in_chrg=<optimized out>) at
/home/jan/Downloads/digikamGIT/core/utilities/queuemanager/manager/batchtoolsmanager.cpp:91
#24 0x000000000076eee9 in destroy () at
/home/jan/Downloads/digikamGIT/core/utilities/queuemanager/manager/batchtoolsmanager.cpp:98
#25 0x00000000005c3947 in KCleanUpGlobalStatic::~KCleanUpGlobalStatic
(this=0xc61e80 <Digikam::._228::operator->()::cleanUpObject>,
__in_chrg=<optimized out>) at /usr/include/kglobal.h:62
#26 0x00007fb6db107149 in __run_exit_handlers (status=0, listp=0x7fb6db48a6c8
<__exit_funcs>, run_list_atexit=run_list_atexit@entry=true) at exit.c:82
#27 0x00007fb6db107195 in __GI_exit (status=<optimized out>) at exit.c:104
#28 0x00007fb6db0ececc in __libc_start_main (main=0x6fb8dd <main(int, char**)>,
argc=5, argv=0x7fffed662bd8, init=<optimized out>, fini=<optimized out>,
rtld_fini=<optimized out>, stack_end=0x7fffed662bc8) at libc-start.c:321
#29 0x0000000000496d09 in _start ()


Gilles, could you please test it? For me, the digiKam code is very new, so I am
not familiar with it. But, I would like to learn the ropes and solve some more
errors in a correct way.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Some BQM tools in a         |Some BQM tools in a
                   |workflow don't restore      |workflow don't restore
                   |(all) parameters properly   |(all) parameters properly
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Your patch sound fine. Crash do not show any code from your patch. Crash still
reproducible all the time ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #14 from Jan Wolter <[hidden email]> ---
Yes Gilles, your are right. I tested again very detailed and the error occures
(I will report and the describe this new bug immediately) even without my
patch. So, I think it is save to add my patch to repository.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #15 from Gilles Caulier <[hidden email]> ---
As you have figured out some code missing in settings XML conversion engine, i
certainly forget similar codes into other BQM tools. Your patch touch the
common queue settings, not separated BQM tool.

In fact, Editor tools and BQM tools use common code about filter to use in a
queue.
Filters are defined into core/libs/dimg/filters/

Not all filters from Editor are ported yet to BQM. See list on
core/imageplugins/TODO file.

A filter define 3 parts :

- an engine to process image, as you pass an image, it processed, and a target
image is provided. ex :
- a settings container, to pass to engine to tune filter effect. This container
is used by BQM to get and set from XML to settings and vis-versa. Conversion is
done through BatchToolSet, BatchToolSettings, and WorkflowManager classes from
BQM. To simplify, filter settings stored in container, are converted as a QMap
of (QString, QVariant) pair and converted by Qt automatically to XML in
Workflow manager loops. Note that XML conversion is only used in BQM, not
Editor. Editor use VersionManager engine which is mostly complicated and we
don't need it in BQM.
- a setttings widget which permit to BQM and Editor to show all settings in
GUI.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #16 from Gilles Caulier <[hidden email]> ---
Git commit 2cce7ede354e5796adc9487c8b6f57e8d3433613 by Gilles Caulier.
Committed on 05/12/2014 at 08:53.
Pushed by cgilles into branch 'master'.

apply patch #89831 to fix XML conversion from Raw decoding settings used in
main Queue configuration

M  +8    -0    libs/dimg/drawdecoding.cpp

http://commits.kde.org/digikam/2cce7ede354e5796adc9487c8b6f57e8d3433613

diff --git a/libs/dimg/drawdecoding.cpp b/libs/dimg/drawdecoding.cpp
index b03dc1f..626b1cb 100644
--- a/libs/dimg/drawdecoding.cpp
+++ b/libs/dimg/drawdecoding.cpp
@@ -397,6 +397,10 @@ void DRawDecoding::decodingSettingsToXml(const
RawDecodingSettings& prm, QDomEle
     data.setAttribute(QString::fromLatin1("value"), prm.autoBrightness);
     elm.appendChild(data);

+    data = doc.createElement(QString::fromLatin1("fixcolorshighlights"));
+    data.setAttribute(QString::fromLatin1("value"), prm.fixColorsHighlights);
+    elm.appendChild(data);
+
     data = doc.createElement(QString::fromLatin1("sixteenbitsimage"));
     data.setAttribute(QString::fromLatin1("value"), prm.sixteenBitsImage);
     elm.appendChild(data);
@@ -565,6 +569,10 @@ void DRawDecoding::decodingSettingsFromXml(const
QDomElement& elm, RawDecodingSe
         {
             prm.autoBrightness = (bool)val.toInt(&ok);
         }
+        else if (key == "fixcolorshighlights")
+        {
+            prm.fixColorsHighlights = (bool)val.toInt(&ok);
+        }
         else if (key == "sixteenbitsimage")
         {
             prm.sixteenBitsImage = (bool)val.toInt(&ok);

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jan Wolter-2]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #17 from Jan Wolter <[hidden email]> ---
Thank you for the additional information about the software architecture. I
will look at the code and try to fix the bugs. At least in January, I have some
time to do it.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel