[digikam] [Bug 314441] New: Rename settings during import ignored

classic Classic list List threaded Threaded
98 messages Options
12345
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation during import ignored [patch]

Nicky726
https://bugs.kde.org/show_bug.cgi?id=314441

Nicky726 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #73 from Nicky726 <[hidden email]> ---
In version 4.0 still works only partially: getting date information from file
works, but from exif does not.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation during import ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #74 from Gilles Caulier <[hidden email]> ---
*** Bug 337987 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation during import ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #75 from Gilles Caulier <[hidden email]> ---
What's the status of this bug ?

Somebody can resume all dysfunction which are pending to fix please

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation during import ignored [patch]

rockhopper.tux
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #76 from [hidden email] ---
The setting I was using since many many years is still not working since more
then a year, and was not in between:
[meta:Exif.Photo.DateTimeOriginal]{replace:":",""}{replace:" ","T"}
results in DSC_1234.JPG

as well as:
[meta:Exif.Image.DateTime]


But, after reading now posts from above and testing other settings as mentioned
there, I can confirm it is working with the file-timestamp:
[date]
[date:"yyyyMMdd(hhmm)"]-###

[date]{lower} will not set the .JPG extension to lower case - don't know if it
should but I would expect it actually.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rename settings and         |Rename settings and
                   |auto-rotation during import |auto-rotation while
                   |ignored [patch]             |importing ignored [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation while importing ignored [patch]

Peter Albrecht-2
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #77 from Peter Albrecht <[hidden email]> ---
Tested with digikam 4.2.0 on KDE 4.12.5 (gentoo linux):

 - auto rotation does not work:
     - "portrait" fotos are imported as "landscape"
     - clicking from the digikam menu "Image -> Auto Rotate / Flip Using Exif
Information" does rotate them to the correct portrait orientation (after
import, so orientation tag is present in image file)
     - in digikam settings I have turned off "Show images/thumbnails rotated
according to orientation tag"

 - renaming (my personal file rename pattern):
"[cam]{range:13,15}-[file]{lower}.[ext]{lower}"
   - working:
      - plain character as seperators: "-" and "."
      - plain text: "eos"
      - "[file]" -> "IMG_9885"
      - "[ext]" -> "JPG"
      - "[date]" -> "20140901T203242" (time, the picture was taken)
      - '[date:"yyyy-MM-dd_hh-mm-ss"]' -> "2014-09-01_20-32-42" (time, the
picture was taken)
      - modifier "{lower}", "{upper}", "{firstupper}"
      - modifier "{trim}"
      - modifier "{removedoubles}"
      - modifier '{default:"..."}' -> expands to the given default text as
expected
      - modifier '{replace:"IMG","XXX",i}' -> replaces "IMG" with "XXX"
      - modifier '{replace:"\w+_","PIC",ri}' -> replaces "IMG_" with "PIC"
(RegExp)
      - modifier "{range:...}"
      - even modifier combinations work: '[cam]{default:"spaces  "}{trim}end'
becomes "spacesend"

   - failing:
      1) "[cam]" (selected by clicking "Camera" in the Options-Popup-Menu)
becomes an empty string (should be something like "Canon EOS 550D" (in my
case))
      2) "[meta:Exif.Photo.DateTimeOriginal]"
      3) "[meta:Exif.Photo.ExposureTime]"
      4) "[meta:Exif.Image.Model]"
      5) "[meta:Exif.Canon.ModelID]"
      => I guess all "[meta:Exif....]" fail, since I could not find a single
working one
      6) "[dir]" (in my case it is an empty string, which looks wrong; I guess
it should either be "100CANON" (source dir) or "New Fotos" (destination dir);
the online help is not that clear at this point)
      7) "[user]" / "[group]" (file's user and group access settings) -> empty
string
      8) modifier "{unique}": Add for example "[ext]{unique}" in the middle of
the filename and select three images in the download window
            -> this will preview the following filenames: "...JPG...",
"...JPG_1...", "...JPG_2..."
            -> so far so good :)
            -> but if you click "Download Selected", you will find three images
in your digikam collection with the names:
                    "...JPG_3...", "...JPG_4...", "...JPG_5..."
            => so the unique-counter is not reset between "display the preview"
and "really import the images"
      9) "###" -> same problem as "{unique}" modifier: counter not reset; with
three files selected:
            -> preview: "001", "002", "003"
            -> imported files: "004", "005", "006"

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation while importing ignored [patch]

Peter Albrecht-2
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #78 from Peter Albrecht <[hidden email]> ---
(In reply to rockhopper.tux from comment #76)
> ...
> [date]{lower} will not set the .JPG extension to lower case - don't know if
> it should but I would expect it actually.

I read your pattern like:
1) take the pictures date as string
2) convert the date string to lowercase
3) since there is no explicit extension in your pattern, the original files
extension is added, which seems to be uppercase (like in my case)

A modifier only modifies the string immediately in front of it. So from my
point of view, not changing the extension seems to be correct.
Implementing some intelligent magic like "if everything in the pattern is
lowercase, the default added extension should be lowercase, too", would make
the powerful renaming algorithm way more complex, more diffucult to maintain
and more prone to errors, I guess.
(And I personally don't like programs which _try_ to be smart and do something
I did not expect.)
Of course, this is only my opinion and free for discussion.

You can achieve, what you want with:
     [date]{lower}.[ext]{lower}

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation while importing ignored [patch]

rockhopper.tux
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #79 from [hidden email] ---
(In reply to Peter Albrecht from comment #78)

> I read your pattern like:
> 1) take the pictures date as string
> 2) convert the date string to lowercase
> 3) since there is no explicit extension in your pattern, the original files
> extension is added, which seems to be uppercase (like in my case)
>
> A modifier only modifies the string immediately in front of it. So from my
> point of view, not changing the extension seems to be correct.
> Implementing some intelligent magic like "if everything in the pattern is
> lowercase, the default added extension should be lowercase, too", would make
> the powerful renaming algorithm way more complex, more diffucult to maintain
> and more prone to errors, I guess.
> (And I personally don't like programs which _try_ to be smart and do
> something I did not expect.)
> Of course, this is only my opinion and free for discussion.
>
> You can achieve, what you want with:
>      [date]{lower}.[ext]{lower}

Peter, thanks for your response on this, and after reading your explanation and
testing it I totally agree with you.

Please all ignore my my false expectation (last line) from #76, the way it is
working is for sure better and more correct.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings and auto-rotation while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #80 from Gilles Caulier <[hidden email]> ---
Git commit 33d6ff1e170d18a3d9a13a76e21206bdaa49ef18 by Gilles Caulier.
Committed on 28/10/2014 at 23:11.
Pushed by cgilles into branch 'master'.

Apply patch #89348 to restore autorotation feature while downloading from
camera.
Related: bug 340439
FIXED-IN: 4.5.0

M  +18   -8    utilities/importui/main/importui.cpp
M  +2    -2    utilities/importui/main/importui_p.h

http://commits.kde.org/digikam/33d6ff1e170d18a3d9a13a76e21206bdaa49ef18

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rename settings and         |Rename settings while
                   |auto-rotation while         |importing ignored [patch]
                   |importing ignored [patch]   |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.5.0                       |4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #81 from Gilles Caulier <[hidden email]> ---
Hi all,

With commit from comment #80, autorotation feature is fixed in 4.5.0. See patch
given into bug #340439

So, the patch from this report must be updated to only fix rename feature which
still need to be fixed.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CONFIRMED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Teemu Rytilahti
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #82 from Teemu Rytilahti <[hidden email]> ---
(In reply to Andi Clemens from comment #49)

> For example: 5 images in the ImportUI, named image_#### (image_0001,
> image_0002 etc). If you only select the image_0003 and image_0004, they will
> be named image_0001and image_0002 after the download, which is ok, because
> it doesn't make sense to use the names from the ImportUI.

This specific problem is now fixed by
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/f0bba25facfaef1fdcba8f3d0990dbf453abfc7b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Mick Sulley
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Mick Sulley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #83 from Mick Sulley <[hidden email]> ---
On Linux Mint 7 I have just upgraded from DK 4.5 to 4.6.  I use auto rename
when I import pictures from my camera, it was working fine in 4.5 but now it
does not rename but retains the name from the camera file.
On the Import screen I have Customise, then PIC[date] in the box.  
If I select the pictures after import and select Image > Rename it works fine.

Mick Sulley

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Teemu Rytilahti
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.kde.org/show_b
                   |                            |ug.cgi?id=342996

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/7f3459d55dd453f257ece35
                   |                            |398175bba22ea4109
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.7.0

--- Comment #84 from Gilles Caulier <[hidden email]> ---
Git commit 7f3459d55dd453f257ece35398175bba22ea4109 by Gilles Caulier.
Committed on 25/01/2015 at 11:39.
Pushed by cgilles into branch 'master'.

Apply patch #90637 from Maik Qualmann to fix image renaming settings rules in
Import Tool to work properly while downloading.
Related: bug 342996, bug 329438, bug 307253, bug 342430
FIXED-IN: 4.7.0

M  +3    -1    NEWS
M  +2    -2    utilities/importui/backend/cameracontroller.cpp
M  +67   -44   utilities/importui/main/importui.cpp
M  +1    -0    utilities/importui/main/importui.h
M  +5    -0    utilities/importui/views/importview.cpp
M  +1    -0    utilities/importui/views/importview.h

http://commits.kde.org/digikam/7f3459d55dd453f257ece35398175bba22ea4109

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 314441] Rename settings while importing ignored [patch]

Gilles Caulier-4
In reply to this post by Michal Sylwester
https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #85 from Gilles Caulier <[hidden email]> ---
Git commit 0201e6fc8549ac849029daf36eaeadd6ebb4d4ae by Gilles Caulier.
Committed on 25/01/2015 at 13:58.
Pushed by cgilles into branch 'frameworks'.

Backport commit #7f3459d55dd453f257ece35398175bba22ea4109 from git/master to
frameworks branch.
Related: bug 342996, bug 329438, bug 307253, bug 342430

M  +3    -3    utilities/importui/backend/cameracontroller.cpp
M  +74   -50   utilities/importui/main/importui.cpp
M  +1    -0    utilities/importui/main/importui.h
M  +5    -0    utilities/importui/views/importview.cpp
M  +1    -0    utilities/importui/views/importview.h

http://commits.kde.org/digikam/0201e6fc8549ac849029daf36eaeadd6ebb4d4ae

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12345