[digikam] [Bug 314441] New: Rename settings during import ignored

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rename settings during      |Rename settings and
                   |import ignored              |auto-rotation during import
                   |                            |ignored

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[dale]

https://bugs.kde.org/show_bug.cgi?id=314441

dale <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #18 from dale <[hidden email]> ---
I can confirm this as well.  Gentoo Linux here.  

[ebuild   R   ~] kde-base/kdelibs-4.10.2:4  USE="3dnow alsa bzip2 fam handbook
jpeg2k lzma mmx nls opengl (policykit) semantic-desktop spell sse sse2 ssl udev
udisks upower zeroconf -acl (-altivec) (-aqua) -debug -doc -kerberos -openexr
{-test}" 0 kB
[ebuild   R    ] media-gfx/digikam-3.0.0:4  USE="gphoto2 handbook mysql
semantic-desktop thumbnails -addressbook (-aqua) -debug -doc -themedesigner
-video" LINGUAS="-af -ar -az -be -bg -bn -br -bs -ca -cs -csb -cy -da -de -el
-en_GB -eo -es -et -eu -fa -fi -fo -fr -fy -ga -gl -ha -he -hi -hr -hsb -hu -id
-is -it -ja -ka -kk -km -ko -ku -lb -lo -lt -lv -mi -mk -mn -ms -mt -nb -nds
-ne -nl -nn -nso -oc -pa -pl -pt -pt_BR -ro -ru -rw -se -sk -sl -sq -sr
-sr@Latn -ss -sv -ta -te -tg -th -tr -tt -uk -uz -uz@cyrillic -ven -vi -wa -xh
-zh_CN -zh_HK -zh_TW -zu" 0 kB

I thought I was loosing my mind.  :/

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Thomas Bettler-2]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #19 from Thomas Bettler <[hidden email]> ---
I can confirm this as well. Gentoo Linux with digikam 3.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Thomas Arend]

https://bugs.kde.org/show_bug.cgi?id=314441

Thomas Arend <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #20 from Thomas Arend <[hidden email]> ---
I can confirm this for 3.1.0 on KDE 4.10.2 / openSUSE 12.2.

BTW: Does this nightmare with KDE start on digikam also?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin Zecher]

https://bugs.kde.org/show_bug.cgi?id=314441

Martin Zecher <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #21 from Martin Zecher <[hidden email]> ---
I hope that this bug may be fixed soon. Without this features, being able to
"import" from any source seems useless for me, since it's the same as directly
coping the pics with any file manager.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jonatan]

https://bugs.kde.org/show_bug.cgi?id=314441

Jonatan <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #22 from Jonatan <[hidden email]> ---
I've had a short look into the code (I don't really understand it, but I just
went to have a quick look in it).
With the git of apr 10 I figured out that the original name is being used,
because the downloadName field is not being set in the CamItemInfo.
I don't know where the downloadName in the CamItemInfo is supposed to be set,
but what I do know is that it is not happening.
core/utilities/importui/main/importui.cpp:2038 :
        if (downloadName.isEmpty())
        {
            downloadUrl.addPath(settings.file); //<= THIS is being executed
        }
        else
        {
            // when using custom renaming (e.g. by date, see bug 179902)
            // make sure that we create unique names
            downloadUrl.addPath(downloadName);

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Peter Albrecht-2]

https://bugs.kde.org/show_bug.cgi?id=314441

Peter Albrecht <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #23 from Peter Albrecht <[hidden email]> ---
Another gentoo users here, confirming this bug with digikam 3.0.1 and KDE
4.10.2.

 - the enabled auto-rotate checkbox is ignored during import
 - the images are not renamed

Both features worked fine for me with digikam 2.9.0 and KDE 4.9.5.

Concerning the "no auto-rotation problem", I found the following while looking
at digikam's console output:
In digikam 1.9.0 (see bug #274947) you got something like:
---------------------- 8< ----------------------
Digikam::CameraController::executeCommand: Downloading: "IMG_1122.JPG" ...
...
Digikam::CameraController::executeCommand: Exif autorotate: "IMG_1122.JPG" ...
...
Digikam::CameraController::executeCommand: Set metadata from: "IMG_1122.JPG"
...
---------------------- >8 ----------------------
In digikam 3.0.1's console output, the line
"Digikam::CameraController::executeCommand: Exif autorotate" is missing. So it
does not look like a crash while auto-rotating, but the auto-rotation function
is not even called at all.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #24 from Marcel Wiesweg <[hidden email]> ---
Setting the downloadName on each item was an ancient way of doing it. The name
could just be queried in the download pipeline. I'm just unsure about the
correct API to use, hoping for some of Andi's feedback, see 307253

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #25 from Andi Clemens <[hidden email]> ---
The renameManager was initialized in the old code in a method called
void CameraIconView::slotUpdateDownloadNames(bool hasSelection)


This method is not there anymore, I don't know how the new names are generated
nowadays.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jonatan]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #26 from Jonatan <[hidden email]> ---
I tried the following:
        downloadName    = d->renameCustomizer->newName(info.name, info.mtime);

But that did not work, because the renamedFiles list in the
advancedRenameManager is not filled with the files. I can't really figure out
when that is supposed to happen because I'm not familiar with the code, but I
sure hope this helps point out the problem.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #27 from Andi Clemens <[hidden email]> ---
It happened in
void CameraIconView::slotUpdateDownloadNames(bool hasSelection)

but I have no clue where this method is now... :-(

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #28 from Marcel Wiesweg <[hidden email]> ---
Andi, can you give us some guidance which methods of RenameManager need to be
called in which sequence?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #29 from Andi Clemens <[hidden email]> ---
This is the old code before the port, this should be enough:


void CameraIconView::slotUpdateDownloadNames(bool hasSelection)
{
    if (!count())
    {
        return;
    }

    bool useDefault = true;
    int  startIndex = 0;

    if (d->renamer)
    {
        useDefault = d->renamer->useDefault();
        startIndex = d->renamer->startIndex();
    }

    DownloadSettings settings = d->cameraUI->downloadSettings();

    viewport()->setUpdatesEnabled(false);

    // NOTE: see B.K.O #182352: ordering of item count must be adapted sort of
icon view,
    // since items are ordered from the most recent to the older one.
    bool revOrder = !d->cameraUI->chronologicOrder();
    // Camera items selection.

    // reset the start index
    d->renamer->reset();
    d->renamer->setStartIndex(startIndex);

    QList<ParseSettings> cameraFiles;

    for (IconItem* item = (revOrder ? lastItem() : firstItem()); item;
         (revOrder ? item = item->prevItem() : item = item->nextItem()))
    {
        CameraIconItem* viewItem = static_cast<CameraIconItem*>(item);

        if ((hasSelection && item->isSelected()) || !hasSelection)
        {
            QFileInfo fi;
            fi.setFile(QDir(viewItem->itemInfo().folder),
viewItem->itemInfo().name);
            ParseSettings ps;
            ps.fileUrl      = KUrl(fi.absoluteFilePath());
            ps.creationTime = viewItem->itemInfo().mtime;
            cameraFiles << ps;
        }
    }

    d->renamer->renameManager()->addFiles(cameraFiles);
    d->renamer->renameManager()->parseFiles();

    for (IconItem* item = (revOrder ? lastItem() : firstItem()); item;
         (revOrder ? item = item->prevItem() : item = item->nextItem()))
    {
        QString downloadName;
        CameraIconItem* viewItem = static_cast<CameraIconItem*>(item);

        if ((hasSelection && item->isSelected()) || !hasSelection)
        {
            if (!useDefault)
            {
                QFileInfo fi;
                fi.setFile(QDir(viewItem->itemInfo().folder),
viewItem->itemInfo().name);
                downloadName =
d->renamer->renameManager()->newName(fi.absoluteFilePath());
            }
            else
            {
                downloadName = getCasedName(d->renamer->changeCase(),
viewItem->itemInfo());
            }
        }

        if (settings.convertJpeg && !downloadName.isEmpty())
        {
            QFileInfo fi(downloadName);
            QString ext = fi.suffix().toUpper();

            if (ext == QString("JPEG") || ext == QString("JPG") || ext ==
QString("JPE"))
            {
                downloadName.truncate(downloadName.length() - ext.length());
                downloadName.append(settings.losslessFormat.toLower());
            }
        }

        viewItem->setDownloadName(downloadName);
    }

    viewport()->setUpdatesEnabled(true);
    viewport()->update();
}

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #30 from Andi Clemens <[hidden email]> ---
So calling

d->renamer->renameManager()->addFiles(cameraFiles);
d->renamer->renameManager()->parseFiles();

and later

downloadName = d->renamer->renameManager()->newName(fi.absoluteFilePath());

should be enough

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jonatan]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #31 from Jonatan <[hidden email]> ---
Created attachment 79792
  --> https://bugs.kde.org/attachment.cgi?id=79792&action=edit
patch of what I tried, but did not work.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jonatan]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #32 from Jonatan <[hidden email]> ---
Little extra explanation on previous post (sorry, forgot to add it when
uploading patch)

I'm trying to do something like that in the ImportUI::downloadCameraItems
method (don't know if that is the right place, though), but I don't understand
how to get the parameters.

Here's my attempt:
if (!d->renameCustomizer->useDefault()) {
        QList<ParseSettings> renameFiles;
        foreach(CamItemInfo info, list)
        {
            ImageInfo imInfo(info.url());
            ParseSettings settings(imInfo);
            renameFiles.append(settings);
        }
        d->renameCustomizer->renameManager()->addFiles(renameFiles);
        d->renameCustomizer->renameManager()->parseFiles();
    }

However, it does not work, probably  because ImageInfo is an interface to the
database, and we are working here with images that are not yet in the database.
This code gives the following output in the console:
No location could be retrieved for url
KUrl("file:///media/6461-6562/DCIM/100CANON/IMG_3788.JPG")

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Jonatan]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #33 from Jonatan <[hidden email]> ---
Created attachment 79794
  --> https://bugs.kde.org/attachment.cgi?id=79794&action=edit
Another attempt, but still not working

I did another attempt, slightly different than the previous one. I don't like
the way the code is looking now (creating a parsesettings object, from which
info is taken to put into a parsesettings object, etc.), but I like even less
that it is still not working. I still get the message :
No location could be retrieved for url
KUrl("file:///media/6461-6562/DCIM/100CANON/IMG_3798.JPG")

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=314441

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rename settings and         |Rename settings and
                   |auto-rotation during import |auto-rotation during import
                   |ignored                     |ignored [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[CABPSOFT - Camilo Bohórquez]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #34 from CABPSOFT - Camilo Bohórquez <[hidden email]> ---
I confirm this bug in digikam 3.1.0 (openSUSE 12.3 - KDE 4.10.2 "release 1").

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Thomas Bettler-2]

https://bugs.kde.org/show_bug.cgi?id=314441

--- Comment #35 from Thomas Bettler <[hidden email]> ---
Still the same behaviour in digikam 3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel