[digikam] [Bug 313880] New: "Sort items" choice not respected in the import Dialog box

[Frédéric COIFFIER]

https://bugs.kde.org/show_bug.cgi?id=313880

            Bug ID: 313880
           Summary: "Sort items" choice not respected in the import Dialog
                    box
    Classification: Unclassified
           Product: digikam
           Version: 3.0.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Import
          Assignee: [hidden email]
          Reporter: [hidden email]

Tested with Digikam 3.0.0_rc

With the import Dialog box (for SDCard for example), the photos aren't sorted
accordingly to the "View > Sort items" choice.
By default, they are sorted "By name" even if "By date" is selected.
Selecting "By xxx" and next "By date" works. But the next time that the dialod
box will be opened, photos will still be sorted by name.

Reproducible: Always

Steps to Reproduce:
1. Open the Import Dialog box and select "View > Sort items > By date"
2. Close the dialog box
3. Reopen the import dialog box

Actual Results:  
Photos are sorted by name whereas "By date" is still selected.

Expected Results:  
Photos should be sorted accordingly to the "Sort items" choice

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dieter Rethmeyer]

https://bugs.kde.org/show_bug.cgi?id=313880

--- Comment #1 from Dieter Rethmeyer <[hidden email]> ---
This happens as well with the release version 3.0.0. It seems that digikam only
applies the changed sort order temporarily  - I expect digikam to save changes
in the sort order in the import dialog permantently as it had been up to
version 2.9 so I need not apply them each time I want to import photos.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=313880

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
The same happens with View->Item Sorting Order.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Romain Henriet]

https://bugs.kde.org/show_bug.cgi?id=313880

Romain Henriet <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Romain Henriet <[hidden email]> ---
I confirm this bug in Digikam 3.2.0.
Backward sort allows to quickly show last photos as their thumbnail is computed
first. With forward sort, you have to wait for all the photos to be read before
selecting the ones you have just taken (I don't always remember to format my
card after importing photos).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=313880

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|3.0.0                       |3.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=313880

--- Comment #4 from [hidden email] ---
Still present in 3.3.0!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=313880

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.2.0                       |3.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=313880

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Teemu Rytilahti <[hidden email]> ---
*** Bug 325925 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=313880

--- Comment #6 from Teemu Rytilahti <[hidden email]> ---
My comment from another bug, here for the reference:
I can confirm this. The settings are saved properly, but on load the change is
not being propagated properly. The relevant code is in
digikam/utilities/importui/main/importui.cpp's setupActions().

The naming of sorting functions/variables is a bit odd here, "Sorty by x" calls
view's slotSortImages(), but the current item is read from
ImportSettings::instance()->getImageSortOrder(). For ascending/descending the
call goes to slotSortImagesOrder() and the value is read from
getImageSorting(). Perhaps those are mixed or should there be separate calls
for setting the values on load? I'd suggest renaming those variables
nevertheless if possible. SortBy and SortOrder would be better names :-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=313880

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=313880

Islam Wazery <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ASSIGNED
                 CC|                            |[hidden email]
           Assignee|[hidden email]       |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=313880

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]           |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.