|
Hi all developers,
I registered digiKam to Coverity static analyse program dedicated for open-source project : As you already see my previous mail about traces generated with this tool by Red Hat team, i step the stage to use Coverity as default static code analyzer to detect programming errors.
I compiled and submitted a first tarball to SCAN web interface (500Mb of db file), and 30mns later i receive a mail to said that analyse is ready to be read through Coverity Connect Manager. Web interface is really nice to use and to parse important errors. It's really more suitable than an export to text list as Red Hat sent me previously. I recommend to all developers who want to improve source code to take an account to Coverity SCAN web interface. To register you, please send me your information : - user name - email : - given name - family name ... in fact all information to field in this page : http://scan.coverity.com/create_user.html
Later, when your account will be created, you will need to login to Connect Manager with your Username and a password sent to you in a private mail. You will be able to take a look to all trace generated by my scans loaded. I plan to process scan upload to Coverity server automatically each week end using a script, as other main Open-Source projects do...
I waiting your info to process registration Best Gilles Caulier _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
Marcel, I can see new errors in SCAN web interface, especially in AlbumManager, as this wonderful report for example:
for (QMap<int, DAlbum*>::const_iterator it = yAlbumMap.constBegin();
3149 it != yAlbumMap.constEnd(); ++it)
3150 {
3151 DAlbum* album = it.value();
3152 emit signalAlbumAboutToBeDeleted(album);
3153 d->allAlbumsIdHash.remove(album->globalID());
3154 emit signalAlbumDeleted(album);
41. freed_arg: "operator delete(void *)" frees "album".
3155 delete album;
CID 981494 (#2 of 2): Use after free (USE_AFTER_FREE)42. pass_freed_arg: Passing freed pointer "album" as an argument to function "Digikam::AlbumManager::signalAlbumHasBeenDeleted(void *)".
3156 emit signalAlbumHasBeenDeleted(album);
3157 }
I recommend to all be registered. SCAN interface is really a pleasure to use.
It's easy to understand report traces.
Gilles 2013/2/13 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Gilles Caulier-4
Hi Gilles,
Yes please add me to the list. > - user name aelfric > - email : [hidden email] > - given name Andrew > - family name Goodbody Thanks, Andrew On 13/02/13 13:34, Gilles Caulier wrote: > Hi all developers, > > I registered digiKam to Coverity static analyse program dedicated for > open-source project : > > http://scan.coverity.com/ > http://en.wikipedia.org/wiki/Coverity#Scan_.28Open_Source.29 > > As you already see my previous mail about traces generated with this > tool by Red Hat team, i step the stage to use Coverity as default static > code analyzer to detect programming errors. > > I compiled and submitted a first tarball to SCAN web interface (500Mb of > db file), and 30mns later i receive a mail to said that analyse is ready > to be read through Coverity Connect Manager. > > Web interface is really nice to use and to parse important errors. It's > really more suitable than an export to text list as Red Hat sent me > previously. > > I recommend to all developers who want to improve source code to take an > account to Coverity SCAN web interface. > > To register you, please send me your information : > > - user name > - email : > - given name > - family name > > ... in fact all information to field in this page : > http://scan.coverity.com/create_user.html > > Later, when your account will be created, you will need to login to > Connect Manager > > scan5.coverity.com:8080 <http://scan5.coverity.com:8080> > > with your Username and a password sent to you in a private mail. You > will be able to take a look to all trace generated by my scans loaded. > > I plan to process scan upload to Coverity server automatically each week > end using a script, as other main Open-Source projects do... > > I waiting your info to process registration > > Best > > Gilles Caulier > > > > > > _______________________________________________ > Digikam-devel mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-devel > Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
Done. Thanks to join the game... Gilles 2013/2/14 Andrew Goodbody <[hidden email]> Hi Gilles, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
Me too!
username: printesoi email: [hidden email] given name: Victor family name: Dodon
Thank you! Victor
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
Thanks Victor. Done... Gilles 2013/2/14 Victor Dodon <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
username: smit_mehta
email : [hidden email] name : smit
family name : mehta On a different note, are the projects on http://community.kde.org/Digikam/GSoC2013 finalised so that it can be moved to http://community.kde.org/Digikam/GSoC2013? If so, I shall move them by tomorrow. Also, we need to decide primary and secondary mentor for each project.
On Thu, Feb 14, 2013 at 4:31 PM, Gilles Caulier <[hidden email]> wrote:
Smit Mehta Junior year, B.Tech Computer Science and Engineering IIT Madras +91-9884996531 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
Thanks Smit. Done... Gilles 2013/2/14 smit <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Gilles Caulier-4
If you are not convinced by SCAN tool, i found 2 great infine loop bugs in trace :
364void ImportFilterModel::slotRowsAboutToBeRemoved(const QModelIndex& /*parent*/, int start, int end)
365{
366 QList<CamItemInfo> infos;
367
non_progress_update: Update "i++" makes no progress toward falsifying the loop condition "i > end".
CID 981140 (#1 of 1): Infinite loop (INFINITE_LOOP)loop_top: Top of the loop.
loop_condition: If "i > end" is initially true then it will remain true.
368 for (int i = start; i > end; i++)
369 {
370 infos << camItemInfo(index(i, 0));
loop_bottom: Bottom of the loop.
371 }
... 352void ImportFilterModel::slotRowsInserted(const QModelIndex& /*parent*/, int start, int end)
353{
354 QList<CamItemInfo> infos;
355
non_progress_update: Update "i++" makes no progress toward falsifying the loop condition "i > end".
CID 981139 (#1 of 1): Infinite loop (INFINITE_LOOP)loop_top: Top of the loop.
loop_condition: If "i > end" is initially true then it will remain true.
356 for (int i = start; i > end; i++)
357 {
358 infos << camItemInfo(index(i, 0));
loop_bottom: Bottom of the loop. 359 }
Gilles 2013/2/13 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
...another one very difficult to found for an human who review code :
877
CID 981482 (#1 of 1): Structurally dead code (UNREACHABLE)unreachable: Since the loop increment "++it;" is unreachable, the loop body will never execute more than once.
878 for (it = oldIds.find(info.id) ; (it != oldIds.end()) && (it.key() == info.id) ; ++it)
879 {
880 found = true;
881 break;
882 }
My fix : Gilles Caulier
2013/2/14 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Gilles Caulier-4
To all developers who want to take a look to reports, In SCAN web interface, go to Left Sidebar and select : - Issues/All Newly Detected : to show all traces generated from my last import. This include closed and not yet closed entries (636 files).
- Issues/ All Untriaged : to show pending issues which need to be reviewed (151 files) I already make a big triage including false alarms, real fixes, and 3rd party entries to ignore (as lib as PGF or lqr for ex).
I plan to generated automatically a new report all week-end using a script. Gilles Caulier
2013/2/13 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Gilles Caulier-4
Name(First name): Pankaj Family name(Last name): KumarOn Wed, Feb 13, 2013 at 7:04 PM, Gilles Caulier <[hidden email]> wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
2013/2/15 Pankaj Kumar <[hidden email]>
Done... Gilles Caulier _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
I would like to help as well
Username: harsh Email: [hidden email] Name: Harsh Family Name: Agrawal
On Fri, Feb 15, 2013 at 6:20 PM, Gilles Caulier <[hidden email]> wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
Done. Gilles 2013/2/15 harsh agrawal <[hidden email]> I would like to help as well _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
I would love to join as well
On Sat, Feb 16, 2013 at 12:51 PM, Gilles Caulier <[hidden email]> wrote:
Regards, Abhinav Badola _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel
Regards,
Abhinav Badola |
|
Done. I recommend you to be registered to Exiv2 project like me. I see some code from you appeared in SCAN reports... Gilles 2013/2/17 Abhinav Badola <[hidden email]> I would love to join as well _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Gilles Caulier-4
Done. Gilles 2013/2/17 Benjamin Girault <[hidden email]> Salut Gilles, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
In reply to this post by Gilles Caulier-4
username: vivo75
email : [hidden email] name : Francesco family name : Riosa Il 14/02/2013 13:27, Gilles Caulier ha scritto: > Thanks Smit. Done... > > Gilles > > > 2013/2/14 smit <[hidden email] <mailto:[hidden email]>> > > username: smit_mehta > email : [hidden email] <mailto:[hidden email]> > name : smit > family name : mehta > > On a different note, are the projects > on http://community.kde.org/Digikam/GSoC2013 finalised so that it > can be moved to http://community.kde.org/Digikam/GSoC2013? If so, I > shall move them by tomorrow. Also, we need to decide primary and > secondary mentor for each project. > > > On Thu, Feb 14, 2013 at 4:31 PM, Gilles Caulier > <[hidden email] <mailto:[hidden email]>> wrote: > > Thanks Victor. Done... > > Gilles > > > 2013/2/14 Victor Dodon <[hidden email] > <mailto:[hidden email]>> > > Me too! > > username: printesoi > email: [hidden email] <mailto:[hidden email]> > given name: Victor > family name: Dodon > > Thank you! > Victor > > > > I recommend to all developers who want to > improve source code to take an > account to Coverity SCAN web interface. > > To register you, please send me your information : > > - user name > - email : > - given name > - family name > > ... in fact all information to field in this page : > http://scan.coverity.com/__create_user.html > <http://scan.coverity.com/create_user.html> > > Later, when your account will be created, you > will need to login to > Connect Manager > > scan5.coverity.com:8080 > <http://scan5.coverity.com:8080> > <<a href="http://scan5.coverity.com:__8080">http://scan5.coverity.com:__8080 > <http://scan5.coverity.com:8080>> > > > with your Username and a password sent to you in > a private mail. You > will be able to take a look to all trace > generated by my scans loaded. > > I plan to process scan upload to Coverity server > automatically each week > end using a script, as other main Open-Source > projects do... > > I waiting your info to process registration > > Best > > Gilles Caulier > > > > _______________________________________________ > Digikam-devel mailing list > [hidden email] <mailto:[hidden email]> > https://mail.kde.org/mailman/listinfo/digikam-devel > > > > _______________________________________________ > Digikam-devel mailing list > [hidden email] <mailto:[hidden email]> > https://mail.kde.org/mailman/listinfo/digikam-devel > > > > > -- > Smit Mehta > Junior year, B.Tech > Computer Science and Engineering > IIT Madras > +91-9884996531 <tel:%2B91-9884996531> > > _______________________________________________ > Digikam-devel mailing list > [hidden email] <mailto:[hidden email]> > https://mail.kde.org/mailman/listinfo/digikam-devel > > > > > _______________________________________________ > Digikam-devel mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-devel > _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
Done Francesco... Gilles 2013/2/19 Francesco Riosa <[hidden email]> username: vivo75 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
| Free forum by Nabble | Edit this page |
