compilation problems with digikamimageplugins-0.9.1-RC1

[Dr. Ing. Dieter Jurzitza]

Dear listmembers,
in order to compile digikamimageplugins on my SuSE 9.3 system (gcc 3.3) I had
to revert a change in digikamimageplugins/border/imageeffect_border.cpp

In version 0.9.0 the line denoted
default:
        return(QString::null);

in the new version it has been changed to

default:
        return(QString());
the latter returning an error:
In file included from digikamimageplugin_border_la.all_cpp.cpp:3:
imageeffect_border.cpp: In member function `QString
DigikamBorderImagesPlugin::ImageEffect_Border::getBorderPath(int)':
imageeffect_border.cpp:639: error: syntax error before `;' token
make[4]: *** [digikamimageplugin_border_la.all_cpp.lo] Error 1

The same issue arises in digikamimageplugins/hotpixels/blackframelistview.cpp,
the same modification fixes it. Patch is attached.

To whom this might concern ...
Take care



Dieter Jurzitza

--
-----------------------------------------------------------

                               |
                                \
                 /\_/\           |
                | ~x~ |/-----\   /
                 \   /-       \_/
  ^^__   _        /  _  ____   /
 <°°__ \- \_/     |  |/    |  |
  ||  ||         _| _|    _| _|

if you really want to see the pictures above - use some font
with constant spacing like courier! :-)
-----------------------------------------------------------

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Gilles Caulier-4]

Le mardi 20 février 2007 21:43, Dieter Jurzitza a écrit :

> Dear listmembers,
> in order to compile digikamimageplugins on my SuSE 9.3 system (gcc 3.3) I
> had to revert a change in digikamimageplugins/border/imageeffect_border.cpp
>
> In version 0.9.0 the line denoted
> default:
> return(QString::null);
>
> in the new version it has been changed to
>
> default:
> return(QString());
> the latter returning an error:
> In file included from digikamimageplugin_border_la.all_cpp.cpp:3:
> imageeffect_border.cpp: In member function `QString
> DigikamBorderImagesPlugin::ImageEffect_Border::getBorderPath(int)':
> imageeffect_border.cpp:639: error: syntax error before `;' token
> make[4]: *** [digikamimageplugin_border_la.all_cpp.lo] Error 1
>
> The same issue arises in
> digikamimageplugins/hotpixels/blackframelistview.cpp, the same modification
> fixes it. Patch is attached.
>
> To whom this might concern ...
> Take care
>
>
>
> Dieter Jurzitza

I CC your message to Gerhard and Achim from devel mailling list. There have
fixed this coding style on svn recently...

Gilles
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

On Tuesday, 20. February 2007, Dieter Jurzitza wrote:

> Dear listmembers,
> in order to compile digikamimageplugins on my SuSE 9.3 system (gcc 3.3) I had
> to revert a change in digikamimageplugins/border/imageeffect_border.cpp
>
> In version 0.9.0 the line denoted
> default:
> return(QString::null);
>
> in the new version it has been changed to
>
> default:
> return(QString());
> the latter returning an error:
> In file included from digikamimageplugin_border_la.all_cpp.cpp:3:
> imageeffect_border.cpp: In member function `QString
> DigikamBorderImagesPlugin::ImageEffect_Border::getBorderPath(int)':
> imageeffect_border.cpp:639: error: syntax error before `;' token
> make[4]: *** [digikamimageplugin_border_la.all_cpp.lo] Error 1
>
> The same issue arises in digikamimageplugins/hotpixels/blackframelistview.cpp,
> the same modification fixes it. Patch is attached.
>
> To whom this might concern ...
> Take care

As I've no gcc 3.3 at hand.  Can you try in this old gcc version accepts

        return QString();

instead of

        return(QString());

Achim

>
>
>
> Dieter Jurzitza
>
> --
> -----------------------------------------------------------
>
>                                |
>                                 \
>                  /\_/\           |
>                 | ~x~ |/-----\   /
>                  \   /-       \_/
>   ^^__   _        /  _  ____   /
>  <°°__ \- \_/     |  |/    |  |
>   ||  ||         _| _|    _| _|
>
> if you really want to see the pictures above - use some font
> with constant spacing like courier! :-)
> -----------------------------------------------------------
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

[Dr. Ing. Dieter Jurzitza]

Dear Mr. Bohnet,
tested your suggestion and this variant indeed compiles with gcc 3.3. So, if
it is an option please modify

return(Qsting());

to

return Qstring();

Patch attached.
Take care, and many thanks for supplying such a great program. I was very
happy to notice that digikam-0.9.1 is much more stable with regard to
handling non-picture files like the ever-lasting DDISCVRY.DPS on my casio
camera that made digikam-0.9.0 crash every other moment it had to cope with
it.
Thank you!

Take care


Dieter Jurzitza


P.S.: and because I use my system 24h a day SuSE 9.3 keeps being a good
choice. So, if you need a tester with an old gcc version, let me know.

Am Mittwoch, 21. Februar 2007 12:02 schrieb Achim Bohnet:
> As I've no gcc 3.3 at hand.  Can you try in this old gcc version accepts
>
> return QString();
******

--
-----------------------------------------------------------

                               |
                                \
                 /\_/\           |
                | ~x~ |/-----\   /
                 \   /-       \_/
  ^^__   _        /  _  ____   /
 <°°__ \- \_/     |  |/    |  |
  ||  ||         _| _|    _| _|

if you really want to see the pictures above - use some font
with constant spacing like courier! :-)
-----------------------------------------------------------

_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users

On Wednesday, 21. February 2007, Dieter Jurzitza wrote:

> Dear Mr. Bohnet,
> tested your suggestion and this variant indeed compiles with gcc 3.3. So, if
> it is an option please modify
>
> return(Qsting());
>
> to
>
> return Qstring();
>
> Patch attached.

Thx. Applied.

> Take care, and many thanks for supplying such a great program. I was very
> happy to notice that digikam-0.9.1 is much more stable with regard to
> handling non-picture files like the ever-lasting DDISCVRY.DPS on my casio
> camera that made digikam-0.9.0 crash every other moment it had to cope with
> it.
> Thank you!
>
> Take care
>
>
> Dieter Jurzitza
>
>
> P.S.: and because I use my system 24h a day SuSE 9.3 keeps being a good
> choice. So, if you need a tester with an old gcc version, let me know.

Good idea.  Feel free to try to build from svn or beta* rc* tarballs
whenever you want and report build problems.

Achim

>
> Am Mittwoch, 21. Februar 2007 12:02 schrieb Achim Bohnet:
> > As I've no gcc 3.3 at hand.  Can you try in this old gcc version accepts
> >
> > return QString();
> ******
>
> --
> -----------------------------------------------------------
>
>                                |
>                                 \
>                  /\_/\           |
>                 | ~x~ |/-----\   /
>                  \   /-       \_/
>   ^^__   _        /  _  ____   /
>  <°°__ \- \_/     |  |/    |  |
>   ||  ||         _| _|    _| _|
>
> if you really want to see the pictures above - use some font
> with constant spacing like courier! :-)
> -----------------------------------------------------------
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-users mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-users