Review Request: Fix digikam for ARM builds

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request: Fix digikam for ARM builds

Bugzilla from rohangarg@kubuntu.org
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104289/

Review request for Digikam.
By Rohan Garg.

Description

In order for better performance, ARM uses float instead of double. Qt provides qreal which typedef's to double on non ARM arch's and float on ARM. This patch makes digikam compile on ARM.

Testing

Compiles fine on ARM after patch was applied

Diffs

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request: Fix digikam for ARM builds

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104289/

Where is the patch ?

Gilles Caulier

Note : it's better to open a file bugzilla instead here...

- Gilles


On March 15th, 2012, 3:39 p.m., Rohan Garg wrote:

Review request for Digikam.
By Rohan Garg.

Updated March 15, 2012, 3:39 p.m.

Description

In order for better performance, ARM uses float instead of double. Qt provides qreal which typedef's to double on non ARM arch's and float on ARM. This patch makes digikam compile on ARM.

Testing

Compiles fine on ARM after patch was applied

Diffs

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request: Fix digikam for ARM builds

Bugzilla from rohangarg@kubuntu.org
In reply to this post by Bugzilla from rohangarg@kubuntu.org
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104289/

Review request for Digikam.
By Rohan Garg.

Updated March 15, 2012, 7:45 p.m.

Changes

Reviewboard is weird, didn't upload my patch earlier ...

Description

In order for better performance, ARM uses float instead of double. Qt provides qreal which typedef's to double on non ARM arch's and float on ARM. This patch makes digikam compile on ARM.

Testing

Compiles fine on ARM after patch was applied

Diffs (updated)

  • libs/database/searchxml.h (5a5012d)
  • libs/database/searchxml.cpp (661bc5b)
  • libs/widgets/graphicsview/regionframeitem.cpp (c4fe767)
  • utilities/searchwindow/searchfields.cpp (68b98bd)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel