Review Request: Add "Color Effects" (solarize, vivid, neon, find edges) to the list of batch queue manager tools

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request: Add "Color Effects" (solarize, vivid, neon, find edges) to the list of batch queue manager tools

Alexander Dymo
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107252/

Review request for Digikam.
By Alexander Dymo.

Description

I'm post-processing my photos with Digikam and recently wanted to apply Vivid color filter with batch queue manager. Found that it's not yet possible, so... here's the patch :)

Testing

I've tested it on my Honeymoon photos, so at least you can trust me it doesn't eat your data:) I've tested manually both color effects tool and batch queue manager filter. There should be no changes to color effects tool behavior.

Diffs

  • CMakeLists.txt (1e7a255)
  • imageplugins/filters/colorfxtool.h (07d1e3a)
  • imageplugins/filters/colorfxtool.cpp (10a3d67)
  • libs/dimg/filters/fx/colorfxfilter.h (2cbd6cc)
  • libs/dimg/filters/fx/colorfxfilter.cpp (ee8dd3f)
  • libs/dimg/filters/fx/colorfxsettings.h (PRE-CREATION)
  • libs/dimg/filters/fx/colorfxsettings.cpp (PRE-CREATION)
  • utilities/queuemanager/CMakeLists.txt (8bc505d)
  • utilities/queuemanager/basetools/filters/colorfx.h (PRE-CREATION)
  • utilities/queuemanager/basetools/filters/colorfx.cpp (PRE-CREATION)
  • utilities/queuemanager/manager/batchtoolsmanager.cpp (0f5ef8c)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request: Add "Color Effects" (solarize, vivid, neon, find edges) to the list of batch queue manager tools

Gilles Caulier-4
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107252/

Thanks to contribute. I will review your patch asap to including in next 3.0.0-rc...

Gilles Caulier

- Gilles


On November 8th, 2012, 2:07 p.m., Alexander Dymo wrote:

Review request for Digikam.
By Alexander Dymo.

Updated Nov. 8, 2012, 2:07 p.m.

Description

I'm post-processing my photos with Digikam and recently wanted to apply Vivid color filter with batch queue manager. Found that it's not yet possible, so... here's the patch :)

Testing

I've tested it on my Honeymoon photos, so at least you can trust me it doesn't eat your data:) I've tested manually both color effects tool and batch queue manager filter. There should be no changes to color effects tool behavior.

Diffs

  • CMakeLists.txt (1e7a255)
  • imageplugins/filters/colorfxtool.h (07d1e3a)
  • imageplugins/filters/colorfxtool.cpp (10a3d67)
  • libs/dimg/filters/fx/colorfxfilter.h (2cbd6cc)
  • libs/dimg/filters/fx/colorfxfilter.cpp (ee8dd3f)
  • libs/dimg/filters/fx/colorfxsettings.h (PRE-CREATION)
  • libs/dimg/filters/fx/colorfxsettings.cpp (PRE-CREATION)
  • utilities/queuemanager/CMakeLists.txt (8bc505d)
  • utilities/queuemanager/basetools/filters/colorfx.h (PRE-CREATION)
  • utilities/queuemanager/basetools/filters/colorfx.cpp (PRE-CREATION)
  • utilities/queuemanager/manager/batchtoolsmanager.cpp (0f5ef8c)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Review Request: Add "Color Effects" (solarize, vivid, neon, find edges) to the list of batch queue manager tools

Gilles Caulier-4
In reply to this post by Alexander Dymo
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107252/

Alexander,

I review you code, and all compile fine. Code is right for me. Feel free to commit your code into digiKam from git/master

NOTE: don't forget to patch imageplugins/TODO file about colorfx tool status.

Thanks in advance

Gilles Caulier

- Gilles


On November 8th, 2012, 2:07 p.m., Alexander Dymo wrote:

Review request for Digikam.
By Alexander Dymo.

Updated Nov. 8, 2012, 2:07 p.m.

Description

I'm post-processing my photos with Digikam and recently wanted to apply Vivid color filter with batch queue manager. Found that it's not yet possible, so... here's the patch :)

Testing

I've tested it on my Honeymoon photos, so at least you can trust me it doesn't eat your data:) I've tested manually both color effects tool and batch queue manager filter. There should be no changes to color effects tool behavior.

Diffs

  • CMakeLists.txt (1e7a255)
  • imageplugins/filters/colorfxtool.h (07d1e3a)
  • imageplugins/filters/colorfxtool.cpp (10a3d67)
  • libs/dimg/filters/fx/colorfxfilter.h (2cbd6cc)
  • libs/dimg/filters/fx/colorfxfilter.cpp (ee8dd3f)
  • libs/dimg/filters/fx/colorfxsettings.h (PRE-CREATION)
  • libs/dimg/filters/fx/colorfxsettings.cpp (PRE-CREATION)
  • utilities/queuemanager/CMakeLists.txt (8bc505d)
  • utilities/queuemanager/basetools/filters/colorfx.h (PRE-CREATION)
  • utilities/queuemanager/basetools/filters/colorfx.cpp (PRE-CREATION)
  • utilities/queuemanager/manager/batchtoolsmanager.cpp (0f5ef8c)

View Diff


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel