Review Request 126833: opencv 3.1 support for libkface

[Xuetian Weng]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126833/

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Repository: libkface

Description

Disclaimer: I have not much knowledge of this part of code, just take this commit as porting reference:
https://github.com/Itseez/opencv_contrib/commit/9ff3192ea567b027e5514d1e025b3e6b3ce34643

Testing

I only test compilation against 3.1.

Diffs

• src/recognition-opencv-lbph/facerec_borrowed.h (27ad77a)
• src/recognition-opencv-lbph/facerec_borrowed.cpp (748691e)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas Sturmlechner]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126833/

[not a maintainer]
I just wanted to confirm build failure with opencv-3.1.0, which is fixed by that RR, at the same time also builds fine with opencv-3.0.0.

- Andreas Sturmlechner

On January 21st, 2016, 12:49 a.m. UTC, Xuetian Weng wrote:

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Updated Jan. 21, 2016, 12:49 a.m.

Repository: libkface

Description

Disclaimer: I have not much knowledge of this part of code, just take this commit as porting reference:
https://github.com/Itseez/opencv_contrib/commit/9ff3192ea567b027e5514d1e025b3e6b3ce34643

Testing

I only test compilation against 3.1.

Diffs

• src/recognition-opencv-lbph/facerec_borrowed.h (27ad77a)
• src/recognition-opencv-lbph/facerec_borrowed.cpp (748691e)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas Sturmlechner]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126833/

On March 6th, 2016, 9:53 a.m. UTC, Andreas Sturmlechner wrote:

[not a maintainer]
I just wanted to confirm build failure with opencv-3.1.0, which is fixed by that RR, at the same time also builds fine with opencv-3.0.0.

any reason not to merge this patch?

- Andreas

On January 21st, 2016, 12:49 a.m. UTC, Xuetian Weng wrote:

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Updated Jan. 21, 2016, 12:49 a.m.

Repository: libkface

Description

Disclaimer: I have not much knowledge of this part of code, just take this commit as porting reference:
https://github.com/Itseez/opencv_contrib/commit/9ff3192ea567b027e5514d1e025b3e6b3ce34643

Testing

I only test compilation against 3.1.

Diffs

• src/recognition-opencv-lbph/facerec_borrowed.h (27ad77a)
• src/recognition-opencv-lbph/facerec_borrowed.cpp (748691e)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas Sturmlechner]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126833/

Xuetian, it looks like libkface currently has no maintainer: https://mail.kde.org/pipermail/release-team/2016-July/009641.html
Do you have commit access to KDE repositories?

- Andreas Sturmlechner

On January 21st, 2016, 12:49 a.m. UTC, Xuetian Weng wrote:

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Updated Jan. 21, 2016, 12:49 a.m.

Repository: libkface

Description

Disclaimer: I have not much knowledge of this part of code, just take this commit as porting reference:
https://github.com/Itseez/opencv_contrib/commit/9ff3192ea567b027e5514d1e025b3e6b3ce34643

Testing

I only test compilation against 3.1.

Diffs

• src/recognition-opencv-lbph/facerec_borrowed.h (27ad77a)
• src/recognition-opencv-lbph/facerec_borrowed.cpp (748691e)

View Diff

[Xuetian Weng]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126833/

This change has been marked as submitted.

Review request for Digikam and Gilles Caulier.

By Xuetian Weng.

Updated Nov. 6, 2016, 8:28 p.m.

Changes

Submitted with commit ec6e82328cac37c9d59b49245b18c3f0abee4d8f by Andreas Sturmlechner on behalf of Xuetian Weng to branch master.

Repository: libkface

Description

Disclaimer: I have not much knowledge of this part of code, just take this commit as porting reference:
https://github.com/Itseez/opencv_contrib/commit/9ff3192ea567b027e5514d1e025b3e6b3ce34643

Testing

I only test compilation against 3.1.

Diffs

• src/recognition-opencv-lbph/facerec_borrowed.h (27ad77a)
• src/recognition-opencv-lbph/facerec_borrowed.cpp (748691e)

View Diff