Review Request 125381: Fix OpenCV finding for v3 with disabled ENABLE_OPENCV3

[Dāvis Mosāns]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

Review request for Digikam.

By Dāvis Mosāns.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

Ship it!

Ship It!

- Gilles Caulier

On September 24th, 2015, 5:37 p.m. UTC, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Sept. 24, 2015, 5:37 p.m.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

On September 24th, 2015, 8:32 p.m. UTC, Gilles Caulier wrote:

Ship It!

Your patch is not fine. OpenCV2 and OpenCV3 required components are not the same  (renamed and moved between packages).
Enabling OpenCV3 support if OpenCV 2 is expected cannot be done as well. This is why these 2 rules exist and are different in cmake code.

- Gilles

On September 24th, 2015, 5:37 p.m. UTC, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Sept. 24, 2015, 5:37 p.m.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

On September 24th, 2015, 8:32 p.m. UTC, Gilles Caulier wrote:

Ship It!

On September 24th, 2015, 8:44 p.m. UTC, Gilles Caulier wrote:

Your patch is not fine. OpenCV2 and OpenCV3 required components are not the same  (renamed and moved between packages).
Enabling OpenCV3 support if OpenCV 2 is expected cannot be done as well. This is why these 2 rules exist and are different in cmake code.

Note : libkface has also the same rules (frameworks and master)

- Gilles

On September 24th, 2015, 5:37 p.m. UTC, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Sept. 24, 2015, 5:37 p.m.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dāvis Mosāns]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

Review request for Digikam.

By Dāvis Mosāns.

Updated Sept. 24, 2015, 11:58 p.m.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs (updated)

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dāvis Mosāns]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

On septembris 24th, 2015, 11:32 p.m. EEST, Gilles Caulier wrote:

Ship It!

On septembris 24th, 2015, 11:44 p.m. EEST, Gilles Caulier wrote:

Your patch is not fine. OpenCV2 and OpenCV3 required components are not the same  (renamed and moved between packages).
Enabling OpenCV3 support if OpenCV 2 is expected cannot be done as well. This is why these 2 rules exist and are different in cmake code.

On septembris 24th, 2015, 11:45 p.m. EEST, Gilles Caulier wrote:

Note : libkface has also the same rules (frameworks and master)

what about this? idea is that if I have OpenCV v3 and ENABLE_OPENCV3 isn't set then it still should use v3. I think this now achieves it.

- Dāvis

On septembris 24th, 2015, 11:58 p.m. EEST, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Sept. 24, 2015, 11:58 p.m.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Albert Astals Cid]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

Patch doesn't apply anymore to master branch.

- Albert Astals Cid

On September 24th, 2015, 8:58 p.m. UTC, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Sept. 24, 2015, 8:58 p.m.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff

[Andreas Sturmlechner]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125381/

On February 25th, 2017, 11:07 p.m. UTC, Albert Astals Cid wrote:

Patch doesn't apply anymore to master branch.

This seems obsolete, similar code went into digikam long ago.

- Andreas

On September 24th, 2015, 8:58 p.m. UTC, Dāvis Mosāns wrote:

Review request for Digikam.

By Dāvis Mosāns.

Updated Sept. 24, 2015, 8:58 p.m.

Repository: digikam

Description

When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
-- Great, found OpenCV on the first try.
-- OpenCV Root directory is: /usr/share/opencv
-- OpenCV: Found version 3.0.0 (required: 2.4.9)
-- OpenCV headers: /usr/include/opencv;/usr/include
-- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
-- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. Enabled ENABLE_OPENCV3
CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
   libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
Call Stack (most recent call first):
   CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
For this case just enable ENABLE_OPENCV3

Testing

It finds OpenCV

Diffs

• CMakeLists.txt (94d5855332f1a4ecf3f7bd5117dff7d56810ff31)

View Diff