Review Request 109453: Patch to enable digikam to write face tags into xmp metadata Ver2 + tag update when Images are rotated [Experimental]

[Veaceslav Munteanu]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109453/

Review request for Digikam, Gilles Caulier and Marcel Wiesweg.

By Veaceslav Munteanu.

Description

This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/

Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.

I'm still working on it, any feedback about implementation is welcome.

It's not the last version, still have few issues to fix(see testing below).

Testing

So far, metadata write works ok.

And rotation from image preview updates all tags from database and also updates face rectangles.

What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.

What can be tested:

1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.

Diffs

• digikam/fileaction/fileactionmngr.h (836bc17)
• digikam/fileaction/fileactionmngr.cpp (83372c2)
• digikam/fileaction/fileactionmngr_p.h (d0e418b)
• digikam/fileaction/fileactionmngr_p.cpp (c09ce30)
• digikam/fileaction/fileworkeriface.h (a04b71e)
• digikam/fileaction/fileworkeriface.cpp (76842eb)
• digikam/fileaction/metadatahub.cpp (ea74590)
• digikam/views/imagepreviewview.h (95102ed)
• digikam/views/imagepreviewview.cpp (65b92dd)
• libs/database/core/tagregion.h (436960f)
• libs/database/core/tagregion.cpp (4fda6af)
• libs/dmetadata/metadatasettingscontainer.h (02d35d2)
• libs/dmetadata/metadatasettingscontainer.cpp (3e6cd93)
• utilities/facemanagement/facegroup.h (2f0a357)
• utilities/facemanagement/facegroup.cpp (df9dec4)
• utilities/setup/setupmetadata.cpp (f73870c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109453/

Good work.

I propose to create a dedicated branch of digiKam based on current git/master including your code.

Gilles Caulier

- Gilles

On March 12th, 2013, 4:13 p.m. UTC, Veaceslav Munteanu wrote:

Review request for Digikam, Gilles Caulier and Marcel Wiesweg.

By Veaceslav Munteanu.

Updated March 12, 2013, 4:13 p.m.

Description

This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/

Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.

I'm still working on it, any feedback about implementation is welcome.

It's not the last version, still have few issues to fix(see testing below).

Testing

So far, metadata write works ok.

And rotation from image preview updates all tags from database and also updates face rectangles.

What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.

What can be tested:

1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.

Diffs

• digikam/fileaction/fileactionmngr.h (836bc17)
• digikam/fileaction/fileactionmngr.cpp (83372c2)
• digikam/fileaction/fileactionmngr_p.h (d0e418b)
• digikam/fileaction/fileactionmngr_p.cpp (c09ce30)
• digikam/fileaction/fileworkeriface.h (a04b71e)
• digikam/fileaction/fileworkeriface.cpp (76842eb)
• digikam/fileaction/metadatahub.cpp (ea74590)
• digikam/views/imagepreviewview.h (95102ed)
• digikam/views/imagepreviewview.cpp (65b92dd)
• libs/database/core/tagregion.h (436960f)
• libs/database/core/tagregion.cpp (4fda6af)
• libs/dmetadata/metadatasettingscontainer.h (02d35d2)
• libs/dmetadata/metadatasettingscontainer.cpp (3e6cd93)
• utilities/facemanagement/facegroup.h (2f0a357)
• utilities/facemanagement/facegroup.cpp (df9dec4)
• utilities/setup/setupmetadata.cpp (f73870c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109453/

- FaceGroup::applyItemGeometryChanges() actually serves a purpose but I agree I did not comment it: The user can move and resize face rectangles by dragging. These changes need to be applied, they are applied by this method when a new image is set. Quite naturally, rotation can introduce changes which are then detected.
This is part of the same problem like the one for which you added the edit lock. In the end, rotation can occur asynchronously and from different places, so even the edit lock may not be secure.
I am not sure about the right solution as well and need to think a bit.
- the signalTransform signal in FileWorker is for debugging only? not quite sure I didnt overlook something

- Marcel

On March 12th, 2013, 4:13 p.m. UTC, Veaceslav Munteanu wrote:

Review request for Digikam, Gilles Caulier and Marcel Wiesweg.

By Veaceslav Munteanu.

Updated March 12, 2013, 4:13 p.m.

Description

This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/

Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.

I'm still working on it, any feedback about implementation is welcome.

It's not the last version, still have few issues to fix(see testing below).

Testing

So far, metadata write works ok.

And rotation from image preview updates all tags from database and also updates face rectangles.

What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.

What can be tested:

1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.

Diffs

• digikam/fileaction/fileactionmngr.h (836bc17)
• digikam/fileaction/fileactionmngr.cpp (83372c2)
• digikam/fileaction/fileactionmngr_p.h (d0e418b)
• digikam/fileaction/fileactionmngr_p.cpp (c09ce30)
• digikam/fileaction/fileworkeriface.h (a04b71e)
• digikam/fileaction/fileworkeriface.cpp (76842eb)
• digikam/fileaction/metadatahub.cpp (ea74590)
• digikam/views/imagepreviewview.h (95102ed)
• digikam/views/imagepreviewview.cpp (65b92dd)
• libs/database/core/tagregion.h (436960f)
• libs/database/core/tagregion.cpp (4fda6af)
• libs/dmetadata/metadatasettingscontainer.h (02d35d2)
• libs/dmetadata/metadatasettingscontainer.cpp (3e6cd93)
• utilities/facemanagement/facegroup.h (2f0a357)
• utilities/facemanagement/facegroup.cpp (df9dec4)
• utilities/setup/setupmetadata.cpp (f73870c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109453/

On March 13th, 2013, 6:31 p.m. UTC, Marcel Wiesweg wrote:

- FaceGroup::applyItemGeometryChanges() actually serves a purpose but I agree I did not comment it: The user can move and resize face rectangles by dragging. These changes need to be applied, they are applied by this method when a new image is set. Quite naturally, rotation can introduce changes which are then detected.
This is part of the same problem like the one for which you added the edit lock. In the end, rotation can occur asynchronously and from different places, so even the edit lock may not be secure.
I am not sure about the right solution as well and need to think a bit.
- the signalTransform signal in FileWorker is for debugging only? not quite sure I didnt overlook something

Marcel,
signalTransform actually unlock the edit lock... I saw that workeriface is designed to run in parallel, but offers a option to connect to all workers and listen for signals. Even if lock is set and works, sometimes I still have garbage tags if fast-hover the photo... still looking into it...

about applyGeometryChanges(), this one is very difficult to dodge...especially when I can't find what rotates(in the bad way) the loaded tags...

Ok.. it's time to load another one hundred of kDebug() lines :)

- Veaceslav

On March 12th, 2013, 4:13 p.m. UTC, Veaceslav Munteanu wrote:

Review request for Digikam, Gilles Caulier and Marcel Wiesweg.

By Veaceslav Munteanu.

Updated March 12, 2013, 4:13 p.m.

Description

This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/

Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.

I'm still working on it, any feedback about implementation is welcome.

It's not the last version, still have few issues to fix(see testing below).

Testing

So far, metadata write works ok.

And rotation from image preview updates all tags from database and also updates face rectangles.

What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.

What can be tested:

1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.

Diffs

• digikam/fileaction/fileactionmngr.h (836bc17)
• digikam/fileaction/fileactionmngr.cpp (83372c2)
• digikam/fileaction/fileactionmngr_p.h (d0e418b)
• digikam/fileaction/fileactionmngr_p.cpp (c09ce30)
• digikam/fileaction/fileworkeriface.h (a04b71e)
• digikam/fileaction/fileworkeriface.cpp (76842eb)
• digikam/fileaction/metadatahub.cpp (ea74590)
• digikam/views/imagepreviewview.h (95102ed)
• digikam/views/imagepreviewview.cpp (65b92dd)
• libs/database/core/tagregion.h (436960f)
• libs/database/core/tagregion.cpp (4fda6af)
• libs/dmetadata/metadatasettingscontainer.h (02d35d2)
• libs/dmetadata/metadatasettingscontainer.cpp (3e6cd93)
• utilities/facemanagement/facegroup.h (2f0a357)
• utilities/facemanagement/facegroup.cpp (df9dec4)
• utilities/setup/setupmetadata.cpp (f73870c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109453/

Ship it!

Ship It!

- Gilles Caulier

On March 12th, 2013, 4:13 p.m. UTC, Veaceslav Munteanu wrote:

Review request for Digikam, Gilles Caulier and Marcel Wiesweg.

By Veaceslav Munteanu.

Updated March 12, 2013, 4:13 p.m.

Repository: digikam

Description

This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/

Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.

I'm still working on it, any feedback about implementation is welcome.

It's not the last version, still have few issues to fix(see testing below).

Testing

So far, metadata write works ok.

And rotation from image preview updates all tags from database and also updates face rectangles.

What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.

What can be tested:

1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.

Diffs

• digikam/fileaction/fileactionmngr.h (836bc17)
• digikam/fileaction/fileactionmngr.cpp (83372c2)
• digikam/fileaction/fileactionmngr_p.h (d0e418b)
• digikam/fileaction/fileactionmngr_p.cpp (c09ce30)
• digikam/fileaction/fileworkeriface.h (a04b71e)
• digikam/fileaction/fileworkeriface.cpp (76842eb)
• digikam/fileaction/metadatahub.cpp (ea74590)
• digikam/views/imagepreviewview.h (95102ed)
• digikam/views/imagepreviewview.cpp (65b92dd)
• libs/database/core/tagregion.h (436960f)
• libs/database/core/tagregion.cpp (4fda6af)
• libs/dmetadata/metadatasettingscontainer.h (02d35d2)
• libs/dmetadata/metadatasettingscontainer.cpp (3e6cd93)
• utilities/facemanagement/facegroup.h (2f0a357)
• utilities/facemanagement/facegroup.cpp (df9dec4)
• utilities/setup/setupmetadata.cpp (f73870c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109453/

This change has been marked as submitted.

Review request for Digikam, Gilles Caulier and Marcel Wiesweg.

By Veaceslav Munteanu.

Updated April 7, 2015, 12:35 p.m.

Repository: digikam

Description

This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/

Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.

I'm still working on it, any feedback about implementation is welcome.

It's not the last version, still have few issues to fix(see testing below).

Testing

So far, metadata write works ok.

And rotation from image preview updates all tags from database and also updates face rectangles.

What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.

What can be tested:

1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.

Diffs

• digikam/fileaction/fileactionmngr.h (836bc17)
• digikam/fileaction/fileactionmngr.cpp (83372c2)
• digikam/fileaction/fileactionmngr_p.h (d0e418b)
• digikam/fileaction/fileactionmngr_p.cpp (c09ce30)
• digikam/fileaction/fileworkeriface.h (a04b71e)
• digikam/fileaction/fileworkeriface.cpp (76842eb)
• digikam/fileaction/metadatahub.cpp (ea74590)
• digikam/views/imagepreviewview.h (95102ed)
• digikam/views/imagepreviewview.cpp (65b92dd)
• libs/database/core/tagregion.h (436960f)
• libs/database/core/tagregion.cpp (4fda6af)
• libs/dmetadata/metadatasettingscontainer.h (02d35d2)
• libs/dmetadata/metadatasettingscontainer.cpp (3e6cd93)
• utilities/facemanagement/facegroup.h (2f0a357)
• utilities/facemanagement/facegroup.cpp (df9dec4)
• utilities/setup/setupmetadata.cpp (f73870c)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel