Review Request 109017: Add Olympus' LensModel to Lensfun integration

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

Review request for Digikam.

By Teemu Rytilahti.

Description

This patch adds support for Olympus lenses for Lensfun by adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 2:09 p.m.

Changes

Clarifying that the change is to DMetadata and also allows one to see the used lens in metadata bar.

Summary (updated)

Add Olympus' LensModel to DMetadata

Description (updated)

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the metadata bar. More information available on bug entry.

Testing (updated)

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in metadata bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 2:13 p.m.

Changes

s/metadata/properties/

Description (updated)

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing (updated)

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

Ping?

- Teemu

On February 19th, 2013, 2:13 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 2:13 p.m.

Description

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

Ship it!

Ship It!

- Gilles

On February 19th, 2013, 2:13 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 2:13 p.m.

Description

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

I responded to this entry:

https://git.reviewboard.kde.org/r/109048/

... and i never see this one.

109048 can be considerated as obsolete and replaced by this one ?

- Gilles

On February 19th, 2013, 2:13 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated Feb. 19, 2013, 2:13 p.m.

Description

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

Review request for Digikam.

By Teemu Rytilahti.

Updated March 21, 2013, 2:11 p.m.

Description

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

File Attachments (updated)

• Properties bar showing the lens information

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

On March 21st, 2013, 4:29 a.m. UTC, Gilles Caulier wrote:

I responded to this entry:

https://git.reviewboard.kde.org/r/109048/

... and i never see this one.

109048 can be considerated as obsolete and replaced by this one ?

No, these two are completely separate patches. This patch adds support to read the LensModel from Olympus-specific tag (also adds commented out version, in case it is needed at some point). Before this patch the properties of the image didn't show the lens at all for me, nor was it handled to Lensfun plugin either. (see attached screenshot)

The "encrypted" part of LensType was fixed earlier this year, but it gives different input (and thus I reverted to use LensModel, as it is similar to what Lensfun uses in my case at least). Example output from exiv2:
[tpr@tuli epl]$ exiv2 -pa P2211096.ORF|grep LensTy
Exif.OlympusEq.LensType                      Byte        6  Olympus M.Zuiko Digital 14-42mm F3.5-5.6 II
[tpr@tuli epl]$ exiv2 -pa P2211096.ORF|grep LensModel
Exif.OlympusEq.LensModel                     Ascii      32  OLYMPUS M.14-42mm F3.5-5.6 II

- Teemu

On March 21st, 2013, 2:11 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated March 21, 2013, 2:11 p.m.

Description

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

File Attachments

• Properties bar showing the lens information

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

Patch is fine for me and is ready to be commit to git/master.

This will close this bugzilla entry : #311295

Gilles Caulier

- Gilles

On March 21st, 2013, 2:11 p.m. UTC, Teemu Rytilahti wrote:

Review request for Digikam.

By Teemu Rytilahti.

Updated March 21, 2013, 2:11 p.m.

Description

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

File Attachments

• Properties bar showing the lens information

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109017/

This change has been marked as submitted.

Review request for Digikam.

By Teemu Rytilahti.

Updated March 21, 2013, 4:04 p.m.

Description

This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.

Testing

Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.

Bugs: 311295

Diffs

• libs/dmetadata/dmetadata.cpp (8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)

View Diff

File Attachments

• Properties bar showing the lens information

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel