Review Request 108574: Turned on sorting by pixel size and added sorting by aspect ratio

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Review request for Digikam.

By Stephen Toothman.

Description

I turned on sorting by pixel size (width * height) an added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

- Stephen

On January 24th, 2013, 3 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3 p.m.

Description

I turned on sorting by pixel size (width * height) an added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3:04 p.m.

Description (updated)

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Stephen,

Your patch is against digiKam 2.5.0. It must be done against git/master code (future 3.0.0). A lots of code have changed since 2.5.0, and your patch cannot be applied to current implementation and tested.

Please, make a new patch against git/master...

Gilles Caulier

- Gilles

On January 24th, 2013, 3:04 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3:04 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

The diff seems to include all affected files as complete new files, instead of displaying only changes?

- Marcel

On January 24th, 2013, 3:04 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3:04 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

The diff seems to include all affected files as complete new files, instead of displaying only changes?

- Marcel

On January 24th, 2013, 3:04 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3:04 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

The diff seems to include all affected files as complete new files, instead of displaying only changes?

- Marcel

On January 24th, 2013, 3:04 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3:04 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

The diff seems to include all affected files as complete new files, instead of displaying only changes?

- Marcel

On January 24th, 2013, 3:04 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3:04 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Right Marcel, the diff is wrong...

Stephen, please checkout digiKam from git/master and make a patch against current implmentation. It's important for us to review and validate your code...

Thanks in advance

Gilles Caulier

- Gilles

On January 24th, 2013, 3:04 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 24, 2013, 3:04 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 25, 2013, 5:30 p.m.

Changes

Added my original diff I used to add the changes to the git/master branch

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

File Attachments (updated)

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

On January 25th, 2013, 10:24 a.m. UTC, Gilles Caulier wrote:

Right Marcel, the diff is wrong...

Stephen, please checkout digiKam from git/master and make a patch against current implmentation. It's important for us to review and validate your code...

Thanks in advance

Gilles Caulier

I will try to create the diff again.  It is created against the latest version, 3.0.0-rc.  I tried attaching just the local diff I made to port the changes over to the the git branch, but it did not like that.

- Stephen

On January 25th, 2013, 5:30 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 25, 2013, 5:30 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• core/digikam/items/digikamimagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegate.cpp (PRE-CREATION)
• core/digikam/items/imagedelegatepriv.h (PRE-CREATION)
• core/digikam/main/digikamapp.cpp (PRE-CREATION)
• core/digikam/utils/albumsettings.h (PRE-CREATION)
• core/digikam/utils/albumsettings.cpp (PRE-CREATION)
• core/digikam/utils/tooltipfiller.h (PRE-CREATION)
• core/digikam/utils/tooltipfiller.cpp (PRE-CREATION)
• core/libs/models/imagesortsettings.h (PRE-CREATION)
• core/libs/models/imagesortsettings.cpp (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.h (PRE-CREATION)
• core/libs/widgets/itemview/itemviewimagedelegate.cpp (PRE-CREATION)
• core/utilities/setup/setupalbumview.cpp (PRE-CREATION)
• core/utilities/setup/setuptooltip.cpp (PRE-CREATION)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Changes

Ok here is a new diff that I think is right.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs (updated)

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Stephen,

I review your patch, apply it to current git/master implementation, and tested.

Where options are available in Setup to show aspect ratio properly on thumbnails view and tool-tips, i cannot see any option in Filters tab from Right side-bar to sort items by aspect ratio.

As you said in this entry description, this patch much add this feature... Or i forget something ?

http://www.flickr.com/photos/digikam/8425632063/sizes/o/in/photostream/

Note : if you use text Filter to sort items from icon view by aspect ratio, well where is the option in drop-down list available on the right of search text field ?

Another important point, the capability to find items by aspect ratio in Advanced Search dialog, through "Picture Properties" section. Here, again, no option are available. To be homogeneous, search by aspect ratio must be available too...

In all case, these entries from bugzilla must be closed when your patch will be ap^plied to git/master (after 3.0.0 release planed on 6 February):

https://bugs.kde.org/show_bug.cgi?id=121313

https://bugs.kde.org/show_bug.cgi?id=224549

Gilles Caulier

- Gilles

On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

I see also that you have add View/Sort Images/By Aspect Ratio, which is a good point...

Gilles Caulier

- Gilles

On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

On January 29th, 2013, 9:32 a.m. UTC, Gilles Caulier wrote:

Stephen,

I review your patch, apply it to current git/master implementation, and tested.

Where options are available in Setup to show aspect ratio properly on thumbnails view and tool-tips, i cannot see any option in Filters tab from Right side-bar to sort items by aspect ratio.

As you said in this entry description, this patch much add this feature... Or i forget something ?

http://www.flickr.com/photos/digikam/8425632063/sizes/o/in/photostream/

Note : if you use text Filter to sort items from icon view by aspect ratio, well where is the option in drop-down list available on the right of search text field ?

Another important point, the capability to find items by aspect ratio in Advanced Search dialog, through "Picture Properties" section. Here, again, no option are available. To be homogeneous, search by aspect ratio must be available too...

In all case, these entries from bugzilla must be closed when your patch will be ap^plied to git/master (after 3.0.0 release planed on 6 February):

https://bugs.kde.org/show_bug.cgi?id=121313

https://bugs.kde.org/show_bug.cgi?id=224549

Gilles Caulier

I will look at these two items later this week.  I should have something by Friday.  Basically I searched through the code following the sort and tool tips.

Hehehe, bug 224549 is actually mine.  I finally found time to look at it myself and code a fix.  :-)

- Stephen

On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Thanks Stephen to contribute. I waiting your new patch for future integration into 3.1.0 release.

Gilles Caulier

- Gilles

On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

Stephen,

Any progress here ?

Gilles Caulier

- Gilles

On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

On February 4th, 2013, 5:29 p.m. UTC, Gilles Caulier wrote:

Stephen,

Any progress here ?

Gilles Caulier

I looked at the right hand side text filter and did not see any place for sorting options.  I also looked through the code for it and did not find it.  I am still working on the search part.  It has me at a bit of a loss trying to find how it fits together.  But as near as I can tell it does a search through the database using sql.  Since this is not a field in the DB I have to think about how to query it and get what I want.  And that is the part that has me confused because I can not find where the search query is stored.

Steve

- Stephen

On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

Am Montag, 4. Februar 2013, 18:38:53 schrieb Stephen Toothman:

> > On Feb. 4, 2013, 5:29 p.m., Gilles Caulier wrote:
> > > Stephen,
> > >
> > > Any progress here ?
> > >
> > > Gilles Caulier
>
> I looked at the right hand side text filter and did not see any place for
> sorting options.  I also looked through the code for it and did not find
> it.  I am still working on the search part.  It has me at a bit of a loss
> trying to find how it fits together.  But as near as I can tell it does a
> search through the database using sql.  Since this is not a field in the DB
> I have to think about how to query it and get what I want.  And that is the
> part that has me confused because I can not find where the search query is
> stored.

Regarding the backend, have a look at libs/database/imagequerybuilder.cpp
There is already "pageorientation" and "pixels" implemented which provide
similar queries.

For the UI, you need to build the basic UI in
utilities/searchwindow/searchfields.cpp. There is already something for
pageorientation, nothing for pixels.
If you want the UI to appear in the search window, you need to add in in
searchgroup.cpp.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Yiou Wang]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108574/

- Yiou

On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:

Review request for Digikam.

By Stephen Toothman.

Updated Jan. 28, 2013, 3:46 p.m.

Description

I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

Testing

I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

Bugs: none

Diffs

• digikam/items/digikamimagedelegate.cpp (3e65a85)
• digikam/items/imagedelegate.cpp (6dfad4f)
• digikam/items/imagedelegatepriv.h (0ffa233)
• digikam/main/digikamapp.cpp (f9a1206)
• digikam/utils/albumsettings.h (501213a)
• digikam/utils/albumsettings.cpp (b838479)
• digikam/utils/tooltipfiller.h (d384b82)
• digikam/utils/tooltipfiller.cpp (57206cb)
• libs/models/imagesortsettings.h (8db56e7)
• libs/models/imagesortsettings.cpp (cf01336)
• libs/widgets/itemview/itemviewimagedelegate.h (d1c3fd0)
• libs/widgets/itemview/itemviewimagedelegate.cpp (1a1632c)
• utilities/setup/setupalbumview.cpp (f2d5e7c)
• utilities/setup/setuptooltip.cpp (b1ac814)

View Diff

File Attachments

• local diff I used for porting to the git code base

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel