Re: branches/extragear/graphics/digikam/libkface

[Johannes Wienke-2]

Hi,

jsut as a question: since 2.0 opencv installs a pkgconfig file, too. Why
don't you use this instead of a find macro?

Regards,
Johannes

Aditya Jitesh Bhatt wrote:

> SVN commit 1138615 by adityab:
>
> Moved OpenCV check to a better place.
>
>  M  +2 -0      CMakeLists.txt  
>  M  +0 -2      libkface/CMakeLists.txt  
>
>
> --- branches/extragear/graphics/digikam/libkface/CMakeLists.txt #1138614:1138615
> @@ -1,6 +1,8 @@
>  PROJECT(libkface)
>  
>  FIND_PACKAGE(KDE4 REQUIRED)
> +FIND_PACKAGE(OpenCV REQUIRED)
> +
>  INCLUDE(KDE4Defaults)
>  INCLUDE(MacroLibrary)
>  INCLUDE(MacroOptionalAddSubdirectory)
> --- branches/extragear/graphics/digikam/libkface/libkface/CMakeLists.txt #1138614:1138615
> @@ -5,8 +5,6 @@
>  ADD_DEFINITIONS(${KDE4_ENABLE_EXCEPTIONS})
>  REMOVE_DEFINITIONS(-DQT_NO_STL)
>  
> -FIND_PACKAGE(OpenCV REQUIRED)
> -
>  CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/version.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/version.h)
>  
>  # This was used to enable catching of exceptions thrown by libexiv2.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2010/6/16 Johannes Wienke <[hidden email]>:
> Hi,
>
> jsut as a question: since 2.0 opencv installs a pkgconfig file, too. Why
> don't you use this instead of a find macro?
>

Right. this must be fixed.

Gilles

> Regards,
> Johannes
>
> Aditya Jitesh Bhatt wrote:
>> SVN commit 1138615 by adityab:
>>
>> Moved OpenCV check to a better place.
>>
>>  M  +2 -0      CMakeLists.txt
>>  M  +0 -2      libkface/CMakeLists.txt
>>
>>
>> --- branches/extragear/graphics/digikam/libkface/CMakeLists.txt #1138614:1138615
>> @@ -1,6 +1,8 @@
>>  PROJECT(libkface)
>>
>>  FIND_PACKAGE(KDE4 REQUIRED)
>> +FIND_PACKAGE(OpenCV REQUIRED)
>> +
>>  INCLUDE(KDE4Defaults)
>>  INCLUDE(MacroLibrary)
>>  INCLUDE(MacroOptionalAddSubdirectory)
>> --- branches/extragear/graphics/digikam/libkface/libkface/CMakeLists.txt #1138614:1138615
>> @@ -5,8 +5,6 @@
>>  ADD_DEFINITIONS(${KDE4_ENABLE_EXCEPTIONS})
>>  REMOVE_DEFINITIONS(-DQT_NO_STL)
>>
>> -FIND_PACKAGE(OpenCV REQUIRED)
>> -
>>  CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/version.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/version.h)
>>
>>  # This was used to enable catching of exceptions thrown by libexiv2.
>
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-2]

Gilles Caulier wrote:
> SVN commit 1140763 by cgilles:
>
> first version of libface auto detection based on CMake. It work if libface is installed into /usr/
> As libface do not have package config file, it will be difficult to detect this library in a special path.
> Package Config support must be implemented into Libface.

Another solution is to specify a LIBFACE_ROOT cmake variable that the
user can specify on the command line and that is processed by the find
macro. That's a usual way used by many find macros.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Aditya Bhatt]

Ok, I'll do that now.

--
Aditya Bhatt
Blog : http://adityabhatt.wordpress.com
Bitbucket: http://bitbucket.org/aditya_bhatt
Face Recognition Library : http://libface.sourceforge.net

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel