Re: branches/extragear/graphics/digikam/libkface/cmake/modules

[Johannes Wienke-2]

Is there any reason why we don't use pkg_check_modules from cmake? This
already returns the version and removes the deprecation warnings.

Johannes

Gilles Caulier wrote:

> SVN commit 1141752 by cgilles:
>
> use right syntax
>
>
>  M  +1 -1      FindLibFace.cmake  
>
>
> --- branches/extragear/graphics/digikam/libkface/cmake/modules/FindLibFace.cmake #1141751:1141752
> @@ -38,7 +38,7 @@
>  
>      IF(_LIBFACELinkFlags)
>        # query pkg-config asking for a LibFace >= 0.1
> -      EXEC_PROGRAM(${PKGCONFIG_EXECUTABLE} ARGS --atleast-version=${LIBFACE_MIN_VERSION} face RETURN_VALUE _return_VALUE OUTPUT_VARIABLE _pkgconfigDevNull )
> +      EXEC_PROGRAM(${PKGCONFIG_EXECUTABLE} ARGS --atleast-version=${LIBFACE_MIN_VERSION} libface RETURN_VALUE _return_VALUE OUTPUT_VARIABLE _pkgconfigDevNull )
>        IF(_return_VALUE STREQUAL "0")
>          MESSAGE(STATUS "Found LibFace release >= ${LIBFACE_MIN_VERSION}")
>          SET(LIBFACE_VERSION_GOOD_FOUND TRUE)

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Nonno special reason. I don't know yet this macro.

Can you patch scripts ?

Gilles

2010/6/23 Johannes Wienke <[hidden email]>:

> Is there any reason why we don't use pkg_check_modules from cmake? This
> already returns the version and removes the deprecation warnings.
>
> Johannes
>
> Gilles Caulier wrote:
>> SVN commit 1141752 by cgilles:
>>
>> use right syntax
>>
>>
>>  M  +1 -1      FindLibFace.cmake
>>
>>
>> --- branches/extragear/graphics/digikam/libkface/cmake/modules/FindLibFace.cmake #1141751:1141752
>> @@ -38,7 +38,7 @@
>>
>>      IF(_LIBFACELinkFlags)
>>        # query pkg-config asking for a LibFace >= 0.1
>> -      EXEC_PROGRAM(${PKGCONFIG_EXECUTABLE} ARGS --atleast-version=${LIBFACE_MIN_VERSION} face RETURN_VALUE _return_VALUE OUTPUT_VARIABLE _pkgconfigDevNull )
>> +      EXEC_PROGRAM(${PKGCONFIG_EXECUTABLE} ARGS --atleast-version=${LIBFACE_MIN_VERSION} libface RETURN_VALUE _return_VALUE OUTPUT_VARIABLE _pkgconfigDevNull )
>>        IF(_return_VALUE STREQUAL "0")
>>          MESSAGE(STATUS "Found LibFace release >= ${LIBFACE_MIN_VERSION}")
>>          SET(LIBFACE_VERSION_GOOD_FOUND TRUE)
>
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Aditya Bhatt]

Will this involve adding something to libface now?

On Wed, Jun 23, 2010 at 6:06 PM, Gilles Caulier <[hidden email]> wrote:

Nonno special reason. I don't know yet this macro.

Can you patch scripts ?

Gilles

2010/6/23 Johannes Wienke <[hidden email]>:

> Is there any reason why we don't use pkg_check_modules from cmake? This
> already returns the version and removes the deprecation warnings.
>
> Johannes
>
> Gilles Caulier wrote:
>> SVN commit 1141752 by cgilles:
>>
>> use right syntax
>>
>>
>>  M  +1 -1      FindLibFace.cmake
>>
>>
>> --- branches/extragear/graphics/digikam/libkface/cmake/modules/FindLibFace.cmake #1141751:1141752
>> @@ -38,7 +38,7 @@
>>
>>      IF(_LIBFACELinkFlags)
>>        # query pkg-config asking for a LibFace >= 0.1
>> -      EXEC_PROGRAM(${PKGCONFIG_EXECUTABLE} ARGS --atleast-version=${LIBFACE_MIN_VERSION} face RETURN_VALUE _return_VALUE OUTPUT_VARIABLE _pkgconfigDevNull )
>> +      EXEC_PROGRAM(${PKGCONFIG_EXECUTABLE} ARGS --atleast-version=${LIBFACE_MIN_VERSION} libface RETURN_VALUE _return_VALUE OUTPUT_VARIABLE _pkgconfigDevNull )
>>        IF(_return_VALUE STREQUAL "0")
>>          MESSAGE(STATUS "Found LibFace release >= ${LIBFACE_MIN_VERSION}")
>>          SET(LIBFACE_VERSION_GOOD_FOUND TRUE)
>
>
>

> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

--
Aditya Bhatt
Blog : http://adityabhatt.wordpress.com
Bitbucket: http://bitbucket.org/aditya_bhatt
Face Recognition Library : http://libface.sourceforge.net

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-2]

Gilles Caulier wrote:
> Nonno special reason. I don't know yet this macro.
>
> Can you patch scripts ?

Can have a look later or at the weekend. This is the official
replacement for the old pkgconfig macro.

For digikam, who does provide the MACRO_OPTIONAL_FIND_PACKAGE? This
could also be patched.

Aditya, the version is read from the pc file.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Aditya Bhatt]

Ok, thanks.

On Wed, Jun 23, 2010 at 6:14 PM, Johannes Wienke <[hidden email]> wrote:

Gilles Caulier wrote:
> Nonno special reason. I don't know yet this macro.
>
> Can you patch scripts ?

Can have a look later or at the weekend. This is the official
replacement for the old pkgconfig macro.

For digikam, who does provide the MACRO_OPTIONAL_FIND_PACKAGE? This
could also be patched.

Aditya, the version is read from the pc file.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

--
Aditya Bhatt
Blog : http://adityabhatt.wordpress.com
Bitbucket: http://bitbucket.org/aditya_bhatt
Face Recognition Library : http://libface.sourceforge.net

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel