Questionable commit to digikam's frameworks branch?

[Marko Käning]

Hi digikam devs,

in discussion with Veaceslav it became obvious that I better subscribe to
this list, as I might have committed something which isn’t really correct.

Teemu, could you check whether my below commit to Baloo’s CMakeLists.txt
is okay or not?

Thanks in advance.

Greets,
Marko


P.S.: There are still two posts of mine in the ML’s pipeline which need
      to be let go through, which is why I CC'ed the ML admin as well.




Begin forwarded message:

> From: Veaceslav Munteanu <[hidden email]>
> Subject: Re: digiKam issues
> Date: 15 Mar 2015 18:36:42 GMT+1
> To: Marko Käning <[hidden email]>
>
> Please post it on digikam-devel,
>
> Teemu might be able to help you, he is the one who rewrite the CMake tree.
>
> It is not the best idea because I think there is a include problem
> rather than linking, and what I did right now was to link in other
> place, except digiKam's executable..
>
> On Sun, Mar 15, 2015 at 6:31 PM, Marko Käning <[hidden email]> wrote:
>>
>> On 15 Mar 2015, at 18:14 , Veaceslav Munteanu <[hidden email]> wrote:
>>
>>> Try adding KF5::I18n to target_link_libraries in /core/utilities/baloo
>>> CMakeFile. Even if it works, I'm not sure it is the correct way ...
>>
>> It did work, which is why I committed right away:
>>
>>        http://commits.kde.org/digikam/bacb578e1d21cd06d6e72c528673598d4849851d
>>
>> only to read then, that you were not sure that it is the correct way…
>>
>> Too late! =(

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin Klapetek]

On Sun, Mar 15, 2015 at 6:49 PM, Marko Käning <[hidden email]> wrote:

P.S.: There are still two posts of mine in the ML’s pipeline which need
      to be let go through, which is why I CC'ed the ML admin as well.

The moderation passwords have changed so I couldn't process it sooner,

sorry about that. Should be all good now :)

Cheers

--

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marko Käning]

Hi Martin,

On 15 Mar 2015, at 19:35 , Martin Klapetek <[hidden email]> wrote:
> The moderation passwords have changed so I couldn't process it sooner,
> sorry about that. Should be all good now :)

short time no see. :)

You’re moderating this list?

OK, I saw my two posts coming through. I guess I need to comment on them myself,
as some stuff has been resolved thanks to Veacslav.

Greets,
Marko

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin Klapetek]

On Sun, Mar 15, 2015 at 7:38 PM, Marko Käning <[hidden email]> wrote:

Hi Martin,

On 15 Mar 2015, at 19:35 , Martin Klapetek <[hidden email]> wrote:
> The moderation passwords have changed so I couldn't process it sooner,
> sorry about that. Should be all good now :)

short time no see. :)

You’re moderating this list?

Yeah, at some point in the past I got annoyed with the volume of spam

coming through that I volunteered to moderate it. It's been so long ago

that now I simply consider it as part of an every day morning routine :)

(In case anyone is wondering, there is about 2-10 spam mails stuck

in the moderation queue every day).

Cheers

--

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

Marko Käning wrote:

Hi Marko, and thanks for your commit. I have been on holidays and thus
haven't been following mailinglists lately.

> Teemu, could you check whether my below commit to Baloo’s CMakeLists.txt
> is okay or not?

>> It is not the best idea because I think there is a include problem
>> rather than linking, and what I did right now was to link in other
>> place, except digiKam's executable..

The fix depends on the error of course, but if there is something using the
k18n headers, the library probably should also be linked, no? If the used
header is from some other library which becomes added to the include path by
including the k18n then this solution is wrong :-)

--
Best Regards,
Teemu Rytilahti


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

Teemu,

the reason I was concerned is because, baloo lib is compiled as static
and KI18n is also included in whole executable. I don't see any
reasons link to baloo when it is static. (Or I don't get how Cmake
works)

That means it might be a include problem.

Also, somebody changed baloo to STATIC again. Did you also check if it
works as static? Because I changed it to SHARED because of it not
reading the correct settings.

Veaceslav

On Sun, Apr 5, 2015 at 2:31 AM, Teemu Rytilahti <[hidden email]> wrote:

> Marko Käning wrote:
>
> Hi Marko, and thanks for your commit. I have been on holidays and thus
> haven't been following mailinglists lately.
>
>> Teemu, could you check whether my below commit to Baloo’s CMakeLists.txt
>> is okay or not?
>
>>> It is not the best idea because I think there is a include problem
>>> rather than linking, and what I did right now was to link in other
>>> place, except digiKam's executable..
>
> The fix depends on the error of course, but if there is something using the
> k18n headers, the library probably should also be linked, no? If the used
> header is from some other library which becomes added to the include path by
> including the k18n then this solution is wrong :-)
>
> --
> Best Regards,
> Teemu Rytilahti
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel