Achim,
Gilles has told me that you have write access to SVN. Can you help me to integrate the new iconset in SVN for 0.8.1 (first) and 0.9.0 ? In which form you want that I provide you the iconset ? _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Le Jeudi 5 Janvier 2006 12:43, Tung NGUYEN a écrit :
> Achim, > > Gilles has told me that you have write access to SVN. Can you help me to > integrate the new iconset in SVN for 0.8.1 (first) and 0.9.0 ? > > In which form you want that I provide you the iconset ? Achim, i'm busy on others digiKam parts, but if you need any help let's me hear... -- Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Tung NGUYEN
On Thursday 05 January 2006 12:43, Tung NGUYEN wrote:
> Achim, > > Gilles has told me that you have write access to SVN. Can you help me to > integrate the new iconset in SVN for 0.8.1 (first) and 0.9.0 ? > > In which form you want that I provide you the iconset ? Hi Tung, of course best would be if you send me a tar that places the new icons in the right pics directories in the digikam tree + a patch for the Makefile.ams ;) If you have any questions how to do this, ask. I assume best would be to do this in an svn checkout, so 'svn status' shows you which files are added modified and 'svn diff' show you what's changed. Feel free to visit the #digikam IRC channel on freennode.net. Normally I'm there late in the night. Achim -- To me vi is Zen. To use vi is to practice zen. Every command is a koan. Profound to the user, unintelligible to the uninitiated. You discover truth everytime you use it. -- [hidden email] _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Hi Achim,
Do follow the following steps to integrate the new icons in DigiKam 0.8.1 : 1) As you asked, the tarball http://ntung.free.fr/new-icons-0.8.1.tar.bz2 contains all the new icons (PNG and SVGZ) in the right pics folders in the DigiKam tree. 2) The file http://ntung.free.fr/new-icons-0.8.1.patch is used to patch the file digikam/pics/Makefile.am. 3) Once the new icons are integrated, you can delete the following obsolete files: - digikam/pics/addimagefolder.png - digikam/pics/albumfoldercomment.png - digikam/pics/albumfoldernew.png - digikam/pics/digitalcam.png - digikam/pics/editimage.png - digikam/pics/exifinfo.png - digikam/pics/histogram.png - digikam/pics/imagecomment.png - digikam/pics/importfolders2albums.png ---------------------------------------------------------------------------- Follow the same steps with http://ntung.free.fr/new-icons-0.9.0.tar.bz2 and http://ntung.free.fr/new-icons-0.9.0.patch to integrate the new icons in DigiKam 0.9.0. --- Tung. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
On Monday 09 January 2006 14:19, Tung NGUYEN wrote:
> Hi Achim, > > Do follow the following steps to integrate the new icons in DigiKam 0.8.1 : working on it and testing right now. Not commited yet. > > 1) As you asked, the tarball http://ntung.free.fr/new-icons-0.8.1.tar.bz2 > contains all the new icons (PNG and SVGZ) in the right pics folders in the > DigiKam tree. Mhmm, make it's just the first time I noticed this: a) make -f Makefile.cvs ... unknown icon type in digikam/digikam/pics/Makefile.in (tag.png) unknown icon type histogram in digikam/digikam/pics/Makefile.in (histogram-lin.png) unknown icon type histogram in digikam/digikam/pics/Makefile.in (histogram-log.png) unknown icon type image in digikam/digikam/pics/Makefile.in (image-full.png) unknown icon type image in digikam/digikam/pics/Makefile.in (image-selection.png) unknown icon type in digikam/digikam/pics/Makefile.in (image_broken.png) unknown icon type in digikam/digikam/pics/Makefile.in (rating.png) unknown icon prefix tag in digikam/digikam/pics/Makefile.in unknown icon prefix tag in digikam/digikam/pics/Makefile.in unknown icon prefix tag in digikam/digikam/pics/Makefile.in unknown icon prefix tag in digikam/digikam/pics/Makefile.in unknown icon type showfoto in digikam/showfoto/pics/Makefile.in (showfoto-splash.png) ... 1) can't we simple rename tags(whatever).png to hi32-action-tags<whatever>.png 2) Stupid non programer question: why are the image* histogram* and ratin* icons installed into apps/digikam/data/ and not below the apps/digikam/icons tree as actions [+ a rename in as in 1)] b) some icons have the 'x' bit set. I will remove it. c) In digikam/digikam/pics are also -rw-r--r-- 1 ach ach 19430 2006-01-06 20:25 cr128-action-fileopen.png -rw-r--r-- 1 ach ach 1065 2006-01-06 20:25 cr16-action-fileopen.png -rw-r--r-- 1 ach ach 1689 2006-01-06 20:25 cr22-action-fileopen.png -rw-r--r-- 1 ach ach 2888 2006-01-06 20:25 cr32-action-fileopen.png -rw-r--r-- 1 ach ach 5087 2006-01-06 20:25 cr48-action-fileopen.png -rw-r--r-- 1 ach ach 7525 2006-01-06 20:25 cr64-action-fileopen.png -rw-r--r-- 1 ach ach 28663 2006-01-08 19:01 crsc-action-fileopen.svgz is there a special reason why use for crystal a special fileopen (there no digikam equivalent for hires) Achim > > 2) The file http://ntung.free.fr/new-icons-0.8.1.patch is used to patch the > file digikam/pics/Makefile.am. > > 3) Once the new icons are integrated, you can delete the following obsolete > files: > > - digikam/pics/addimagefolder.png > - digikam/pics/albumfoldercomment.png > - digikam/pics/albumfoldernew.png > - digikam/pics/digitalcam.png > - digikam/pics/editimage.png > - digikam/pics/exifinfo.png > - digikam/pics/histogram.png > - digikam/pics/imagecomment.png > - digikam/pics/importfolders2albums.png > > ---------------------------------------------------------------------------- > Follow the same steps with http://ntung.free.fr/new-icons-0.9.0.tar.bz2 and > http://ntung.free.fr/new-icons-0.9.0.patch to integrate the new icons in > DigiKam 0.9.0. I'll do this later until 0.8.1 merge is completed and tested. Achim > > --- > Tung. > > > > > > -- To me vi is Zen. To use vi is to practice zen. Every command is a koan. Profound to the user, unintelligible to the uninitiated. You discover truth everytime you use it. -- [hidden email] _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Le Mercredi 11 Janvier 2006 00:42, Achim Bohnet a écrit :
> Mhmm, make it's just the first time I noticed this: > > a) make -f Makefile.cvs > ... > unknown icon type in digikam/digikam/pics/Makefile.in (tag.png) > unknown icon type histogram in digikam/digikam/pics/Makefile.in > (histogram-lin.png) unknown icon type histogram in > digikam/digikam/pics/Makefile.in (histogram-log.png) unknown icon type > image in digikam/digikam/pics/Makefile.in (image-full.png) unknown icon > type image in digikam/digikam/pics/Makefile.in (image-selection.png) > unknown icon type in digikam/digikam/pics/Makefile.in (image_broken.png) > unknown icon type in digikam/digikam/pics/Makefile.in (rating.png) unknown > icon prefix tag in digikam/digikam/pics/Makefile.in > unknown icon prefix tag in digikam/digikam/pics/Makefile.in > unknown icon prefix tag in digikam/digikam/pics/Makefile.in > unknown icon prefix tag in digikam/digikam/pics/Makefile.in > unknown icon type showfoto in digikam/showfoto/pics/Makefile.in > (showfoto-splash.png) ... > "unknown ..." 1 to 11 appear in Konsole because of the 2 lines I added to digikam/digikam/pics/Makefile.am : digikamicondir = $(kde_datadir)/digikam/icons digikamicon_ICON = AUTO to process automatically all the icons relating to hicolor or crystalsvg theme. "make -f Makefile.cvs" displays such messages for all the PNGs which have a wrong name. Notice that the last message "unknown icon type showfoto in..." already exists before the integration of the new iconset. The same problem applies to ShowFoto. > 1) can't we simple rename tags(whatever).png to > hi32-action-tags<whatever>.png > Not necessarily, because tags(whatever).png are "private" icons (no need to use them in different sizes). > 2) Stupid non programer question: why are > the image* histogram* and ratin* icons installed into apps/digikam/data/ > and not below the apps/digikam/icons tree as actions [+ a rename in as in > 1)] > Perhaps, it's a choice to consider them as "private" icons (like tags(whatever).png, no need to use them in different sizes) and to put them in apps/digikam/data/. > b) some icons have the 'x' bit set. I will remove it. > Thank you. :-) > c) In digikam/digikam/pics are also > > -rw-r--r-- 1 ach ach 19430 2006-01-06 20:25 cr128-action-fileopen.png > -rw-r--r-- 1 ach ach 1065 2006-01-06 20:25 cr16-action-fileopen.png > -rw-r--r-- 1 ach ach 1689 2006-01-06 20:25 cr22-action-fileopen.png > -rw-r--r-- 1 ach ach 2888 2006-01-06 20:25 cr32-action-fileopen.png > -rw-r--r-- 1 ach ach 5087 2006-01-06 20:25 cr48-action-fileopen.png > -rw-r--r-- 1 ach ach 7525 2006-01-06 20:25 cr64-action-fileopen.png > -rw-r--r-- 1 ach ach 28663 2006-01-08 19:01 crsc-action-fileopen.svgz > > is there a special reason why use for crystal a special fileopen > (there no digikam equivalent for hires) > Before the integration, in digikam/digikam/pics, there is an icon called "importfolders2albums.png", I think it is the former icon of the menu "Album->Import->Import Folders..." but now, I don't know why, this icon is not used any more and the menu uses fileopen.png instead. as I want to modify the icon of the menu "Album->Import->Import Folders...", I have to create a digikam/icons/crystalsvg/ folder to overwrite the global fileopen.png. It can be a bug because we can see the digikam fileopen.png everywhere the global fileopen.png is used (for exemple : Settings->Configure DigiKam->Collection). Gilles, Joern, Tom, can we make a modification to use "importfolders2albums.png" for the menu "Album->Import->Import Folders..." ? Notice that I have also provided in the tarball : cr128-action-importfolders2albums.png cr16-action-importfolders2albums.png cr22-action-importfolders2albums.png cr32-action-importfolders2albums.png cr48-action-importfolders2albums.png cr64-action-importfolders2albums.png crsc-action-importfolders2albums.svgz to anticipate the modification. --- Tung. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from ach@mpe.mpg.de
Achim,
I have tested a new DigiKam 0.8.1 SVN and checked that all the new DigiKam and DigiKamImagePlugins icons are correctly integrated. Thank you for your help. -- Tung. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Le Jeudi 12 Janvier 2006 12:21, Tung NGUYEN a écrit :
> Achim, > > I have tested a new DigiKam 0.8.1 SVN and checked that all the new DigiKam > and DigiKamImagePlugins icons are correctly integrated. > > Thank you for your help. > -- > Tung. WARNING !!! Tung, Achim : WHY "Refocus" and 'Unsharp Mask" plugins in DigikamImagePlugins from stable branch are the _same_ icon ? How users can make a difference about these tools if icons are placed in toolbar ? My 10 cts € (:=))) -- Gilles Caulier _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Sharpen, Unsharp Mask and Refocus are the most difficult icons to create...
I just want to express the main idea of the 3 plugins : sharpen an image (and not the technique behind them) that's why the 3 icons are identical, the only way to differentiate them is to use the tool tip ! OK, I will add some detail to differentiate Unsharp Mask and Refocus. --- Tung. Le Vendredi 13 Janvier 2006 08:29, Gilles Caulier a écrit : > Le Jeudi 12 Janvier 2006 12:21, Tung NGUYEN a écrit : > > Achim, > > > > I have tested a new DigiKam 0.8.1 SVN and checked that all the new > > DigiKam and DigiKamImagePlugins icons are correctly integrated. > > > > Thank you for your help. > > -- > > Tung. > > WARNING !!! > > Tung, Achim : WHY "Refocus" and 'Unsharp Mask" plugins in > DigikamImagePlugins from stable branch are the _same_ icon ? How users can > make a difference about these tools if icons are placed in toolbar ? > > My 10 cts € (:=))) Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier
Achim,
Here are the reworked icons for "Refocus" and 'Unsharp Mask", can you update them for me in DigiKam 0.8.1 ? Thank you. Good week-end. --- Tung. Le Vendredi 13 Janvier 2006 08:29, Gilles Caulier a écrit : > > WARNING !!! > > Tung, Achim : WHY "Refocus" and 'Unsharp Mask" plugins in > DigikamImagePlugins from stable branch are the _same_ icon ? How users can > make a difference about these tools if icons are placed in toolbar ? > > My 10 cts € (:=))) _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel icones_digikam-0.8.1.tar.bz2 (44K) Download Attachment |
Free forum by Nabble | Edit this page |