Model View Port Testing

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

Model View Port Testing

Johannes Wienke-3
Hi,

Marcel and I will meet next saturday to fix the last obvious bugs and
implement missing features in the model view port branch. It would be
nice if others could test the branch before and report problems here so
taht we don't run out of work. :P

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (268 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Gilles Caulier-4
Ok, i will recompile this branch next week, tuesday or wenesday, and i
will report there

Gilles

2010/1/9 Johannes Wienke <[hidden email]>:

> Hi,
>
> Marcel and I will meet next saturday to fix the last obvious bugs and
> implement missing features in the model view port branch. It would be nice
> if others could test the branch before and report problems here so taht we
> don't run out of work. :P
>
> Johannes
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
In reply to this post by Johannes Wienke-3
One thing that is not working anymore is the horizontal scrollbar in all
views... it is gone...

Andi Clemens
-----------------
www.digikam.org

On Saturday 09 January 2010 22:57:07 Johannes Wienke wrote:
> Hi,
>
> Marcel and I will meet next saturday to fix the last obvious bugs and
> implement missing features in the model view port branch. It would be
> nice if others could test the branch before and report problems here so
> taht we don't run out of work. :P
>
> Johannes
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
In reply to this post by Johannes Wienke-3
Also clicking on a folder item will immediately expand it...

Andi Clemens
-----------------
www.digikam.org

On Saturday 09 January 2010 22:57:07 Johannes Wienke wrote:
> Hi,
>
> Marcel and I will meet next saturday to fix the last obvious bugs and
> implement missing features in the model view port branch. It would be
> nice if others could test the branch before and report problems here so
> taht we don't run out of work. :P
>
> Johannes
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
To be more precise:
The right sidebar views (filter tags, assign tags) are working as expected
(double click to expand / collapse), whereas the left sidebar views all expand
by single click, but collapse with double click.


Andi Clemens
-----------------
www.digikam.org

On Sunday 10 January 2010 14:20:53 Andi Clemens wrote:

> Also clicking on a folder item will immediately expand it...
>
> Andi Clemens
> -----------------
> www.digikam.org
>
> On Saturday 09 January 2010 22:57:07 Johannes Wienke wrote:
> > Hi,
> >
> > Marcel and I will meet next saturday to fix the last obvious bugs and
> > implement missing features in the model view port branch. It would be
> > nice if others could test the branch before and report problems here so
> > taht we don't run out of work. :P
> >
> > Johannes
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
In reply to this post by Johannes Wienke-3
The filter "not tagged" can not be removed by clicking on the filter LED

Andi Clemens
-----------------
www.digikam.org

On Saturday 09 January 2010 22:57:07 Johannes Wienke wrote:
> Hi,
>
> Marcel and I will meet next saturday to fix the last obvious bugs and
> implement missing features in the model view port branch. It would be
> nice if others could test the branch before and report problems here so
> taht we don't run out of work. :P
>
> Johannes
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
In reply to this post by Johannes Wienke-3
Tag management seems to be broken.

I have the following hierarchy:

My Tags
|- Personen
  |- Person 1
  |- Person 2

I add a tag to "Personen", then I move it to "Person1" by D&D.
Seems to work.

Now the first problem:
Moving this new tag back to "Personen" is not working, because
a) D&D seems to be disabled now
b) the parent tag is collapsed when moving over it

Additionally, when I now right click on a tag, digiKam crashes with the
attached backtrace.

Andi Clemens
-----------------
www.digikam.org

On Saturday 09 January 2010 22:57:07 Johannes Wienke wrote:
> Hi,
>
> Marcel and I will meet next saturday to fix the last obvious bugs and
> implement missing features in the model view port branch. It would be
> nice if others could test the branch before and report problems here so
> taht we don't run out of work. :P
>
> Johannes
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

crash_rightclick.backtrace (14K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
Note:
After restart, the tag I tried to move around is gone, so I guess it was never
add to the model, which caused the crash before?

Andi Clemens
-----------------
www.digikam.org

On Sunday 10 January 2010 14:38:15 Andi Clemens wrote:

> Tag management seems to be broken.
>
> I have the following hierarchy:
>
> My Tags
>
> |- Personen
> |
>   |- Person 1
>   |- Person 2
>
> I add a tag to "Personen", then I move it to "Person1" by D&D.
> Seems to work.
>
> Now the first problem:
> Moving this new tag back to "Personen" is not working, because
> a) D&D seems to be disabled now
> b) the parent tag is collapsed when moving over it
>
> Additionally, when I now right click on a tag, digiKam crashes with the
> attached backtrace.
>
> Andi Clemens
> -----------------
> www.digikam.org
>
> On Saturday 09 January 2010 22:57:07 Johannes Wienke wrote:
> > Hi,
> >
> > Marcel and I will meet next saturday to fix the last obvious bugs and
> > implement missing features in the model view port branch. It would be
> > nice if others could test the branch before and report problems here so
> > taht we don't run out of work. :P
> >
> > Johannes
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Jens Müller-10
In reply to this post by Johannes Wienke-3
Tried it first time and it looks nice. :o)

But in calendar sidebar on the left all months on second level are sorted
alphabetically.

Jens

Am Sonntag 10 Januar 2010 00:09:39 schrieb [hidden email]:

> Date: Sat, 09 Jan 2010 22:57:07 +0100
> From: Johannes Wienke <[hidden email]>
> Subject: [Digikam-devel] Model View Port Testing
> To: digiKam developers room <[hidden email]>
> Message-ID: <[hidden email]>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hi,
>
> Marcel and I will meet next saturday to fix the last obvious bugs and
> implement missing features in the model view port branch. It would be
> nice if others could test the branch before and report problems here so
> taht we don't run out of work. :P
>
> Johannes
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Gilles Caulier-4
In reply to this post by Johannes Wienke-3
Compiled and installed here.

First great work. Congratulations do you and Marcel.

My first tests on my computer do not bring major dysfunctions,
excepted some little problem reported by Andi.

I will test indeep today, especially D&D, contextual menu, etc.

Anyway, i think that code is ready to be merged to trunk, after 1.1
release, planed at 31 January.

Gilles

2010/1/9 Johannes Wienke <[hidden email]>:

> Hi,
>
> Marcel and I will meet next saturday to fix the last obvious bugs and
> implement missing features in the model view port branch. It would be nice
> if others could test the branch before and report problems here so taht we
> don't run out of work. :P
>
> Johannes
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Johannes Wienke-3
In reply to this post by Bugzilla from andi.clemens@gmx.net
Hi Andi,

Am 10.01.2010 14:29 schrieb Andi Clemens:
> To be more precise:
> The right sidebar views (filter tags, assign tags) are working as expected
> (double click to expand / collapse), whereas the left sidebar views all expand
> by single click, but collapse with double click.

Marcel and I cannot figure out what's the difference between the
behaviour of the new implementation and the old one. To our my minds
this works in complete analogy to the old version and as dicussed here:
https://bugs.kde.org/show_bug.cgi?id=126871

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (268 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
Yes, the old behavior was somehow not very compatible with the rest of KDE /
Qt applications.
But now the left side and the right side are incompatible, too.

The right side expands / collapses a tree by double clicking, the left side
does not.

The right side behaves like a "normal" KDE / Qt app, the left side like
digiKam (:-)).

We should at least have one behavior for both sides, where as I would suggest
to go with the double click expand / collapse solution.


Andi Clemens
-----------------
www.digikam.org

On Saturday 16 January 2010 14:29:57 Johannes Wienke wrote:

> Hi Andi,
>
> Am 10.01.2010 14:29 schrieb Andi Clemens:
> > To be more precise:
> > The right sidebar views (filter tags, assign tags) are working as
> > expected (double click to expand / collapse), whereas the left sidebar
> > views all expand by single click, but collapse with double click.
>
> Marcel and I cannot figure out what's the difference between the
> behaviour of the new implementation and the old one. To our my minds
> this works in complete analogy to the old version and as dicussed here:
> https://bugs.kde.org/show_bug.cgi?id=126871
>
> Johannes
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Marcel Wiesweg
> Yes, the old behavior was somehow not very compatible with the rest of KDE
>  / Qt applications.
> But now the left side and the right side are incompatible, too.
>
> The right side expands / collapses a tree by double clicking, the left side
> does not.
>
> The right side behaves like a "normal" KDE / Qt app, the left side like
> digiKam (:-)).
>
> We should at least have one behavior for both sides, where as I would
>  suggest to go with the double click expand / collapse solution.

Did you see comment #9 on bug 126871? Your SVN commit ;-)

The special situation is to expand the children of an album if you select that
album. Selection is single click, always. The rationale at the time was the
selection has no special meaning on the right side.
I don't mind using double click to expand, but I like auto-expanding when
selecting.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Bugzilla from andi.clemens@gmx.net
I committed this because a lot of users wanted it... but now even more users
hate it :) If we would rethink this behavior, I would go with "double
click"... :D
If I remember correctly, in KDE3 both sides behaved the same, but this is
inconsistent now. But maybe I'm wrong...

Andi Clemens
-----------------
www.digikam.org

On Saturday 16 January 2010 15:13:14 Marcel Wiesweg wrote:

> > Yes, the old behavior was somehow not very compatible with the rest of
> > KDE / Qt applications.
> > But now the left side and the right side are incompatible, too.
> >
> > The right side expands / collapses a tree by double clicking, the left
> > side does not.
> >
> > The right side behaves like a "normal" KDE / Qt app, the left side like
> > digiKam (:-)).
> >
> > We should at least have one behavior for both sides, where as I would
> >  suggest to go with the double click expand / collapse solution.
>
> Did you see comment #9 on bug 126871? Your SVN commit ;-)
>
> The special situation is to expand the children of an album if you select
>  that album. Selection is single click, always. The rationale at the time
>  was the selection has no special meaning on the right side.
> I don't mind using double click to expand, but I like auto-expanding when
> selecting.
>
> Marcel
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Johannes Wienke-3
In reply to this post by Bugzilla from andi.clemens@gmx.net
Am 10.01.2010 14:30 schrieb Andi Clemens:
> The filter "not tagged" can not be removed by clicking on the filter LED

Done.


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (268 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Johannes Wienke-3
In reply to this post by Bugzilla from andi.clemens@gmx.net
Are there any more opinions on this?

Johannes

Am 16.01.2010 15:21 schrieb Andi Clemens:

> I committed this because a lot of users wanted it... but now even more users
> hate it :) If we would rethink this behavior, I would go with "double
> click"... :D
> If I remember correctly, in KDE3 both sides behaved the same, but this is
> inconsistent now. But maybe I'm wrong...
>
> Andi Clemens
> -----------------
> www.digikam.org
>
> On Saturday 16 January 2010 15:13:14 Marcel Wiesweg wrote:
>>> Yes, the old behavior was somehow not very compatible with the rest of
>>> KDE / Qt applications.
>>> But now the left side and the right side are incompatible, too.
>>>
>>> The right side expands / collapses a tree by double clicking, the left
>>> side does not.
>>>
>>> The right side behaves like a "normal" KDE / Qt app, the left side like
>>> digiKam (:-)).
>>>
>>> We should at least have one behavior for both sides, where as I would
>>>  suggest to go with the double click expand / collapse solution.
>>
>> Did you see comment #9 on bug 126871? Your SVN commit ;-)
>>
>> The special situation is to expand the children of an album if you select
>>  that album. Selection is single click, always. The rationale at the time
>>  was the selection has no special meaning on the right side.
>> I don't mind using double click to expand, but I like auto-expanding when
>> selecting.
>>
>> Marcel
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (270 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Gilles Caulier-4
2010/1/17 Johannes Wienke <[hidden email]>:
> Are there any more opinions on this?

For me, i don't like the way used by KDE4 (or Qt4 ?) to
collapse/expand treeview only with "+". I see a lots of KDE4 peoples
searching how to do it ?

I like the old KDE3 behaviors using also tree-view text to
collapse/expand with double click. For me it's sound like a regression
between KDE4 and KDE3.

Problem : if we implement this in digiKam, we will provided a
different behavior than other KDE4 applications.

For me it's a KDE4 core (Qt4) usability problem and it must be talk
with KDE4 usabilty team first to try to find a common fix.

Gilles

>
> Johannes
>
> Am 16.01.2010 15:21 schrieb Andi Clemens:
>> I committed this because a lot of users wanted it... but now even more users
>> hate it :) If we would rethink this behavior, I would go with "double
>> click"... :D
>> If I remember correctly, in KDE3 both sides behaved the same, but this is
>> inconsistent now. But maybe I'm wrong...
>>
>> Andi Clemens
>> -----------------
>> www.digikam.org
>>
>> On Saturday 16 January 2010 15:13:14 Marcel Wiesweg wrote:
>>>> Yes, the old behavior was somehow not very compatible with the rest of
>>>> KDE / Qt applications.
>>>> But now the left side and the right side are incompatible, too.
>>>>
>>>> The right side expands / collapses a tree by double clicking, the left
>>>> side does not.
>>>>
>>>> The right side behaves like a "normal" KDE / Qt app, the left side like
>>>> digiKam (:-)).
>>>>
>>>> We should at least have one behavior for both sides, where as I would
>>>>  suggest to go with the double click expand / collapse solution.
>>>
>>> Did you see comment #9 on bug 126871? Your SVN commit ;-)
>>>
>>> The special situation is to expand the children of an album if you select
>>>  that album. Selection is single click, always. The rationale at the time
>>>  was the selection has no special meaning on the right side.
>>> I don't mind using double click to expand, but I like auto-expanding when
>>> selecting.
>>>
>>> Marcel
>>> _______________________________________________
>>> Digikam-devel mailing list
>>> [hidden email]
>>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Johannes Wienke-3
Am 18.01.2010 08:41 schrieb Gilles Caulier:

> 2010/1/17 Johannes Wienke <[hidden email]>:
>> Are there any more opinions on this?
>
> For me, i don't like the way used by KDE4 (or Qt4 ?) to
> collapse/expand treeview only with "+". I see a lots of KDE4 peoples
> searching how to do it ?
>
> I like the old KDE3 behaviors using also tree-view text to
> collapse/expand with double click. For me it's sound like a regression
> between KDE4 and KDE3.
It's not about double click, that always works in Qt4. But atm we have
some kind of single click behaviour for the album tree view and it's the
question if we preserve this or not.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (268 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Model View Port Testing

Gilles Caulier-4
2010/1/18 Johannes Wienke <[hidden email]>:

> Am 18.01.2010 08:41 schrieb Gilles Caulier:
>>
>> 2010/1/17 Johannes Wienke <[hidden email]>:
>>>
>>> Are there any more opinions on this?
>>
>> For me, i don't like the way used by KDE4 (or Qt4 ?) to
>> collapse/expand treeview only with "+". I see a lots of KDE4 peoples
>> searching how to do it ?
>>
>> I like the old KDE3 behaviors using also tree-view text to
>> collapse/expand with double click. For me it's sound like a regression
>> between KDE4 and KDE3.
>
> It's not about double click, that always works in Qt4. But atm we have some
> kind of single click behaviour for the album tree view and it's the question
> if we preserve this or not.

If code to provide this feature in new model view implementation is
simple, i recommend to let it in place and to disable it as well and
wait and see users feedback before to remove definitively.

Typically, the same behaviors must be done between digiKam and the
rest of KDE about simple click. Currently, this way do not exist in
Dolphin, Konqueror, but i remember an old wish with KDE3 code where
users want simple click to collapse/expa,d, as it have been
implemented in K3b for KDE3.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel