Exif auto-rotation not working anymore

[Johannes Wienke-3]

Hi,

I just updated my digikam installation the first time since a few weeks
and now the auto-rotation of images by exif tag seems is broken (jpg and
orf). Can anyone confirm this?

I get a lot of these messages on the console now:

Warning: Warning: Directory Directory OlympusCsOlympusCs, entry 0x,
entry 0x01010101: Strip : Strip 00 is outside of the data area; ignored.
 is outside of the data area; ignored.
Error: Upper boundary of data for Error: Upper boundary of data for
directory directory OlympusIpOlympusIp, entry 0x, entry 0x08000800 is
out of bounds:  is out of bounds: Offset = 0xOffset =
0x00000a2400000a24, size = , size = 3686436864, exceeds buffer size by ,
exceeds buffer size by 2293622936 Bytes; adjusting the size
 Bytes; adjusting the size

Regards,
Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

This message come from Exiv2 library. Do you use Exiv2 from trunk ?

Gilles Caulier

2010/5/8 Johannes Wienke <[hidden email]>:

> Hi,
>
> I just updated my digikam installation the first time since a few weeks
> and now the auto-rotation of images by exif tag seems is broken (jpg and
> orf). Can anyone confirm this?
>
> I get a lot of these messages on the console now:
>
> Warning: Warning: Directory Directory OlympusCsOlympusCs, entry 0x,
> entry 0x01010101: Strip : Strip 00 is outside of the data area; ignored.
>  is outside of the data area; ignored.
> Error: Upper boundary of data for Error: Upper boundary of data for
> directory directory OlympusIpOlympusIp, entry 0x, entry 0x08000800 is
> out of bounds:  is out of bounds: Offset = 0xOffset =
> 0x00000a2400000a24, size = , size = 3686436864, exceeds buffer size by ,
> exceeds buffer size by 2293622936 Bytes; adjusting the size
>  Bytes; adjusting the size
>
> Regards,
> Johannes
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

The exiv2 warning text itself is garbled, looks like there is an echo :)
I suspect your installation is somehow messed up.

Andreas

On Sat, May 8, 2010 at 23:24, Johannes Wienke <[hidden email]> wrote:

> Hi,
>
> I just updated my digikam installation the first time since a few weeks
> and now the auto-rotation of images by exif tag seems is broken (jpg and
> orf). Can anyone confirm this?
>
> I get a lot of these messages on the console now:
>
> Warning: Warning: Directory Directory OlympusCsOlympusCs, entry 0x,
> entry 0x01010101: Strip : Strip 00 is outside of the data area; ignored.
>  is outside of the data area; ignored.
> Error: Upper boundary of data for Error: Upper boundary of data for
> directory directory OlympusIpOlympusIp, entry 0x, entry 0x08000800 is
> out of bounds:  is out of bounds: Offset = 0xOffset =
> 0x00000a2400000a24, size = , size = 3686436864, exceeds buffer size by ,
> exceeds buffer size by 2293622936 Bytes; adjusting the size
>  Bytes; adjusting the size
>
> Regards,
> Johannes
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-2]

Andreas Huggel wrote:
> The exiv2 warning text itself is garbled, looks like there is an echo :)
> I suspect your installation is somehow messed up.

This was trunk from a few weeks ago. Nevertheless, other users report
the same problem (see bug report), so it must be something else that is
causing the rotation problem.

Can it be the dcraw update? There was an assumption that preview images
are rotated correctly by dcraw and the rotation problem only exists with
preview versions, not with completely demosaiced images.

Regards,
Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2010/5/10 Johannes Wienke <[hidden email]>:

> Andreas Huggel wrote:
>> The exiv2 warning text itself is garbled, looks like there is an echo :)
>> I suspect your installation is somehow messed up.
>
> This was trunk from a few weeks ago. Nevertheless, other users report
> the same problem (see bug report), so it must be something else that is
> causing the rotation problem.
>
> Can it be the dcraw update? There was an assumption that preview images
> are rotated correctly by dcraw and the rotation problem only exists with
> preview versions, not with completely demosaiced images.

dcraw ? You want mean libraw i think (:=))), or better libkdcraw which
include libraw...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-2]

Gilles Caulier wrote:

> 2010/5/10 Johannes Wienke <[hidden email]>:
>> Andreas Huggel wrote:
>>> The exiv2 warning text itself is garbled, looks like there is an echo :)
>>> I suspect your installation is somehow messed up.
>> This was trunk from a few weeks ago. Nevertheless, other users report
>> the same problem (see bug report), so it must be something else that is
>> causing the rotation problem.
>>
>> Can it be the dcraw update? There was an assumption that preview images
>> are rotated correctly by dcraw and the rotation problem only exists with
>> preview versions, not with completely demosaiced images.
>
> dcraw ? You want mean libraw i think (:=))), or better libkdcraw which
> include libraw...

Yes ;) There was an update of the internal version a few days ago?


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2010/5/10 Johannes Wienke <[hidden email]>:

> Gilles Caulier wrote:
>> 2010/5/10 Johannes Wienke <[hidden email]>:
>>> Andreas Huggel wrote:
>>>> The exiv2 warning text itself is garbled, looks like there is an echo :)
>>>> I suspect your installation is somehow messed up.
>>> This was trunk from a few weeks ago. Nevertheless, other users report
>>> the same problem (see bug report), so it must be something else that is
>>> causing the rotation problem.
>>>
>>> Can it be the dcraw update? There was an assumption that preview images
>>> are rotated correctly by dcraw and the rotation problem only exists with
>>> preview versions, not with completely demosaiced images.
>>
>> dcraw ? You want mean libraw i think (:=))), or better libkdcraw which
>> include libraw...
>
> Yes ;) There was an update of the internal version a few days ago?

yes, Jens has updated libraw with last stable 0.9.0 version into libkdcraw.

Look like libkexiv2 have been updated too by Marcel :

http://websvn.kde.org/?view=revision&revision=1124095

Gilles

>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Hi,
>
> I just updated my digikam installation the first time since a few weeks
> and now the auto-rotation of images by exif tag seems is broken (jpg and
> orf). Can anyone confirm this?
>
> I get a lot of these messages on the console now:

I have a good candidate why this is broken:

KExiv2Iface::KExiv2Priv::printExiv2ExceptionError: Cannot parse Exif
Orientation tag using Exiv2   (Error # 6 :  Ungültiger Schlüssel
"Exif.Sony1Cs.Rotation"

Exif.Sony2Cs.Rotation is a makernote tag checked as one of the first tags in
KExiv2::getImageOrientation(). Obviously exiv2 decides to throw an exception
from there, which means getImageOrientation will never succeed.

Proposed solution: exiv2 should not throw an exception for a key which it
previously accepted.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Am 10.05.2010 21:29 schrieb Marcel Wiesweg:

>> I just updated my digikam installation the first time since a few weeks
>> and now the auto-rotation of images by exif tag seems is broken (jpg and
>> orf). Can anyone confirm this?
>>
>> I get a lot of these messages on the console now:
>
> I have a good candidate why this is broken:
>
> KExiv2Iface::KExiv2Priv::printExiv2ExceptionError: Cannot parse Exif
> Orientation tag using Exiv2   (Error # 6 :  Ungültiger Schlüssel
> "Exif.Sony1Cs.Rotation"
>
> Exif.Sony2Cs.Rotation is a makernote tag checked as one of the first tags in
> KExiv2::getImageOrientation(). Obviously exiv2 decides to throw an exception
> from there, which means getImageOrientation will never succeed.
>
> Proposed solution: exiv2 should not throw an exception for a key which it
> previously accepted.

Hm, I didn't change my exiv2 installation since weeks and auto-rotation
definitely worked with this exiv2 installation. So this can't be the
only problem?

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > Hi,
> >
> > I just updated my digikam installation the first time since a few weeks
> > and now the auto-rotation of images by exif tag seems is broken (jpg and
> > orf). Can anyone confirm this?
>
> > I get a lot of these messages on the console now:
> I have a good candidate why this is broken:
>
> KExiv2Iface::KExiv2Priv::printExiv2ExceptionError: Cannot parse Exif
> Orientation tag using Exiv2   (Error # 6 :  Ungültiger Schlüssel
> "Exif.Sony1Cs.Rotation"
>
> Exif.Sony2Cs.Rotation is a makernote tag checked as one of the first tags
> in KExiv2::getImageOrientation(). Obviously exiv2 decides to throw an
> exception from there, which means getImageOrientation will never succeed.

Ok it seems the fault is on our side, this tag was recently added in exiv2.
Perhaps ifdefs around this makernote check?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

>> I just updated my digikam installation the first time since a few weeks
>> and now the auto-rotation of images by exif tag seems is broken (jpg and
>> orf). Can anyone confirm this?
>>
>> I get a lot of these messages on the console now:
>
> I have a good candidate why this is broken:
>
> KExiv2Iface::KExiv2Priv::printExiv2ExceptionError: Cannot parse Exif
> Orientation tag using Exiv2   (Error # 6 :  Ungültiger Schlüssel
> "Exif.Sony1Cs.Rotation"
>
> Exif.Sony2Cs.Rotation is a makernote tag checked as one of the first tags in
> KExiv2::getImageOrientation(). Obviously exiv2 decides to throw an exception
> from there, which means getImageOrientation will never succeed.
>
> Proposed solution: exiv2 should not throw an exception for a key which it
> previously accepted.

Agree that changes to Exiv2 keys must be done with care, like API
changes, i.e., avoid if possible and document clearly if necessary.

Not throwing an exception for unknown keys (or even only previously
known keys) IMO doesn't solve the problem in general, but would make
it more difficult to find.

The recent Sony Makernote updates did introduce several changes to
existing Sony keys.

Andreas
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2010/5/10 Marcel Wiesweg <[hidden email]>:

>
>> > Hi,
>> >
>> > I just updated my digikam installation the first time since a few weeks
>> > and now the auto-rotation of images by exif tag seems is broken (jpg and
>> > orf). Can anyone confirm this?
>>
>> > I get a lot of these messages on the console now:
>> I have a good candidate why this is broken:
>>
>> KExiv2Iface::KExiv2Priv::printExiv2ExceptionError: Cannot parse Exif
>> Orientation tag using Exiv2   (Error # 6 :  Ungültiger Schlüssel
>> "Exif.Sony1Cs.Rotation"
>>
>> Exif.Sony2Cs.Rotation is a makernote tag checked as one of the first tags
>> in KExiv2::getImageOrientation(). Obviously exiv2 decides to throw an
>> exception from there, which means getImageOrientation will never succeed.
>
> Ok it seems the fault is on our side, this tag was recently added in exiv2.
> Perhaps ifdefs around this makernote check?

yes, Sony stuff have been added from me.

And of course, #ifdef must be added in libkexiv2 to check Exiv2 release.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel