[Digikam-devel] image plugin settings sidebar...

[Gilles Caulier-2]

Hi all,

Here we are a patch for common image plugin dialogs to use a sidebar tab with
plugins settings :

http://digikam3rdparty.free.fr/misc.tarballs/imgpluginssb.patch

Why using sidebar in image plugins ?

Well, i'm currently working to port to 16 bits the "Insert Text" plugin. The
settings area is big and reduce considerably the preview area. Rewritting
Inser Text settings widget can a long task...

Instead, you can use a sidebar tab. If after to have set all parameters you
toogle off the sidebar tab, you can use the full dialog size to render the
preview... With Insert Text plugins, render area is used to move the text at
the right place.

The patch add the sidebar to all colors plugins  (Adjust Curves, White
Balance, BCG, HSL, RGB blanace, B&W, Auto-Corrections, etc.) and all plugins
using a guide (Free rotation, Shear, Perpective, Lens distortion, etc.)

The only one plugin witch not use it is Ratio crop tool, because the dialog
plugin don't inherit of common plugin dialog (this is an error and must be
fixed (:=)))

To apply the patch, just go to digikam/libs/dialogs, copy the patch into, and
run "patch -p0 < imgpluginssb.patch".

Please give me your viewpoint about this patch.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 17 Mars 2006 14:17, Gilles Caulier a écrit :
> The only one plugin witch not use it is Ratio crop tool, because the dialog
> plugin don't inherit of common plugin dialog (this is an error and must be
> fixed (:=)))

Fixed in svn.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia piątek, 17 marca 2006 14:17, Gilles Caulier napisał:
>
> Please give me your viewpoint about this patch.

As I see it only "Add Text" plugin really needs it. In others doesn't
disturb - and extra size of preview is always a bonus :)

One problem. There is strange border on the right side.
Attaching screenshot.

m.


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 17 Mars 2006 18:57, Mikolaj Machowski a écrit :
> Dnia piątek, 17 marca 2006 14:17, Gilles Caulier napisał:
> > Please give me your viewpoint about this patch.
>
> As I see it only "Add Text" plugin really needs it. In others doesn't
> disturb - and extra size of preview is always a bonus :)

Not only Add text. Check Template superimpose, Ratio crop tool, Adjust curves,
Adjust Levels, and the new ICC profile plugin from digiKam core...

Also, if in the future we need to make a plugin with a large collection of
settings (like panorama for example (:=))), i can improve the common dialogs
api to add extra side bar tab from plugin implementation

>
> One problem. There is strange border on the right side.
> Attaching screenshot.

This is releavant of default KDialog::marging() || spacing() values. I will
fix it.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maxime Delorme-2]

Is this improvement a step in direction of having less modal dialog and
incorporate directly digikam image plugins into IE.
Right bar for metadata, Colors, Comments and tag
Left bar for plugins settings ?

Maxime

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia piątek, 17 marca 2006 20:04, Maxime Delorme napisał:
> Is this improvement a step in direction of having less modal dialog and
> incorporate directly digikam image plugins into IE.
> Right bar for metadata, Colors, Comments and tag
> Left bar for plugins settings ?

No, this is still separate window.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia piątek, 17 marca 2006 20:12, Gilles Caulier napisał:

> Le Vendredi 17 Mars 2006 18:57, Mikolaj Machowski a écrit :
> > Dnia piątek, 17 marca 2006 14:17, Gilles Caulier napisał:
> > > Please give me your viewpoint about this patch.
> >
> > As I see it only "Add Text" plugin really needs it. In others doesn't
> > disturb - and extra size of preview is always a bonus :)
>
> Not only Add text. Check Template superimpose, Ratio crop tool, Adjust
> curves, Adjust Levels, and the new ICC profile plugin from digiKam
> core...

IMO there hiding of settings panel isn't crucial. Hiding of panel in
many cases will be harming.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Friday 17 March 2006 06:57 pm, Mikolaj Machowski wrote:
> Dnia piątek, 17 marca 2006 14:17, Gilles Caulier napisał:
> > Please give me your viewpoint about this patch.
>
> As I see it only "Add Text" plugin really needs it. In others doesn't
> disturb - and extra size of preview is always a bonus :)
>
> One problem. There is strange border on the right side.
> Attaching screenshot.

Fixed in my implementation

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Friday 17 March 2006 08:04 pm, Maxime Delorme wrote:
> Is this improvement a step in direction of having less modal dialog and
> incorporate directly digikam image plugins into IE.
> Right bar for metadata, Colors, Comments and tag
> Left bar for plugins settings ?
>
> Maxime

No maxime, plugins always use extra dialogs to run.

I know what you mean. image editor from M$ Office run like this for example.
This request have been already reported in this room in the past.

If digikam users want all image plugins embeded into image editor window, i
need to make substantial changes/tests/fix in digikam image editor core and
DigikamImagePlugins. This is out of 0.9.0 release issue but can be done
later.

In all cases, i need to have a full feedback from others digiKam users before
to start this implementation (it's not a simple job). For that please make a
file in B.K.O with full descriptions and screenshots if necessary. Thanks in
advance.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel