[Digikam-devel] image editor and print option (patch)

Hi,
first of all I'd like to introduce myself, as some of you know
I'm kipi's project coordinator and an occasional developer.
Since I like the way gwenview prints photos (maybe just
because I did, but I did because i'd have liked to have it :) )
I decided to port that code here. I mean there are two ways
to print, either using kipi-plugins or using image editor.
The first one is the best, but sometime i like to print out an
image just because i'm watching it. If I use gwenview the code
allows it and manages two options that are missed here e.g.
keep ratio and alignment. Well there is something more but i've
spent a lot of time to insert gui objects, I'm not very good at it
and i prefer to use ui files and designer (Gilles I know you don't,
but it's very easy for occasional contributors), so the code is still
in gwenview. Just want to recall the B&W option I cannot believe someone
ever used it, two colors, better using grayscale, but that is a driver
option, so no need to add it ;) (even if the preview is not good)
IIRC the so called "fit to page" option works if an image has to
be enlarge and not shrinked... And all of that is in gwenview
code.
Anyway the attached patch is something that improve the print function.
Hope you'll like it and commit (i can do it if you like).

Just another thought, why trash is near print in the menu, it seems
a bit dangerous...

Regards,
        Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 29 Décembre 2006 22:08, Angelo Naselli a écrit :

> Hi,
> first of all I'd like to introduce myself, as some of you know
> I'm kipi's project coordinator and an occasional developer.
> Since I like the way gwenview prints photos (maybe just
> because I did, but I did because i'd have liked to have it :) )
> I decided to port that code here. I mean there are two ways
> to print, either using kipi-plugins or using image editor.
> The first one is the best, but sometime i like to print out an
> image just because i'm watching it. If I use gwenview the code
> allows it and manages two options that are missed here e.g.
> keep ratio and alignment. Well there is something more but i've
> spent a lot of time to insert gui objects, I'm not very good at it
> and i prefer to use ui files and designer (Gilles I know you don't,
> but it's very easy for occasional contributors), so the code is still
> in gwenview. Just want to recall the B&W option I cannot believe someone
> ever used it, two colors, better using grayscale, but that is a driver
> option, so no need to add it ;) (even if the preview is not good)
> IIRC the so called "fit to page" option works if an image has to
> be enlarge and not shrinked... And all of that is in gwenview
> code.
> Anyway the attached patch is something that improve the print function.
> Hope you'll like it and commit (i can do it if you like).
>
> Just another thought, why trash is near print in the menu, it seems
> a bit dangerous...
>
> Regards,
> Angelo

Thanks Angelo,

I'm just back from hollidays today. I will take a look into your patch at
soon...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Alle 21:23, martedì 2 gennaio 2007, Caulier Gilles ha scritto:

> Le Vendredi 29 Décembre 2006 22:08, Angelo Naselli a écrit :
> > Hi,
> > first of all I'd like to introduce myself, as some of you know
> > I'm kipi's project coordinator and an occasional developer.
> > Since I like the way gwenview prints photos (maybe just
> > because I did, but I did because i'd have liked to have it :) )
> > I decided to port that code here. I mean there are two ways
> > to print, either using kipi-plugins or using image editor.
> > The first one is the best, but sometime i like to print out an
> > image just because i'm watching it. If I use gwenview the code
> > allows it and manages two options that are missed here e.g.
> > keep ratio and alignment. Well there is something more but i've
> > spent a lot of time to insert gui objects, I'm not very good at it
> > and i prefer to use ui files and designer (Gilles I know you don't,
> > but it's very easy for occasional contributors), so the code is still
> > in gwenview. Just want to recall the B&W option I cannot believe someone
> > ever used it, two colors, better using grayscale, but that is a driver
> > option, so no need to add it ;) (even if the preview is not good)
> > IIRC the so called "fit to page" option works if an image has to
> > be enlarge and not shrinked... And all of that is in gwenview
> > code.
> > Anyway the attached patch is something that improve the print function.
> > Hope you'll like it and commit (i can do it if you like).
> >
> > Just another thought, why trash is near print in the menu, it seems
> > a bit dangerous...
> >
> > Regards,
> > Angelo
>
> Thanks Angelo,
>
> I'm just back from hollidays today. I will take a look into your patch at
> soon...

Gilles you can check it using a pdf printer so you don't waste paper ;).

  Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 5 Janvier 2007 12:31, Angelo Naselli a écrit :

> Alle 21:23, martedì 2 gennaio 2007, Caulier Gilles ha scritto:
> > Le Vendredi 29 Décembre 2006 22:08, Angelo Naselli a écrit :
> > > Hi,
> > > first of all I'd like to introduce myself, as some of you know
> > > I'm kipi's project coordinator and an occasional developer.
> > > Since I like the way gwenview prints photos (maybe just
> > > because I did, but I did because i'd have liked to have it :) )
> > > I decided to port that code here. I mean there are two ways
> > > to print, either using kipi-plugins or using image editor.
> > > The first one is the best, but sometime i like to print out an
> > > image just because i'm watching it. If I use gwenview the code
> > > allows it and manages two options that are missed here e.g.
> > > keep ratio and alignment. Well there is something more but i've
> > > spent a lot of time to insert gui objects, I'm not very good at it
> > > and i prefer to use ui files and designer (Gilles I know you don't,
> > > but it's very easy for occasional contributors), so the code is still
> > > in gwenview. Just want to recall the B&W option I cannot believe
> > > someone ever used it, two colors, better using grayscale, but that is a
> > > driver option, so no need to add it ;) (even if the preview is not
> > > good) IIRC the so called "fit to page" option works if an image has to
> > > be enlarge and not shrinked... And all of that is in gwenview
> > > code.
> > > Anyway the attached patch is something that improve the print function.
> > > Hope you'll like it and commit (i can do it if you like).
> > >
> > > Just another thought, why trash is near print in the menu, it seems
> > > a bit dangerous...
> > >
> > > Regards,
> > > Angelo
> >
> > Thanks Angelo,
> >
> > I'm just back from hollidays today. I will take a look into your patch at
> > soon...
>
> Gilles you can check it using a pdf printer so you don't waste paper ;).

Yes, i will test it this week end (:=))). It's in my todo list ...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

> Just another thought, why trash is near print in the menu, it seems
> a bit dangerous...

Fine. I propose to move Print option just behind Last option from File menu.
What do yo uthink about ? Is respect the KDE menu goal (if we comparing with
others KDE program)

Gilles

>
> Regards,
> Angelo
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le vendredi 29 décembre 2006 22:08, Angelo Naselli a écrit :

> Hi,
> first of all I'd like to introduce myself, as some of you know
> I'm kipi's project coordinator and an occasional developer.
> Since I like the way gwenview prints photos (maybe just
> because I did, but I did because i'd have liked to have it :) )
> I decided to port that code here. I mean there are two ways
> to print, either using kipi-plugins or using image editor.
> The first one is the best, but sometime i like to print out an
> image just because i'm watching it. If I use gwenview the code
> allows it and manages two options that are missed here e.g.
> keep ratio and alignment. Well there is something more but i've
> spent a lot of time to insert gui objects, I'm not very good at it
> and i prefer to use ui files and designer (Gilles I know you don't,
> but it's very easy for occasional contributors), so the code is still
> in gwenview.

Well, i hate personally to use QTdesigner for Qt 3.x and i hope than the Qt4
stuff will improve this way.

In general, i use too Visual C++ at work and i have the same problem.

In fact i think than the code generated by a GUI tool is bad, unoptimized and
unreadable.

Personally i prefer to do all from scratch. Yes i take more time, but it not
very complicated to do it with QT, especially for simple GUI (it not the same
think about Visual C++). The code is more optimized and you understand all.
It's more easy to debug.

Of course, the tool is really powerfull to build a very complicated GUI with a
lots of options, widgets, etc...

This is my viewpoint (:=))). This cannot be representative of all Qt
developpers of course.

I would to have the viewpoint of Marcel about this point (:=))...


> Just want to recall the B&W option I cannot believe someone
> ever used it, two colors, better using grayscale,

Heu B&W == greyscale ???


> but that is a driver
> option, so no need to add it ;)

Right. On the past (digikam 0.7.x) i have backported the print interface from
kuickshow and refactorized it (the B&W stuff come from kuickshow in fact).
I'm sure than it can be optimized.

> (even if the preview is not good)
> IIRC the so called "fit to page" option works if an image has to
> be enlarge and not shrinked... And all of that is in gwenview
> code.

Warning Angelo. digikam print interface use the Color mangement stuff to
optimize printing (if it enable of course). It the same thing than Krita.
Gwenview do not have a Color management interface. Take a care to unbreak
something when you port this code.


> Anyway the attached patch is something that improve the print function.
> Hope you'll like it and commit (i can do it if you like).

I really appreciate all contributions, epecially about printing stuff...

Please use B.K.O instead ML to post patch. It more easy to manage old messages
in B.K.O instead ML, because mail box are generaly spamed. It not the case of
B.K.O. Create a new file if necessary...

I will study you patch today...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le dimanche 7 janvier 2007 09:31, Caulier Gilles(UNTRUSTED, sender is
<digikam-devel-bounces-+caulier.gilles=[hidden email]>) a écrit :
> > Just another thought, why trash is near print in the menu, it seems
> > a bit dangerous...
>
> Fine. I propose to move Print option just behind Last option from File
> menu.

I want said the "File/Last (Ctrl+End)" option (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le vendredi 29 décembre 2006 22:08, Angelo Naselli a écrit :

> Hi,
> first of all I'd like to introduce myself, as some of you know
> I'm kipi's project coordinator and an occasional developer.
> Since I like the way gwenview prints photos (maybe just
> because I did, but I did because i'd have liked to have it :) )
> I decided to port that code here. I mean there are two ways
> to print, either using kipi-plugins or using image editor.
> The first one is the best, but sometime i like to print out an
> image just because i'm watching it. If I use gwenview the code
> allows it and manages two options that are missed here e.g.
> keep ratio and alignment. Well there is something more but i've
> spent a lot of time to insert gui objects, I'm not very good at it
> and i prefer to use ui files and designer (Gilles I know you don't,
> but it's very easy for occasional contributors), so the code is still
> in gwenview. Just want to recall the B&W option I cannot believe someone
> ever used it, two colors, better using grayscale, but that is a driver
> option, so no need to add it ;) (even if the preview is not good)
> IIRC the so called "fit to page" option works if an image has to
> be enlarge and not shrinked... And all of that is in gwenview
> code.
> Anyway the attached patch is something that improve the print function.
> Hope you'll like it and commit (i can do it if you like).
>
> Just another thought, why trash is near print in the menu, it seems
> a bit dangerous...
>
> Regards,
> Angelo

Tested here. Patch sound fine for me. You can commit source code.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le dimanche 7 janvier 2007 14:08, Caulier Gilles(UNTRUSTED, sender is
<digikam-devel-bounces-+caulier.gilles=[hidden email]>) a écrit :

> Le vendredi 29 décembre 2006 22:08, Angelo Naselli a écrit :
> > Hi,
> > first of all I'd like to introduce myself, as some of you know
> > I'm kipi's project coordinator and an occasional developer.
> > Since I like the way gwenview prints photos (maybe just
> > because I did, but I did because i'd have liked to have it :) )
> > I decided to port that code here. I mean there are two ways
> > to print, either using kipi-plugins or using image editor.
> > The first one is the best, but sometime i like to print out an
> > image just because i'm watching it. If I use gwenview the code
> > allows it and manages two options that are missed here e.g.
> > keep ratio and alignment. Well there is something more but i've
> > spent a lot of time to insert gui objects, I'm not very good at it
> > and i prefer to use ui files and designer (Gilles I know you don't,
> > but it's very easy for occasional contributors), so the code is still
> > in gwenview. Just want to recall the B&W option I cannot believe someone
> > ever used it, two colors, better using grayscale, but that is a driver
> > option, so no need to add it ;) (even if the preview is not good)
> > IIRC the so called "fit to page" option works if an image has to
> > be enlarge and not shrinked... And all of that is in gwenview
> > code.
> > Anyway the attached patch is something that improve the print function.
> > Hope you'll like it and commit (i can do it if you like).
> >
> > Just another thought, why trash is near print in the menu, it seems
> > a bit dangerous...
> >
> > Regards,
> > Angelo
>
> Tested here. Patch sound fine for me. You can commit source code.
>
> Gilles

Angelo,

Look like with your patch, there is something wrong with layout management of
print dialog. Look the error messages from Qt on the console :

QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout for
Digikam::ImageEditorPrintDialogPage/digikam page
QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout for
Digikam::ImageEditorPrintDialogPage/digikam page

Can you fix it ?

Gilles



> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> This is my viewpoint (:=))). This cannot be representative of all Qt
> developpers of course.
>
> I would to have the viewpoint of Marcel about this point (:=))...
>
IMO, the problem is, at least as far as i can see from gwenview and
kipi-plugins the lack of contribution. And since we received mails
in kipi ml in which someone asked for a more easy to contribute
gui design (e.g. using ui files) I believe it is a thing to take
in account. I mean I had programmed in win 3.11 by hands, and I
saw the difference using visual as you said, I believe I can use
QT from scratch, but using a designer that it's more user friendly
can save time, and time, as you know it's important more than ever
if you're using your spare one to contribute ;)
 
> > Just want to recall the B&W option I cannot believe someone
> > ever used it, two colors, better using grayscale,
>
> Heu B&W == greyscale ???
Well if you take that code from kuickshow i doubt, it should be 2 colors
B&W indeed.
>
>
> > but that is a driver
> > option, so no need to add it ;)
>
> Right. On the past (digikam 0.7.x) i have backported the print interface from
> kuickshow and refactorized it (the B&W stuff come from kuickshow in fact).
> I'm sure than it can be optimized.
hmm maybe above i was right ;)
> > (even if the preview is not good)
> > IIRC the so called "fit to page" option works if an image has to
> > be enlarge and not shrinked... And all of that is in gwenview
> > code.
>
> Warning Angelo. digikam print interface use the Color mangement stuff to
> optimize printing (if it enable of course). It the same thing than Krita.
> Gwenview do not have a Color management interface. Take a care to unbreak
> something when you port this code.
I saw it and nothing should change there, the code has to be studied
to make a change like that, but as i did for this patch I could for others.
The problem is i finished my holidays... and so spare time has to be fitted
in kipi and gwenview as well, not say mandriva ;)
>
>
> > Anyway the attached patch is something that improve the print function.
> > Hope you'll like it and commit (i can do it if you like).
>
> I really appreciate all contributions, epecially about printing stuff...
Thanks.
> Please use B.K.O instead ML to post patch. It more easy to manage old messages
> in B.K.O instead ML, because mail box are generaly spamed. It not the case of
> B.K.O. Create a new file if necessary...
You're right, since i saw there was a maintainer for print stuff i didn't
want to have a contact here :) I'll do it in future  
 
Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> Angelo,
>
> Look like with your patch, there is something wrong with layout management of
> print dialog. Look the error messages from Qt on the console :
>
> QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout for
> Digikam::ImageEditorPrintDialogPage/digikam page
> QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout for
> Digikam::ImageEditorPrintDialogPage/digikam page
ARGH! As I told you first i do hate doing that by hands :)
 
> Can you fix it ?
I'll take a look at it tonight.

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> You're right, since i saw there was a maintainer for print stuff i didn't
> want to have a contact here :) I'll do it in future  
Ehm, just wanted to say, I thought this ml was the right place...

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le dimanche 7 janvier 2007 15:09, Angelo Naselli a écrit :
> > You're right, since i saw there was a maintainer for print stuff i didn't
> > want to have a contact here :) I'll do it in future
>
> Ehm, just wanted to say, I thought this ml was the right place...
>
> Angelo

Yes, no problem.

Angelo, if you want to maintain the digiKam image editor stuff, well, welcome
(:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le dimanche 7 janvier 2007 14:53, Angelo Naselli a écrit :

> > Angelo,
> >
> > Look like with your patch, there is something wrong with layout
> > management of print dialog. Look the error messages from Qt on the
> > console :
> >
> > QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout
> > for Digikam::ImageEditorPrintDialogPage/digikam page
> > QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout
> > for Digikam::ImageEditorPrintDialogPage/digikam page
>
> ARGH! As I told you first i do hate doing that by hands :)

No (:=))) layout management with Qt is very simple. Look in my code generaly
(80%) i use a QGridLayout everywhere. My code can be used like example.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le dimanche 7 janvier 2007 14:53, Angelo Naselli a écrit :

> > Angelo,
> >
> > Look like with your patch, there is something wrong with layout
> > management of print dialog. Look the error messages from Qt on the
> > console :
> >
> > QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout
> > for Digikam::ImageEditorPrintDialogPage/digikam page
> > QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout
> > for Digikam::ImageEditorPrintDialogPage/digikam page
>
> ARGH! As I told you first i do hate doing that by hands :)
>
> > Can you fix it ?
>
> I'll take a look at it tonight.
>
> Angelo

Angelo,

Let's me look indeep the code. Some part need to be polished. I will fix the
problem and commit source code.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le dimanche 7 janvier 2007 14:53, Angelo Naselli a écrit :

> > Angelo,
> >
> > Look like with your patch, there is something wrong with layout
> > management of print dialog. Look the error messages from Qt on the
> > console :
> >
> > QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout
> > for Digikam::ImageEditorPrintDialogPage/digikam page
> > QLayout: Adding QHBox/unnamed (child of QVButtonGroup/unnamed) to layout
> > for Digikam::ImageEditorPrintDialogPage/digikam page
>
> ARGH! As I told you first i do hate doing that by hands :)

It's not your code. This problem is relevant of layout used by Color
Management options. I will fix it.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> Angelo,
>
> Let's me look indeep the code. Some part need to be polished. I will fix the
> problem and commit source code.

As I told you once you're months far from me ;)
Thanks, as soon as I find new time i'll see if i can port
other options as well, from gwenview.

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le dimanche 7 janvier 2007 20:02, Angelo Naselli a écrit :
> > Angelo,
> >
> > Let's me look indeep the code. Some part need to be polished. I will fix
> > the problem and commit source code.
>
> As I told you once you're months far from me ;)
> Thanks, as soon as I find new time i'll see if i can port
> other options as well, from gwenview.

Fine for me.

I'm currently polishing the cource code on print stuff... Look my next commits
for details

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel